From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: William Tu <u9012063@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>,
Nick Connolly <nick.connolly@mayadata.io>,
Omar Cardona <ocardona@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers
Date: Fri, 1 Oct 2021 12:51:17 +0300 [thread overview]
Message-ID: <20211001125117.28f546b2@sovereign> (raw)
In-Reply-To: <20211001123605.00fa6402@sovereign>
2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk:
> 2021-10-01 09:27 (UTC+0200), David Marchand:
> > [...]
> > I just have a concern that headers get broken again if we have no check.
> > Could buildtools/chkincs do the job (if we make this check work on Windows)?
>
> It's a valid caoncern and yes, chkincs would be a solution.
>
> I discovered that the real issue with chkincs was a space after shebang in
> gen_c_file_for_header.py. If it is removed, find_program() is able to parse
> the line and call the script with Python interpreter. However, spaces
> *are* allowed after shebangs. Would you like me to submit a patch with a fix
> just chkincs or shall I *instead* work with meson developers (I'll do that
> anyway)? I'm asking because we have other files with extra spaces, so there's
> a question if we should fix them, add a rule for the space, etc.
Just re-checked with meson 0.57.0 (as recommended in Windows GSG) and hit no
issue even with a space after "#!". Maybe it was a meson 0.47 issue on
Windows at the time you disabled chkins there?
next prev parent reply other threads:[~2021-10-01 9:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 20:46 [dpdk-dev] [PATCHv2] include: fix sys/queue.h William Tu
2021-08-11 15:50 ` Dmitry Kozlyuk
2021-08-11 18:13 ` William Tu
2021-08-12 20:05 ` [dpdk-dev] [PATCHv3] " William Tu
2021-08-12 21:58 ` Dmitry Kozlyuk
2021-08-13 1:02 ` [dpdk-dev] [PATCHv4] eal: remove sys/queue.h from public headers William Tu
2021-08-13 1:11 ` Stephen Hemminger
2021-08-13 1:36 ` William Tu
2021-08-13 3:36 ` [dpdk-dev] [PATCHv5] " William Tu
2021-08-13 18:59 ` Dmitry Kozlyuk
2021-08-14 2:31 ` William Tu
2021-08-14 2:51 ` [dpdk-dev] [PATCH v6] " William Tu
2021-08-17 22:06 ` Dmitry Kozlyuk
2021-08-18 23:26 ` [dpdk-dev] [PATCH v7] " William Tu
2021-08-19 23:29 ` Dmitry Kozlyuk
2021-08-23 12:34 ` William Tu
2021-08-23 13:03 ` [dpdk-dev] [PATCH v8] " William Tu
2021-08-23 19:14 ` Dmitry Kozlyuk
2021-08-24 16:11 ` William Tu
2021-08-24 16:21 ` [dpdk-dev] [PATCH v9] " William Tu
2021-09-20 20:11 ` Narcisa Ana Maria Vasile
2021-09-30 22:16 ` William Tu
2021-10-01 7:27 ` David Marchand
2021-10-01 9:36 ` Dmitry Kozlyuk
2021-10-01 9:51 ` Dmitry Kozlyuk [this message]
2021-10-01 9:55 ` David Marchand
2021-10-01 10:12 ` Bruce Richardson
2021-10-01 10:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001125117.28f546b2@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=navasile@linux.microsoft.com \
--cc=nick.connolly@mayadata.io \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).