From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52FACA0032; Fri, 1 Oct 2021 21:52:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFEFB41194; Fri, 1 Oct 2021 21:52:51 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2064.outbound.protection.outlook.com [40.107.220.64]) by mails.dpdk.org (Postfix) with ESMTP id 23C3641183 for ; Fri, 1 Oct 2021 21:52:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K1toopLdEcrExAmxXMruqsZf6tZZgqGv2cRkL5TKnJ7iKiLQkMm4X6zjtmU12Nxq5ccXepFWgdLPTG14PkuZnnF0LN7tPLTR/dBcsPcIlZqpYeGyObjs0NFqjJTee7tCEfDpuEbB7lMFmm0FrJKCJpeNRjATSmTOAl2f+S5PrVMIr7gmaA7iZmK0keOxGC15G98xrtl5SYS1LQbOHEPLsB2zIOF5lg7rHvRJSoZ8iNXxBlYszQN41be7YJ81p+mh0en8QTWhjRBGkItnL3OGgDvBQSo1SepQTiYdfyo13G2x4q62eQj1bBSb0IiEhMMCZcRn9y54PWJo0WBXsLm0pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UATAETL6wW8GCgH9ns/3taOiuCvlGGmqYOweZBkF8Ng=; b=J3/jC5yZGYRloRRrAEGU27+0shB7FUi5SsxI6ha/hR0uBf4i5YvQQXCQuaiFWSPeaPXKyIZuVGGiNQyhYbVjfXe1xXkqBsZFKMyTPjZ7Qt5yioQWcE+rHG+TLfmkT2+Sox70wa9QhTLmJqtY+cPLXAolE1nAmSyKU+fRwEziA0jQAbIiOMtTXLGV71ZxFgAzK3drPCV3wxsRAGWJMIVFmW+P7AF79AgGEEnIwRGJBzWyXRxZoU5fuVdDbZ3eS5kw0CUgwaPBGh0Al0S0PQjYSSLAtAj861ZjvblspbU6eCQVrL7Szz1+RjBDkqvU04i/lkcrvVP2uwKU9v5X4GUIiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UATAETL6wW8GCgH9ns/3taOiuCvlGGmqYOweZBkF8Ng=; b=sTXxQAEph5j95W/oqHDh8ZyovOQoxcFW8jC48X4QxO3N+RcJt2N9rFEGqPMok5LiV4jLA77mLDsJMyAwJFfCc4Qlk7rCFpl2xMtji0Tg5a1npaOAQuKWD1EswZ6xj54IjVoCZaljup/d/4hTkcO92IZmbJFzMemP7IwwFKEnhtQ/zgzmBvmPRBFD5ho5XN+QLy01esBbf3Wdf/0J7CCbxxwZCl0tASNzzndaVokxk9nVW86bf/Z8Mjuz+B7pUjhXWIEVrZwU/MOPWf4w+nJbQPNpqwxIH0Xf3ef6y3P3ylDxcDe+b97dEQVLD2vJbExa+4whKYoDed8rIQEYqI0lCg== Received: from CO1PR15CA0058.namprd15.prod.outlook.com (2603:10b6:101:1f::26) by BY5PR12MB4033.namprd12.prod.outlook.com (2603:10b6:a03:213::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct 2021 19:52:47 +0000 Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:101:1f:cafe::6c) by CO1PR15CA0058.outlook.office365.com (2603:10b6:101:1f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Fri, 1 Oct 2021 19:52:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 19:52:47 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 1 Oct 2021 19:52:40 +0000 From: Viacheslav Ovsiienko To: CC: , , , , , Date: Fri, 1 Oct 2021 22:52:20 +0300 Message-ID: <20211001195223.31909-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210910141609.8410-1-viacheslavo@nvidia.com> References: <20210910141609.8410-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d735aeb-3c19-47ba-9f15-08d985150ae3 X-MS-TrafficTypeDiagnostic: BY5PR12MB4033: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jKyC6ICzR+Uym2/bARgAfkMzZUyjJdjmhkuNTwpqS1T/3PJsiBJFqBqit1jftJE6CEvdkkboW84SMVW74jjllsYftvHEl4AZWNmJ1pCWrJS/dEuf/0rYXxfGP3RT4b4aCMNLL82Pa2yOEsdeTZzLpTVC9KWHgpNU823F+GOur36FofV99kpHW+ISAcWGw7SQs2U695APBqzwsw3FWfnjKOLaRXlQFYGpqjMvcfYjLvvpWFaOGeRm0MKsz8jOlic6Wmkr+8Y+qVeao9H0b3xdruJMoDuYa2/zq3PbmpTKkeLTjIGpX2xte5H7B0WZJLAWnPGo5djQWnp5EkCQwccoBwSQbLXTc157bdfVuRXG8Rx2C3qaADeetqXCak/zs1emwYDcJCYzJD0VklCg6b1o87nXSQEwDUPggrSEZb2O8gg8Vtd3xFeG2MGIwt+2uBiw4UhXslnI9aidIGftY88KmHcLdaweMm1+uey4HnJ1WjIDNE7JNPWlTSiY7wAdiUOO185L9SpcXijliqfcxMPpWcF7Da/yeMtplBpPXd5vBwAwq1KaOYClbdTwe+t3PfMLp9IJstGlNSfy31rNOmeN9nwwJOY81QJQBK07wxrAg2xKELdeW5UBu6b+EtdrhA4AbXIGvKN2iHBLmmmsEHY3OZtHCXNjZ4Wr2ck6eykFg4kwcLTJ6EuwJFjy5Ni3Z3/AhoIvOW/hsorxmg6A7+tPdoj2tGhbfZUN1ruN7qSS+a+Ey1LrwFZTEtEuoWcvTfQxAePzyjrkMp626s0wFNq8Yq9NnK13DlkQXQj6mteDClc= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(8676002)(82310400003)(2906002)(1076003)(316002)(36756003)(5660300002)(6286002)(8936002)(15650500001)(336012)(7696005)(4326008)(426003)(86362001)(83380400001)(70206006)(70586007)(6916009)(26005)(6666004)(36860700001)(54906003)(47076005)(55016002)(7636003)(508600001)(16526019)(186003)(966005)(356005)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 19:52:47.2503 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d735aeb-3c19-47ba-9f15-08d985150ae3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4033 Subject: [dpdk-dev] [PATCH 0/3] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ethdev: update modify field flow action The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the byte ordering for 64-bit integer was not specified. Many fields have lesser lengths and byte ordering is crucial. - how the bit offset is applied to the immediate source field was not defined and documented - 64-bit integer size is not enough to provide MAC and IPv6 addresses In order to cover the issues and exclude any ambiguities the following is done: - introduce the explicit pointer field in rte_flow_action_modify_data structure - replace the 64-bit unsigned integer with 16-byte array - update the modify field flow action documentation [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ Signed-off-by: Viacheslav Ovsiienko Viacheslav Ovsiienko (3): ethdev: update modify field flow action app/testpmd: update modify field flow action support app/testpmd: fix hex string parser in flow commands app/test-pmd/cmdline_flow.c | 60 ++++++++++++++++++-------- doc/guides/prog_guide/rte_flow.rst | 8 ++++ doc/guides/rel_notes/release_21_11.rst | 7 +++ lib/ethdev/rte_flow.h | 15 +++++-- 4 files changed, 69 insertions(+), 21 deletions(-) -- 2.18.1