From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85DF3A0032; Sat, 2 Oct 2021 16:16:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EDD34116A; Sat, 2 Oct 2021 16:16:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4620240042 for ; Sat, 2 Oct 2021 16:16:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633184190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lBfireKgtj0aaeAq5lYT/5aUIBCtEYkIiqI9ojceh68=; b=I2hA/Nascg5wCYgCm5FnUrW5HQ4GWzPa6qoN0DuCvemjrAOCY93nOOp3TqjShCVjOwVFWP wb7JliXH8ZjKRettcesT2Oo2MyphmTxZk+cV2V1HgqGpJHcJMGGp+FnvDRiMBRDRYVSDwx LRBsaVCgh/uL7gK3X9vQOQei6c0qXkI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-482-QRoJB2MJOgegV8m7ILNOZw-1; Sat, 02 Oct 2021 10:16:27 -0400 X-MC-Unique: QRoJB2MJOgegV8m7ILNOZw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1D97800053; Sat, 2 Oct 2021 14:16:26 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.194.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id 878D35C1D0; Sat, 2 Oct 2021 14:16:25 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: olivier.matz@6wind.com Date: Sat, 2 Oct 2021 16:16:14 +0200 Message-Id: <20211002141614.14784-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH] mbuf: promote some helpers to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Those accessors have been introduced more than two years ago (rte_mbuf_to_priv in v18.05, rte_mbuf_*_addr* in v19.02). Time to mark them stable. rte_mbuf_to_baddr() could be removed, but since we lack a deprecation notice, keep it as a simple wrapper. Signed-off-by: David Marchand --- lib/mbuf/rte_mbuf.h | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h index a555f216ae..756a0462a2 100644 --- a/lib/mbuf/rte_mbuf.h +++ b/lib/mbuf/rte_mbuf.h @@ -191,11 +191,6 @@ rte_mbuf_from_indirect(struct rte_mbuf *mi) * mbuf is already known because it doesn't need to access mbuf contents in * order to get the mempool pointer. * - * @warning - * @b EXPERIMENTAL: This API may change without prior notice. - * This will be used by rte_mbuf_to_baddr() which has redundant code once - * experimental tag is removed. - * * @param mb * The pointer to the mbuf. * @param mp @@ -203,7 +198,6 @@ rte_mbuf_from_indirect(struct rte_mbuf *mi) * @return * The pointer of the mbuf buffer. */ -__rte_experimental static inline char * rte_mbuf_buf_addr(struct rte_mbuf *mb, struct rte_mempool *mp) { @@ -213,26 +207,15 @@ rte_mbuf_buf_addr(struct rte_mbuf *mb, struct rte_mempool *mp) /** * Return the default address of the beginning of the mbuf data. * - * @warning - * @b EXPERIMENTAL: This API may change without prior notice. - * * @param mb * The pointer to the mbuf. * @return * The pointer of the beginning of the mbuf data. */ -__rte_experimental static inline char * -rte_mbuf_data_addr_default(__rte_unused struct rte_mbuf *mb) +rte_mbuf_data_addr_default(struct rte_mbuf *mb) { - /* gcc complains about calling this experimental function even - * when not using it. Hide it with ALLOW_EXPERIMENTAL_API. - */ -#ifdef ALLOW_EXPERIMENTAL_API return rte_mbuf_buf_addr(mb, mb->pool) + RTE_PKTMBUF_HEADROOM; -#else - return NULL; -#endif } /** @@ -251,13 +234,7 @@ rte_mbuf_data_addr_default(__rte_unused struct rte_mbuf *mb) static inline char * rte_mbuf_to_baddr(struct rte_mbuf *md) { -#ifdef ALLOW_EXPERIMENTAL_API return rte_mbuf_buf_addr(md, md->pool); -#else - char *buffer_addr; - buffer_addr = (char *)md + sizeof(*md) + rte_pktmbuf_priv_size(md->pool); - return buffer_addr; -#endif } /** @@ -272,7 +249,6 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) * @return * The starting address of the private data area of the given mbuf. */ -__rte_experimental static inline void * rte_mbuf_to_priv(struct rte_mbuf *m) { -- 2.23.0