From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CC2EA0C4D; Mon, 4 Oct 2021 17:55:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9D7A41313; Mon, 4 Oct 2021 17:55:39 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 18608412E6 for ; Mon, 4 Oct 2021 17:55:38 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id m26so1636943pff.3 for ; Mon, 04 Oct 2021 08:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zcei+vG8bA47Honpn6m/iLpGF5A+3z2kee2oabsIcxI=; b=0sTgjv4xqMhdj9sxC5zlQ1vsUqYtHVDX0JUpTHkE4r+hoDXUgvBw46Wbk+NAZ0O2VE c0EGs0RHJWZU4yFujhY08kTfwXP497JC00fzs060ndGwAfMFLTEjGqK/v837ajgHbmVr ZIuYu3tidTmnrMi+OCgDu578hjD/d/hINJhTeoEB2QeLQtGZrPyypVBtCIye1IKE9On1 Y8rT1BdooLrXQ10d6ErIH9NeNsP/SqnvaLOFmgR9Jt5pu2lfnB4cjXE1MwrBPzpEEgcb 6fZ3T6NAWvN/eh/oWHdYQs6kn+CVRAwXjUTqkJBix8gZBv0Z2R6CAdXrQeFsVwX/KeNd f+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zcei+vG8bA47Honpn6m/iLpGF5A+3z2kee2oabsIcxI=; b=X9eDHzF+E5bn0EzXGPdg45dsqHaMrfycXWHf1vnarerG/6w6Z6gvGIS+U1USDTTddy jMHS7RmoTt9LmMTpCMA4w3I3m/JfWBVz56WPmegTR3CC7Igmo8pKhyAY4QV28KmqJzVH hT782YSLHp7V1Ze4ptmpRzvzEAnX8HewY4ADPZ0QBZEH1CrLjMIuaf+EUl3AvLoemQmJ A+p5bDRLszHeZxQMpQZaisrpFkhz/39ZbXB6t689onkdgkP52qXTC+60SsydKyj3RMSL p0Hb1BCJ1NXH+Jeel7tlBAuYF6fX6AIfhm5W4Vr5ebdY01ABQTA01AdX+bob0ALvtaCD wJ/w== X-Gm-Message-State: AOAM532sUV4vGYV72mNqsQM2ToY+vZqkfYn8dP4yG6J6Td+CJ3Ue9Zd/ 1K24GGIXq+JCeXimQ8JNei+ofw== X-Google-Smtp-Source: ABdhPJzj+l2yom69Dej+q9wKtVXbSj0XBguZ4XYTSDWheR1y5hW7IvOztUdvLbgNuTZpDV7pHND3Sg== X-Received: by 2002:a63:1656:: with SMTP id 22mr11578298pgw.20.1633362937913; Mon, 04 Oct 2021 08:55:37 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id z17sm14837236pfa.148.2021.10.04.08.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 08:55:37 -0700 (PDT) Date: Mon, 4 Oct 2021 08:55:35 -0700 From: Stephen Hemminger To: Sean Morrissey Cc: dev@dpdk.org Message-ID: <20211004085535.2a56e0b1@hermes.local> In-Reply-To: <20211004101058.2396458-1-sean.morrissey@intel.com> References: <20211004101058.2396458-1-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 0/5] introduce IWYU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 4 Oct 2021 10:10:53 +0000 Sean Morrissey wrote: > This patchset introduces the include-what-you-use script which removes > unused header includes. IWYU GitHub: > > https://github.com/include-what-you-use/include-what-you-use > > Along with the script there are some patches which make a start on > removing unneeded headers. > > Sean Morrissey (5): > devtools: script to remove unused headers includes > lib/telemetry: remove unneeded header includes > lib/ring: remove unneeded header includes > lib/kvargs: remove unneeded header includes > lib/eal: remove unneeded header includes > > devtools/process_iwyu.py | 109 +++++++++++++++++++++++++ > lib/eal/common/eal_common_dev.c | 5 -- > lib/eal/common/eal_common_devargs.c | 1 - > lib/eal/common/eal_common_errno.c | 4 - > lib/eal/common/eal_common_fbarray.c | 3 - > lib/eal/common/eal_common_hexdump.c | 3 - > lib/eal/common/eal_common_launch.c | 6 -- > lib/eal/common/eal_common_lcore.c | 6 -- > lib/eal/common/eal_common_log.c | 2 - > lib/eal/common/eal_common_memalloc.c | 3 - > lib/eal/common/eal_common_memory.c | 5 -- > lib/eal/common/eal_common_memzone.c | 4 - > lib/eal/common/eal_common_options.c | 2 - > lib/eal/common/eal_common_proc.c | 2 - > lib/eal/common/eal_common_string_fns.c | 2 - > lib/eal/common/eal_common_tailqs.c | 11 --- > lib/eal/common/eal_common_thread.c | 3 - > lib/eal/common/eal_common_timer.c | 6 -- > lib/eal/common/eal_common_trace.c | 1 - > lib/eal/common/hotplug_mp.h | 1 - > lib/eal/common/malloc_elem.c | 6 -- > lib/eal/common/malloc_heap.c | 5 -- > lib/eal/common/malloc_mp.c | 1 - > lib/eal/common/malloc_mp.h | 2 - > lib/eal/common/rte_malloc.c | 6 -- > lib/eal/common/rte_random.c | 3 - > lib/eal/common/rte_service.c | 6 -- > lib/eal/include/rte_version.h | 2 - > lib/eal/linux/eal.c | 10 --- > lib/eal/linux/eal_alarm.c | 7 -- > lib/eal/linux/eal_cpuflags.c | 2 - > lib/eal/linux/eal_debug.c | 5 -- > lib/eal/linux/eal_dev.c | 4 - > lib/eal/linux/eal_hugepage_info.c | 8 -- > lib/eal/linux/eal_interrupts.c | 8 -- > lib/eal/linux/eal_lcore.c | 7 -- > lib/eal/linux/eal_log.c | 11 +-- > lib/eal/linux/eal_memalloc.c | 8 -- > lib/eal/linux/eal_memory.c | 9 -- > lib/eal/linux/eal_thread.c | 5 -- > lib/eal/linux/eal_timer.c | 15 ---- > lib/eal/linux/eal_vfio_mp_sync.c | 1 - > lib/eal/unix/eal_file.c | 1 - > lib/eal/unix/rte_thread.c | 1 - > lib/eal/x86/rte_cycles.c | 1 - > lib/kvargs/rte_kvargs.c | 1 - > lib/ring/rte_ring.c | 7 -- > lib/telemetry/telemetry.c | 1 - > lib/telemetry/telemetry_data.h | 1 - > 49 files changed, 110 insertions(+), 213 deletions(-) > create mode 100755 devtools/process_iwyu.py > There is a risk of breaking builds on other platforms. How can you be sure the include files (especially auto generated list) are the same in Linux, FreeBSD and Windows as well as the special versions of libc (musl etc).