From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 648B4A0C4D; Mon, 4 Oct 2021 17:59:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD5654137D; Mon, 4 Oct 2021 17:59:39 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 86A7B4134D for ; Mon, 4 Oct 2021 17:59:38 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id v19so11888361pjh.2 for ; Mon, 04 Oct 2021 08:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y3lJ0v6Ijf1IqqJyGZVevjt06M7C7p0Ia93YS68fhxQ=; b=qonhsFlIISWIym2JVN4/696NzPXC2UOdxVx4QDBDDw1FmuBKo6NOreDCerPYm89A4G hxgQ9MU0LkieD5iv1524wc/ATLZCx3UAHxAK9zj+jV6dOUtrEfiZDwretmuSRHV1I2Xv VM6OY0j3qZl6aY5TUt0+JmOURbo/PPcv7WIN/Qa+rFMEsphpFWLPf5DNCTNWAS/vUBYq YAwyQr7aN7p90Am9c7zWAjcfRJ4mkkXflAjBXAgRAeayK5VMx186hvg29leSisKxYA7I 8i/s17uupRuItwe1VWbEyYgRKbozOa1DZM2KEdU/dERuhydPZN4ZHq6MoWUkg6NML4L6 +IEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y3lJ0v6Ijf1IqqJyGZVevjt06M7C7p0Ia93YS68fhxQ=; b=WDH+vRXpAUhyViyadCF/1PKkCaUP2wsu+9PGJ1Sz8TMGwq+0gEyz0ghbMFbFDr0srN ndPZ8u4CjGKyBkO/mJHbIKPpMACkfmVrE8hrH9sXHrmq367PxivmEc59+YeyIGJ7csWi xVgfSywS45I2tS7847lJRClureN9WrEbMhTG1DyIuFzH0YuiAP9PMZtBKU4DiwGOwHSb 2gqxYLz+0anChN9BVmTaD6Cp1n0LC5h7tnbJvWQaLX4J52Isscj3o4H7Vxj64vGGzEJ1 cKVH9d9su4hJNKXKMrCE93UwKxHsncfd7mQn+9GZreBNLHDEVrcaaO7REs5KgDBXcjma xwKw== X-Gm-Message-State: AOAM530e/L1662AcfU+YrdeLgFKhMfzfSradi1+lhtFt9Qi4JhrNSVcR 82Wd2hRtkd2/lHwkdXXw7M2ESQ== X-Google-Smtp-Source: ABdhPJxMBcF9BN1wCqUQ5/VU+oUB92IUxxgVT1pc2Ti2vF1JV1LF9XOV/L0oSxUzIiOfeJS+0tldTQ== X-Received: by 2002:a17:90a:c686:: with SMTP id n6mr22223879pjt.157.1633363177438; Mon, 04 Oct 2021 08:59:37 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id r13sm14627643pgl.90.2021.10.04.08.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 08:59:37 -0700 (PDT) Date: Mon, 4 Oct 2021 08:59:34 -0700 From: Stephen Hemminger To: Gregory Etelson Cc: , , , , , Bernard Iremonger Message-ID: <20211004085934.7105af27@hermes.local> In-Reply-To: <20211004121323.6677-1-getelson@nvidia.com> References: <20210527152858.13312-1-getelson@nvidia.com> <20211004121323.6677-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] net: introduce IPv4 ihl and version fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 4 Oct 2021 15:13:22 +0300 Gregory Etelson wrote: > diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c > index 951606f248..4f64be5357 100644 > --- a/app/test/test_flow_classify.c > +++ b/app/test/test_flow_classify.c > @@ -95,7 +95,7 @@ static struct rte_acl_field_def ipv4_defs[NUM_FIELDS_IPV4] = { > * dst mask 255.255.255.00 / udp src is 32 dst is 33 / end" > */ > static struct rte_flow_item_ipv4 ipv4_udp_spec_1 = { > - { 0, 0, 0, 0, 0, 0, IPPROTO_UDP, 0, > + { { .version_ihl = 0}, 0, 0, 0, 0, 0, IPPROTO_UDP, 0, > RTE_IPV4(2, 2, 2, 3), RTE_IPV4(2, 2, 2, 7)} > }; This ends up being an API change which was not announced.