From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE383A0C4D; Mon, 4 Oct 2021 19:27:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D7794139D; Mon, 4 Oct 2021 19:27:09 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 645494139A for ; Mon, 4 Oct 2021 19:27:07 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="212658302" X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="212658302" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 10:27:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="487637899" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.27]) by orsmga008.jf.intel.com with ESMTP; 04 Oct 2021 10:27:04 -0700 From: Ferruh Yigit To: Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin Cc: Ferruh Yigit , dev@dpdk.org Date: Mon, 4 Oct 2021 18:27:02 +0100 Message-Id: <20211004172702.3461360-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/ena: remove useless address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reported by "gcc (GCC) 12.0.0 20211003 (experimental)": ./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’: ./drivers/net/ena/ena_rss.c:140:66: error: the comparison will always evaluate as ‘false’ for the pointer operand in ‘reta_conf + 136’ must not be NULL [-Werror=address] 140 | (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL))) | ^~ Fixing it by removing useless check. Signed-off-by: Ferruh Yigit --- Not clear about the intention of the check, removing it in this patch to trigger the discussion. --- drivers/net/ena/ena_rss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c index 88afe13da04d..152098410fa2 100644 --- a/drivers/net/ena/ena_rss.c +++ b/drivers/net/ena/ena_rss.c @@ -136,8 +136,7 @@ int ena_rss_reta_query(struct rte_eth_dev *dev, int reta_conf_idx; int reta_idx; - if (reta_size == 0 || reta_conf == NULL || - (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL))) + if (reta_size == 0 || reta_conf == NULL) return -EINVAL; if (!(dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH)) { -- 2.31.1