From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE280A0C4D; Mon, 4 Oct 2021 20:50:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DC904068F; Mon, 4 Oct 2021 20:50:54 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id F1B1740688 for ; Mon, 4 Oct 2021 20:50:52 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="205659401" X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="205659401" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 10:27:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,346,1624345200"; d="scan'208";a="521510841" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.27]) by orsmga001.jf.intel.com with ESMTP; 04 Oct 2021 10:27:24 -0700 From: Ferruh Yigit To: Jasvinder Singh , Cristian Dumitrescu Cc: Ferruh Yigit , dev@dpdk.org Date: Mon, 4 Oct 2021 18:27:22 +0100 Message-Id: <20211004172722.3461540-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/softnic: remove useless address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reported by "gcc (GCC) 12.0.0 20211003 (experimental)": ./drivers/net/softnic/rte_eth_softnic_cli.c: In function ‘tmgr_hierarchy_default’: ./drivers/net/softnic/rte_eth_softnic_cli.c:634:73: error: the comparison will always evaluate as ‘true’ for the address of ‘tc_valid’ will never be NULL [-Werror=address] 634 | (¶ms->shared_shaper_id.tc_valid[0]) ? 1 : 0, | ^ Fixing it by removing useless check. Signed-off-by: Ferruh Yigit --- Intention of the check is not clear, sending the basic fix to trigger the discussion for proper fix. --- drivers/net/softnic/rte_eth_softnic_cli.c | 26 +++++++++++------------ 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c index 932ec15f49b0..b04e78c6e0af 100644 --- a/drivers/net/softnic/rte_eth_softnic_cli.c +++ b/drivers/net/softnic/rte_eth_softnic_cli.c @@ -631,7 +631,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[0], .shared_shaper_id = &shared_shaper_id[0], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[0]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[0]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -641,7 +641,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[1], .shared_shaper_id = &shared_shaper_id[1], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[1]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[1]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -651,7 +651,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[2], .shared_shaper_id = &shared_shaper_id[2], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[2]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[2]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -661,7 +661,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[3], .shared_shaper_id = &shared_shaper_id[3], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[3]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[3]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -671,7 +671,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[4], .shared_shaper_id = &shared_shaper_id[4], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[4]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[4]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -681,7 +681,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[5], .shared_shaper_id = &shared_shaper_id[5], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[5]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[5]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -691,7 +691,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[6], .shared_shaper_id = &shared_shaper_id[6], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[6]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[6]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -701,7 +701,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[7], .shared_shaper_id = &shared_shaper_id[7], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[7]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[7]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -711,7 +711,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[8], .shared_shaper_id = &shared_shaper_id[8], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[8]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[8]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -721,7 +721,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[9], .shared_shaper_id = &shared_shaper_id[9], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[9]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[9]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -731,7 +731,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[10], .shared_shaper_id = &shared_shaper_id[10], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[10]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[10]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -741,7 +741,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[11], .shared_shaper_id = &shared_shaper_id[11], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[11]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[11]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, @@ -751,7 +751,7 @@ tmgr_hierarchy_default(struct pmd_internals *softnic, .shaper_profile_id = params->shaper_profile_id.tc[12], .shared_shaper_id = &shared_shaper_id[12], .n_shared_shapers = - (¶ms->shared_shaper_id.tc_valid[12]) ? 1 : 0, + (params->shared_shaper_id.tc_valid[12]) ? 1 : 0, .nonleaf = { .n_sp_priorities = 1, }, -- 2.31.1