From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 993FCA0C41; Tue, 5 Oct 2021 02:52:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2105B4068F; Tue, 5 Oct 2021 02:52:35 +0200 (CEST) Received: from AZHDRRW-EX01.nvidia.com (azhdrrw-ex01.nvidia.com [20.51.104.162]) by mails.dpdk.org (Postfix) with ESMTP id 52E3C40688 for ; Tue, 5 Oct 2021 02:52:34 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by mxs.oss.nvidia.com (10.13.234.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Mon, 4 Oct 2021 17:52:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DgBo6Z0F7INfBkHKF4owwWwQfpdMHEdaTZ9Mz7J+1CTtwcnTDE7/Sjt7yKhodk+xr5ac4fA/8ci84BTukDDUzqF2gJa0tVnzl7QnTUVIHg/CqlnEZfrQm4bcn2yjKB1Iny6Suj2vRq2nQSy+e7QiUDv7aBBxuJgHt/4JcFTfoV+MGIA1kVI/EvwiYNr5950uR4HnIoYvjFN1AEzn/ZktU86bbwFLwJfKd1/0vitazdkaMzrPozvLQu1tDhB09swGhAUmLxFQHKDhMrg0S07pg5IDMBWBceAm9IxEPL4Qj7f0lQP4hhuS4RvMVP/AXMEqaARTXgAKAZwoDcyc+Z8wVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WXXYOV+7ozXeS89PJGWmZ29JzMT2hp8z4W6xd/bok/A=; b=Ca+BHIkw7Gu+Sxi+YvNO5lUdP93dyZTeYWpbVDVbE8dL1F8oxcVo6uyq4a2PVaM13/1JdPS0M2yJNqa36d4WkTja5mJNtaBs+EVXSV0kODCKf1BQ2yq2+Y0u43RiN2b33f/o3TunDEjLqHxUmATU7lqGrVVM7hX5A7g/5NnL8GIuTOnDHJJjujC7YWD471eUyI3b3e7UVopZLUaszw5mUn6ZD5+NdCBJWRFd5FDlniBpywGDwMboMFP8t+yKpqr98tbbO+EMA7wkqeAElBv70Pho3rN3K+r9brCqydiie72RkaV0l2uRjrRa71gePfEdpnfxEY8vuWKHp95q14ZrYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WXXYOV+7ozXeS89PJGWmZ29JzMT2hp8z4W6xd/bok/A=; b=tiomwqD4gt+ZCl9I/ijT/kVB+EhpaCN4b/tHXcWaI0SexuIveSbdyOO9P7e2405A7rJZtMn5eu1OZKrCsbm6H9HjXIhKKax4J67DXq65F5PLfbMSb7SMHvJKBgH0lcW4V7zs/hSt8MHH2ZIyAmiVn8TpYwMvWLV/uHSZXRKMwyEVG6WkybIlnDI5yat1OY275S/5pI34EDl8o1r0n/6b+8NrBGoEMJXnLNtl0xaNWN+b55+8wdWMkmnAR0VP79aRvAP4ux9tH54917gi64RkIOxDW7RDvFJh8z96Ug1tBg312CpqGSTDd7S7O9FJE1cWwU6AYJ3PKp6ARMKvBruXKg== Received: from BN9PR03CA0745.namprd03.prod.outlook.com (2603:10b6:408:110::30) by MN2PR12MB3760.namprd12.prod.outlook.com (2603:10b6:208:158::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Tue, 5 Oct 2021 00:52:32 +0000 Received: from BN8NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::7e) by BN9PR03CA0745.outlook.office365.com (2603:10b6:408:110::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16 via Frontend Transport; Tue, 5 Oct 2021 00:52:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT025.mail.protection.outlook.com (10.13.177.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 00:52:31 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 5 Oct 2021 00:52:29 +0000 From: To: CC: Dmitry Kozlyuk Date: Tue, 5 Oct 2021 03:52:11 +0300 Message-ID: <20211005005216.2427489-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 846f378a-02b6-4895-ce50-08d9879a69bb X-MS-TrafficTypeDiagnostic: MN2PR12MB3760: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hyTJTrLUm/FCv1/mDKtTm5P2S/jH4dpwsFSz9GzO3cFG/IGqmq9v3crVRctFBmgsgX4978VoWBM0wD10liMuPeb17HkIq61WmbhUbnODsZ09Cw5RY0lfuYcN2Q35ydYTIjCs9vQgF7zFuzunJ5A0Tl60Bg3PXmN90HlYoAe5xQb0WnvsUgp6L+8pSRUV5RBBHX+epN9rPnHNyDuKs16G/wkFRoA9eYGSvRxjrBBGjv8u2xEQ8fWw3tU8kj4P7JAnPZ5E6xDQ+g0JpvEmapG2nsU96SFZj9AKcty7zIuMTW63c6hOwh8H3OrPuvSRHniU7oXz/t+g9DPGP4+UZ58WTMQ9CsY6HpIxfu0fPXpsj/F5G9nC6EIHP+7U4A2xXoKdWHc2pJak04w9WwMMFmdZTxQ/0hdNifEiaKYvkUdnoNCIpkOWzSIN7ntNy0kFct+zAgf5zrPSOdzW2IKhD3E6riLe6mzuSLtCp1COPwm6lkdyzimixZF0u6riqVA/LHc8V9osTRT+n6Bc+PnCMiwqXkU6mOAejMMwSQmNIQqEGrwt+j7lAFnhln/TuV6WJOPiiRNRsUoJp+M2YrBYmQdddYvEmVbabu2AmW6jCOtxdP5OYG5VGXrYkt9N44TK89y7Z6taJjOQMt/jOabdTF0swjEv0Uhk9YnsIUsiY3i/+IKVG3VyjxI6U88T6qwMwjPkJza/Lt21XCqQNn8lAR2l0CVo2QQvKe7H+nmk01ld5V/nPgCIbOC5ut0wqLo6esD3F9UDIK+bHEwqEsEHUI53M4LYdRPrxaV5IODbZJrdEks= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(5660300002)(1076003)(26005)(36860700001)(8936002)(6286002)(2616005)(83380400001)(7636003)(426003)(55016002)(336012)(16526019)(107886003)(4326008)(356005)(186003)(82310400003)(70586007)(36756003)(70206006)(316002)(966005)(8676002)(7696005)(47076005)(6916009)(508600001)(6666004)(86362001)(2906002)(2876002); DIR:OUT; SFP:1101; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 00:52:31.6056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 846f378a-02b6-4895-ce50-08d9879a69bb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3760 Subject: [dpdk-dev] [PATCH 0/5] Flow entites behavior on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dmitry Kozlyuk It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD would keep indirect actions. In the end, applications are greatly affected by whatever contract there is and need to know it. It is proposed to advertise capabilities of keeping flow rules and indirect actions (as a special case of shared object) using ethdev info. Then a bug is fixed in mlx5 PMD that prevented indirect RSS action from being kept, and the driver starts advertising the new capability. Prior discussions: 1) http://inbox.dpdk.org/dev/20210727073121.895620-1-dkozlyuk@nvidia.com/ 2) http://inbox.dpdk.org/dev/20210901085516.3647814-1-dkozlyuk@nvidia.com/ Dmitry Kozlyuk (5): ethdev: add capability to keep flow rules on restart ethdev: add capability to keep shared objects on restart net/mlx5: discover max flow priority using DevX net/mlx5: create drop queue using DevX net/mlx5: preserve indirect actions on restart doc/guides/prog_guide/rte_flow.rst | 21 +++ drivers/net/mlx5/linux/mlx5_os.c | 5 - drivers/net/mlx5/mlx5_devx.c | 204 +++++++++++++++++--- drivers/net/mlx5/mlx5_ethdev.c | 1 + drivers/net/mlx5/mlx5_flow.c | 292 ++++++++++++++++++++++++++--- drivers/net/mlx5/mlx5_flow.h | 6 + drivers/net/mlx5/mlx5_flow_dv.c | 103 ++++++++++ drivers/net/mlx5/mlx5_flow_verbs.c | 77 +------- drivers/net/mlx5/mlx5_rx.h | 4 + drivers/net/mlx5/mlx5_rxq.c | 99 ++++++++-- drivers/net/mlx5/mlx5_trigger.c | 10 + lib/ethdev/rte_ethdev.h | 8 + 12 files changed, 696 insertions(+), 134 deletions(-) -- 2.25.1