DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
	Ray Kinsella <mdr@ashroe.eu>,
	Jasvinder Singh <jasvinder.singh@intel.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Conor Walsh <conor.walsh@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH] sort symbols map
Date: Tue,  5 Oct 2021 11:16:26 +0200	[thread overview]
Message-ID: <20211005091626.31885-1-david.marchand@redhat.com> (raw)

Fixed with ./devtools/update-abi.sh $(cat ABI_VERSION)

Fixes: e73a7ab22422 ("net/softnic: promote manage API")
Fixes: 8f532a34c4f2 ("fib: promote API to stable")
Fixes: 4aeb92396b85 ("rib: promote API to stable")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
I added "./devtools/update-abi.sh $(cat ABI_VERSION)" to my checks.

I should have caught it when merging fib and rib patches...
But my eyes (or more likely brain) stopped at net/softnic bits.

What do you think?
Should I wait a bit more and send a global patch to catch any missed
sorting just before rc1?

In the meantime, if you merge .map updates, try to remember to run the
command above.

Thanks.
---
 drivers/net/softnic/version.map |  2 +-
 lib/fib/version.map             | 21 ++++++++++-----------
 lib/rib/version.map             | 33 ++++++++++++++++-----------------
 3 files changed, 27 insertions(+), 29 deletions(-)

diff --git a/drivers/net/softnic/version.map b/drivers/net/softnic/version.map
index cd5afcf155..01e1514276 100644
--- a/drivers/net/softnic/version.map
+++ b/drivers/net/softnic/version.map
@@ -1,8 +1,8 @@
 DPDK_22 {
 	global:
 
-	rte_pmd_softnic_run;
 	rte_pmd_softnic_manage;
+	rte_pmd_softnic_run;
 
 	local: *;
 };
diff --git a/lib/fib/version.map b/lib/fib/version.map
index af76add2b9..b23fa42b9b 100644
--- a/lib/fib/version.map
+++ b/lib/fib/version.map
@@ -1,25 +1,24 @@
 DPDK_22 {
 	global:
 
-	rte_fib_add;
-	rte_fib_create;
-	rte_fib_delete;
-	rte_fib_find_existing;
-	rte_fib_free;
-	rte_fib_lookup_bulk;
-	rte_fib_get_dp;
-	rte_fib_get_rib;
-	rte_fib_select_lookup;
-
 	rte_fib6_add;
 	rte_fib6_create;
 	rte_fib6_delete;
 	rte_fib6_find_existing;
 	rte_fib6_free;
-	rte_fib6_lookup_bulk;
 	rte_fib6_get_dp;
 	rte_fib6_get_rib;
+	rte_fib6_lookup_bulk;
 	rte_fib6_select_lookup;
+	rte_fib_add;
+	rte_fib_create;
+	rte_fib_delete;
+	rte_fib_find_existing;
+	rte_fib_free;
+	rte_fib_get_dp;
+	rte_fib_get_rib;
+	rte_fib_lookup_bulk;
+	rte_fib_select_lookup;
 
 	local: *;
 };
diff --git a/lib/rib/version.map b/lib/rib/version.map
index 6eb1252acb..f356fe8849 100644
--- a/lib/rib/version.map
+++ b/lib/rib/version.map
@@ -1,21 +1,6 @@
 DPDK_22 {
 	global:
 
-	rte_rib_create;
-	rte_rib_find_existing;
-	rte_rib_free;
-	rte_rib_get_depth;
-	rte_rib_get_ext;
-	rte_rib_get_ip;
-	rte_rib_get_nh;
-	rte_rib_get_nxt;
-	rte_rib_insert;
-	rte_rib_lookup;
-	rte_rib_lookup_parent;
-	rte_rib_lookup_exact;
-	rte_rib_set_nh;
-	rte_rib_remove;
-
 	rte_rib6_create;
 	rte_rib6_find_existing;
 	rte_rib6_free;
@@ -26,10 +11,24 @@ DPDK_22 {
 	rte_rib6_get_nxt;
 	rte_rib6_insert;
 	rte_rib6_lookup;
-	rte_rib6_lookup_parent;
 	rte_rib6_lookup_exact;
-	rte_rib6_set_nh;
+	rte_rib6_lookup_parent;
 	rte_rib6_remove;
+	rte_rib6_set_nh;
+	rte_rib_create;
+	rte_rib_find_existing;
+	rte_rib_free;
+	rte_rib_get_depth;
+	rte_rib_get_ext;
+	rte_rib_get_ip;
+	rte_rib_get_nh;
+	rte_rib_get_nxt;
+	rte_rib_insert;
+	rte_rib_lookup;
+	rte_rib_lookup_exact;
+	rte_rib_lookup_parent;
+	rte_rib_remove;
+	rte_rib_set_nh;
 
 	local: *;
 };
-- 
2.23.0


             reply	other threads:[~2021-10-05  9:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  9:16 David Marchand [this message]
2021-10-05 14:16 ` Kinsella, Ray
2021-10-05 14:31   ` David Marchand
2021-10-05 15:06   ` David Marchand
2021-10-11 11:36 ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005091626.31885-1-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=conor.walsh@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jasvinder.singh@intel.com \
    --cc=mdr@ashroe.eu \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).