From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62852A0C47; Tue, 5 Oct 2021 13:06:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D749A41324; Tue, 5 Oct 2021 13:06:23 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id A68AA41321 for ; Tue, 5 Oct 2021 13:06:21 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="226024341" X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="226024341" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 04:06:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="589316840" Received: from npg-npf-wlpr-srv02.iind.intel.com ([10.190.213.104]) by orsmga004.jf.intel.com with ESMTP; 05 Oct 2021 04:06:19 -0700 From: Aman Singh To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Tue, 5 Oct 2021 16:27:06 +0530 Message-Id: <20211005105706.31274-1-aman.deep.singh@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ice/base: added union to avoid ptr dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Code changes done to avoid build issue as seen in Bug 817 - net/ice build failure with gcc 4.8.5 error: dereferencing type-punned pointer will break strict-aliasing rules. Signed-off-by: Aman Singh --- drivers/net/ice/base/ice_parser_rt.c | 36 +++++++++++++++------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/net/ice/base/ice_parser_rt.c b/drivers/net/ice/base/ice_parser_rt.c index 7a44675737..bcbc0b5e15 100644 --- a/drivers/net/ice/base/ice_parser_rt.c +++ b/drivers/net/ice/base/ice_parser_rt.c @@ -187,21 +187,23 @@ static u32 _bit_rev_u32(u32 v, int len) static u32 _hv_bit_sel(struct ice_parser_rt *rt, int start, int len) { - u64 d64, msk; - u8 b[8]; + u64 msk; + union { + u64 d64; + u8 b[8]; + } bit_sel; int i; int offset = GPR_HB_IDX + start / 16; - ice_memcpy(b, &rt->gpr[offset], 8, ICE_NONDMA_TO_NONDMA); + ice_memcpy(bit_sel.b, &rt->gpr[offset], 8, ICE_NONDMA_TO_NONDMA); for (i = 0; i < 8; i++) - b[i] = _bit_rev_u8(b[i]); + bit_sel.b[i] = _bit_rev_u8(bit_sel.b[i]); - d64 = *(u64 *)&b[0]; msk = (1ul << len) - 1; - return _bit_rev_u32((u32)((d64 >> (start % 16)) & msk), len); + return _bit_rev_u32((u32)((bit_sel.d64 >> (start % 16)) & msk), len); } static u32 _pk_build(struct ice_parser_rt *rt, struct ice_np_keybuilder *kb) @@ -444,21 +446,23 @@ static void _po_update(struct ice_parser_rt *rt, struct ice_alu *alu) static u16 _reg_bit_sel(struct ice_parser_rt *rt, int reg_idx, int start, int len) { - u32 d32, msk; - u8 b[4]; - u8 v[4]; + u32 msk; + union { + u32 d32; + u8 b[4]; + } bit_sel; - ice_memcpy(b, &rt->gpr[reg_idx + start / 16], 4, ICE_NONDMA_TO_NONDMA); + ice_memcpy(bit_sel.b, &rt->gpr[reg_idx + start / 16], 4, + ICE_NONDMA_TO_NONDMA); - v[0] = _bit_rev_u8(b[0]); - v[1] = _bit_rev_u8(b[1]); - v[2] = _bit_rev_u8(b[2]); - v[3] = _bit_rev_u8(b[3]); + bit_sel.b[0] = _bit_rev_u8(bit_sel.b[0]); + bit_sel.b[1] = _bit_rev_u8(bit_sel.b[1]); + bit_sel.b[2] = _bit_rev_u8(bit_sel.b[2]); + bit_sel.b[3] = _bit_rev_u8(bit_sel.b[3]); - d32 = *(u32 *)&v[0]; msk = (1u << len) - 1; - return _bit_rev_u16((u16)((d32 >> (start % 16)) & msk), len); + return _bit_rev_u16((u16)((bit_sel.d32 >> (start % 16)) & msk), len); } static void _err_add(struct ice_parser_rt *rt, int idx, bool val) -- 2.17.1