From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80F21A0C4C; Tue, 5 Oct 2021 16:18:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70C2C4132D; Tue, 5 Oct 2021 16:18:01 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5821B4132D for ; Tue, 5 Oct 2021 16:17:58 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="206563915" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="206563915" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 06:59:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="488044075" Received: from silpixa00399126.ir.intel.com ([10.237.223.151]) by orsmga008.jf.intel.com with ESMTP; 05 Oct 2021 06:59:16 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Ciara Power , David Marchand , Anatoly Burakov , Kevin Traynor , Bruce Richardson Date: Tue, 5 Oct 2021 14:59:04 +0100 Message-Id: <20211005135909.726091-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210915141030.23514-1-bruce.richardson@intel.com> References: <20210915141030.23514-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 0/5] improve telemetry support with in-memory mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patchset cleans up telemetry support for "in-memory" mode, so that multiple independent processes can be run using that mode and still have telemetry support. It also removes problems of one process removing the socket of another - which was the original issue reported. The main changes in this set are to: * disable telemetry for secondary processes, which prevents any socket conflicts in multi-process cases. * add a suffix to the telemetry sockets of any process run using "in-memory" mode. This suffix is the PID and ensures we don't get path conflicts on the sockets * inform the user of any path conflicts we do encounter for some reason, and present them with the options to solve it, instead of just removing the conflicting socket and continuing. [This was the original patch in V1-V3] * update the telemetry script and documentation to allow it to connect to in-memory DPDK processes. --- V6: fixed issue whereby the failing of the legacy telemetry init would roll-back init of the v2 telemetry, causing the socket to be deleted, even though it was still necessary. V5: Rebase on latest main after other script cleanups were merged V4: Move from simple-fix patch to proper fix patchset V3: Drop CC stable, as will have separate backport patch which does not error out, so avoiding causing problems with currently running application V2: fix build error on FreeBSD Bruce Richardson (5): eal: limit telemetry to primary processes telemetry: fix deletion of active sockets telemetry: use unique socket paths for in-memory mode usertools/dpdk-telemetry: connect to in-memory processes usertools/dpdk-telemetry: provide info on available sockets doc/guides/howto/telemetry.rst | 26 +++++++++++++++++- lib/eal/freebsd/eal.c | 3 +- lib/eal/linux/eal.c | 3 +- lib/telemetry/telemetry.c | 43 +++++++++++++++++++++++------ lib/telemetry/telemetry_internal.h | 3 +- usertools/dpdk-telemetry.py | 44 ++++++++++++++++++++++++++++-- 6 files changed, 106 insertions(+), 16 deletions(-) -- 2.30.2