From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AAA6A0C41; Fri, 8 Oct 2021 08:52:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DCDC4067E; Fri, 8 Oct 2021 08:52:07 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 75A8740040; Fri, 8 Oct 2021 08:52:04 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="312645723" X-IronPort-AV: E=Sophos;i="5.85,356,1624345200"; d="scan'208";a="312645723" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 23:52:03 -0700 X-IronPort-AV: E=Sophos;i="5.85,356,1624345200"; d="scan'208";a="489342889" Received: from unknown (HELO localhost.localdomain) ([10.240.183.65]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 23:52:01 -0700 From: zhihongx.peng@intel.com To: olivier.matz@6wind.com, dmitry.kozliuk@gmail.com Cc: dev@dpdk.org, Zhihong Peng , stable@dpdk.org Date: Fri, 8 Oct 2021 06:41:30 +0000 Message-Id: <20211008064131.369133-1-zhihongx.peng@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210917021502.502560-2-zhihongx.peng@intel.com> References: <20210917021502.502560-2-zhihongx.peng@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Zhihong Peng Malloc cl in the cmdline_stdin_new function, so release in the cmdline_stdin_exit function is logical, so that cl will not be released alone. Fixes: af75078fece3 (first public release) Cc: stable@dpdk.org Signed-off-by: Zhihong Peng --- doc/guides/rel_notes/release_21_11.rst | 5 +++++ lib/cmdline/cmdline_socket.c | 1 + 2 files changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index efeffe37a0..be24925d16 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -191,6 +191,11 @@ API Changes the crypto/security operation. This field will be used to communicate events such as soft expiry with IPsec in lookaside mode. +* cmdline: The API cmdline_stdin_exit has added cmdline_free function. + Malloc cl in the cmdline_stdin_new function, so release in the + cmdline_stdin_exit function is logical. The application code + that calls cmdline_free needs to be deleted. + ABI Changes ----------- diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c index 998e8ade25..ebd5343754 100644 --- a/lib/cmdline/cmdline_socket.c +++ b/lib/cmdline/cmdline_socket.c @@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl) return; terminal_restore(cl); + cmdline_free(cl); } -- 2.25.1