From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 014BCA0C45;
	Sat,  9 Oct 2021 00:57:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E2FDD40142;
	Sat,  9 Oct 2021 00:57:18 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 8CFB040140
 for <dev@dpdk.org>; Sat,  9 Oct 2021 00:57:17 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id E8BA720B8008; Fri,  8 Oct 2021 15:57:16 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E8BA720B8008
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1633733836;
 bh=Ayo+PwAY3zNiwo9nZjG53KEZoHeb9xObBsn/O0GSZew=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=BxKJFVFutQLtpeqlUUWA/D4kdMoNiyWD91CXaUodhYKNDPtbRmkDTk0Ka2NJIz75l
 2wbdb9/9RM4oe999LM9AziTuPbqN5h1MwYJXJSFC2Hzh5tgA4zSPAjAeb8cxQ++9dU
 4EVLV2W5zdwXrDyPznBIIVbXlNoVLs3VjrvmQ1Bg=
Date: Fri, 8 Oct 2021 15:57:16 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Ali Alnubani <alialnu@nvidia.com>,
 Gregory Etelson <getelson@nvidia.com>,
 David Marchand <david.marchand@redhat.com>,
 Olivier Matz <olivier.matz@6wind.com>, Ray Kinsella <mdr@ashroe.eu>
Message-ID: <20211008225716.GB20092@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20211005201545.179902-1-dmitry.kozliuk@gmail.com>
 <20211007221028.314230-1-dmitry.kozliuk@gmail.com>
 <20211007221028.314230-3-dmitry.kozliuk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211007221028.314230-3-dmitry.kozliuk@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v5 2/2] cmdline: make struct rdline opaque
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 08, 2021 at 01:10:28AM +0300, Dmitry Kozlyuk wrote:
> Hide struct rdline definition and some RDLINE_* constants in order
> to be able to change internal buffer sizes transparently to the user.
> Add new functions:
> 
> * rdline_new(): allocate and initialize struct rdline.
>   This function replaces rdline_init() and takes an extra parameter:
>   opaque user data for the callbacks.
> * rdline_free(): deallocate struct rdline.
> * rdline_get_history_buffer_size(): for use in tests.
> * rdline_get_opaque(): to obtain user data in callback functions.
> 
> Remove rdline_init() function from library headers and export list,
> because using it requires the knowledge of sizeof(struct rdline).
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> ---

Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>