From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D442FA0C43; Mon, 11 Oct 2021 01:46:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6207C40142; Mon, 11 Oct 2021 01:46:16 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2068.outbound.protection.outlook.com [40.107.92.68]) by mails.dpdk.org (Postfix) with ESMTP id 08CDD4003C for ; Mon, 11 Oct 2021 01:46:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FzmoUqFmv1qThtDNLcoYqW+JAt1Ji/i2CZ3UFsVlJ4nl1bYw1kj2raKcptn3KlqhGmCnO05DZzVFBtc+CBAifRSZA3cp5HWMqwbsi57uBKlrnhhMoA3jhvWSuFh7n6B6GfaaG6YvKpPw1HnFO1h6wBAaNZfBI+20WAaE+tfljqtAJRzlCaYDJGEOd4DLnETZFPEQj1HrsfgXsluLFWRi05q8bhKu9yMlyaHIX00taMg30y0bTt+CS0Wy+vnDkEBRg2RtZxoSKBYFH85nki4I31CBKBxdVEhzP2VeIWeqCFzaetRY9NBPi4pW+0/DFKxRp0Uj7g9mWcDfKXbuJZReUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4CHScDTYNmTAWi8cLb+TlW0rzLvhX6HbTp0IauZUR/Y=; b=TGt057qTPMZw6W8run/xhBdb3sRH2p5MSkelQjWJ3OtMzT8fGD/WxDls3VpMRQP9mQNL44CmEA358ln7Ov+aRMTXtUxhEu0N8I6jnXD8nw6/jgTSonw3svI7GWdS6Rggj1ORQKz5wS0wQm3Caaveg6qLcmVpwDRJ9CFCnPEr8l1n10eKjP8xniyuQgwWhHbl5rgZeFzNFYc7JVnoENdN/9IXxvQV5gFdAPIZA0mEVsjip7PlRDMWEmGeTvhVb8FYM/svemffUrIrj3pTCXGIupU9WxKQ6NOGraLsi7S+mx6hU+A5JP5MiLX6YYIE33ifznPctd415ks/5PZ8XS6APQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4CHScDTYNmTAWi8cLb+TlW0rzLvhX6HbTp0IauZUR/Y=; b=mqyDErVQydvZAh7zRYwJjOy/SOn4yps4XLrrzDtsW4/VUwZeNq7wZxn7aJHrzyM8vb0tqzoS44ldC3yQdV31SIt3F4PlGol3ZyJhfpEsrJCP0ZOFg39vWBjOsJMGKC1LYFUZtF3yJWAqxtw35/OyeJGOwPPkYOKd9gA6VNZUF3BuoENA8x6LZ9AWLdDjTG4r5bbZrJfL4dKktncF2klaQ6FnUihcZCP7uNXTYjUPr16gCcDOG2GgiXpJLiSgRRNZKLvi/nrQm2FMCtYnVV7wZe89t7LJEZkqxwrHoGqhmjm669NWlx2gAGuriX2gWreg+6a5S8+KEQjQduzHsN8hYQ== Received: from DM5PR21CA0040.namprd21.prod.outlook.com (2603:10b6:3:ed::26) by DM6PR12MB4516.namprd12.prod.outlook.com (2603:10b6:5:2ac::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Sun, 10 Oct 2021 23:46:09 +0000 Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:3:ed:cafe::b5) by DM5PR21CA0040.outlook.office365.com (2603:10b6:3:ed::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.3 via Frontend Transport; Sun, 10 Oct 2021 23:46:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Sun, 10 Oct 2021 23:46:09 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 10 Oct 2021 23:46:06 +0000 From: Viacheslav Ovsiienko To: CC: , , , , , Date: Mon, 11 Oct 2021 02:45:42 +0300 Message-ID: <20211010234547.1495-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210910141609.8410-1-viacheslavo@nvidia.com> References: <20210910141609.8410-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8316817e-8cdd-43da-8591-08d98c482256 X-MS-TrafficTypeDiagnostic: DM6PR12MB4516: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6R8+qznaDE07vf9OL7ZmsssF/algV8baXsExwpCRmAxcKk+gBoa9Josy99qItPaik9wAaI5n3hSD7yZ2XO9JgJlX6V5KeP4iGI6xwPn1YRKld827u+OQgaO9qbgqxrg+NTav97oP+ZpPbuOLmNRgwA0IpoNNt6fBXbTQKI7aVW2Bw2vpcd8csstuUd/QAyhkDo3KDD0E/TEfhCfOQi+hquh69doHAXPOd2rnyfY16X/JK/kneVOdsxxoWGD1pjzOI0ZdDCvAOc+gC+AlUeW22e3VJJeEaMvpB+HcjV8MjR4oIuJ2EeuECVrycFkKX0C+6QGQ1sNFrwa0gT+zHzBzN82R4RIXKsVon/F36lgnXtJgcfKSi7+YLmvFt1kLsai+UM2CAp2I/mrSrfn0swSGlQs9PeJVwhbY/GRoqtLs2FNW7W23FZkZ8nGhhJOdKow+sqe9yYjWigtt+HjiNXfbv8dffaW3e+xIO9eWDQiaz8gTOj0qmiC1TnbnaexdyDnOg1xRehD597/R2NZh6pBQCbqrBLy4TZneSmbxH/Kg/8v/6l2E8/NieA4iYhv7hXe5fZKlpTuGzre09mAjwubiQaOoesVVnpNvgxgJPSuKljX2vq+1ViNVvrrdQKXmH+VGX2hC443ei6xMpSZqaLsUGmgoX2+asKdFGZ+LqMtQbccfgeyAuyhoyowqXq+4qaoD/p/UCb8FY7WcZsCO+EHoc68cAEqBkN7lRcmIK4RiAMESAS5zPAT+J9a2FbdGMZRGW3bt4vXEPe6O6+UgzK7vJDldgPNZyk0+Jf6PLhIHsCCOrsro2XCOPS7QJ1oHn0xzJKpKfVW1dEgPfx7k+PI9WQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(36906005)(2616005)(316002)(336012)(4326008)(426003)(7636003)(7696005)(36860700001)(356005)(26005)(54906003)(2906002)(16526019)(186003)(15650500001)(6666004)(70586007)(70206006)(6286002)(6916009)(8936002)(47076005)(86362001)(966005)(55016002)(5660300002)(8676002)(508600001)(82310400003)(83380400001)(1076003)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2021 23:46:09.0166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8316817e-8cdd-43da-8591-08d98c482256 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4516 Subject: [dpdk-dev] [PATCH v2 0/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the byte ordering for 64-bit integer was not specified. Many fields have lesser lengths and byte ordering is crucial. - how the bit offset is applied to the immediate source field was not defined and documented - 64-bit integer size is not enough to provide MAC and IPv6 addresses In order to cover the issues and exclude any ambiguities the following is done: - introduce the explicit pointer field in rte_flow_action_modify_data structure - replace the 64-bit unsigned integer with 16-byte array - update the modify field flow action documentation [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ [4] v1 - http://patches.dpdk.org/project/dpdk/cover/20211001195223.31909-1-viacheslavo@nvidia.com/ v2: - comments addressed - documentation updated - typos fixed - mlx5 PMD updated Signed-off-by: Viacheslav Ovsiienko Viacheslav Ovsiienko (5): ethdev: update modify field flow action app/testpmd: update modify field flow action support app/testpmd: fix hex string parser in flow commands net/mlx5: update modify field action doc: remove modify field action data deprecation notice app/test-pmd/cmdline_flow.c | 60 ++++++++++++++++++-------- doc/guides/prog_guide/rte_flow.rst | 16 +++++++ doc/guides/rel_notes/deprecation.rst | 4 -- doc/guides/rel_notes/release_21_11.rst | 9 ++++ drivers/net/mlx5/mlx5_flow_dv.c | 50 ++++++++++++--------- lib/ethdev/rte_flow.h | 17 ++++++-- 6 files changed, 110 insertions(+), 46 deletions(-) -- 2.18.1