From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCB99A034F; Mon, 11 Oct 2021 10:26:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C225A40E01; Mon, 11 Oct 2021 10:26:58 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 893BD40142; Mon, 11 Oct 2021 10:26:57 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id j21so52601465lfe.0; Mon, 11 Oct 2021 01:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GAtfs6twDRvj9NPhWbCg1eIIeBQlXXH9XPoBIBehlUg=; b=bYEUu/LdB7ttP7Pmu68a1wp0XCwOVud2waECUKdgeDAbZn/GUpx8yIdxLfFe5ssJoE sYR5rFKIQu99uPg2c0UtUAxY9VFEWQ+xNocDTfY/KTb2r96h1gbAT3lHokOFlxO1ZPeJ 85C3Z8k4PK8NTvLCtADd3b1MLzWN8xoCQe+JuzabsoITvTc9nrv+q/Tr6fDzA+s2aZ6n FvqxLQuvgY34R9I/35PFsCL5hJa90xFHzEDZIHlpHi1aiPwpC0GNQ5DpmfGuRTchY82t vwCG2yVrwQsFEDzgADMhxqw+zMAQeRKfCVOmrZ9hSJ6EU8XpVf/3bd1FHak3HBh3Dsn5 r9pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GAtfs6twDRvj9NPhWbCg1eIIeBQlXXH9XPoBIBehlUg=; b=0pd90hSK9BqmqoSQuhUEvB4U/6WTsWUNC8a7yx3J1b4tVUiFIa7ihLJR6q/gpSxZdD WmArfOWkGL7/qhou+r5b6SgoBN4opgKBNmf9icfYtdOSzn7sJANJet7gsXLvB/LMaQy2 5wmZ976CMwOmE764/88wb9RZnVUMRkd+zj2p4FYngQWAPfoz+7iryJtWBdqgTkY6o5bY wUC0FrFBdTLkpiCAM4LNtofZ0pVitUZHhs4XyAqgx7g9hJrrHpVlCmqY3VJ8vW4qIzuF UG81YPa7dzJMrpgkTZNMvNvbBXRlbGeiJaJrPs/EAvq+xJbpQeDgqHOhIfmffSLXgKdb nyWQ== X-Gm-Message-State: AOAM532HVcuF3jrWVUYsfHPHOAI0haCQxcwvSlr2uXNHxbiku7CmIcQR ueew7Nw+DWmwnspcAQHT7OWxm6KKlLQ= X-Google-Smtp-Source: ABdhPJws3F5mJrrNIcA1s9pJ3z0yok/UJSShnCm6grm1PfsG3XkDTxMnLML9Y/Sfz+IxmhuhxvixYg== X-Received: by 2002:a05:651c:b28:: with SMTP id b40mr21923210ljr.334.1633940817029; Mon, 11 Oct 2021 01:26:57 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id k16sm667540lfo.219.2021.10.11.01.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 01:26:56 -0700 (PDT) Date: Mon, 11 Oct 2021 11:26:56 +0300 From: Dmitry Kozlyuk To: zhihongx.peng@intel.com Cc: olivier.matz@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20211011112656.7ee67893@sovereign> In-Reply-To: <20211008064131.369133-2-zhihongx.peng@intel.com> References: <20210917021502.502560-2-zhihongx.peng@intel.com> <20211008064131.369133-1-zhihongx.peng@intel.com> <20211008064131.369133-2-zhihongx.peng@intel.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/test: delete cmdline free function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-10-08 06:41 (UTC+0000), zhihongx.peng@intel.com: > From: Zhihong Peng > > Cmdline will be released in cmdline_stdin_exit function, > so it does not need to be released here. > > Fixes: acdabc450ea0 (test: fix terminal settings on exit) > Cc: stable@dpdk.org > > Signed-off-by: Zhihong Peng Except for backporting (see patch 1/2 comments), Acked-by: Dmitry Kozlyuk > --- > app/test/test.c | 1 - > app/test/test_cmdline_lib.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/app/test/test.c b/app/test/test.c > index 173d202e47..5194131026 100644 > --- a/app/test/test.c > +++ b/app/test/test.c > @@ -233,7 +233,6 @@ main(int argc, char **argv) > > cmdline_interact(cl); > cmdline_stdin_exit(cl); > - cmdline_free(cl); > } > #endif > ret = 0; > diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c > index d5a09b4541..6bcfa6511e 100644 > --- a/app/test/test_cmdline_lib.c > +++ b/app/test/test_cmdline_lib.c > @@ -174,7 +174,6 @@ test_cmdline_socket_fns(void) > /* void functions */ > cmdline_stdin_exit(NULL); > > - cmdline_free(cl); > return 0; > error: > printf("Error: function accepted null parameter!\n");