[dpdk-dev] [PATCH] net/ice/base: fix parser runtime reset logic

[dpdk-dev] [PATCH] net/ice/base: fix parser runtime reset logic

[Junfeng Guo]

Adjust the codeline order of the parser runtime reset, since the
struct rt->psr is used in function _rt_flag_set before assignment.

Fixes: c84f8aa2100c ("net/ice/base: add parser runtime skeleton")

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
Cc: stable@dpdk.org
---
 drivers/net/ice/base/ice_parser_rt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ice/base/ice_parser_rt.c b/drivers/net/ice/base/ice_parser_rt.c
index eb35ad0bc0..22cd748248 100644
--- a/drivers/net/ice/base/ice_parser_rt.c
+++ b/drivers/net/ice/base/ice_parser_rt.c
@@ -87,12 +87,12 @@ void ice_parser_rt_reset(struct ice_parser_rt *rt)
 	_rt_np_set(rt, mi->pc);
 	_rt_nn_set(rt, mi->pg_rn);
 
+	rt->psr = psr;
+
 	for (i = 0; i < 64; i++) {
 		if ((mi->flags & (1ul << i)) != 0ul)
 			_rt_flag_set(rt, i, true);
 	}
-
-	rt->psr = psr;
 }
 
 /**
-- 
2.25.1

Re: [dpdk-dev] [PATCH] net/ice/base: fix parser runtime reset logic

[Zhang, Qi Z]

> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@intel.com>
> Sent: Monday, October 11, 2021 9:30 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> Guo, Junfeng <junfeng.guo@intel.com>
> Subject: [PATCH] net/ice/base: fix parser runtime reset logic
> 
> Adjust the codeline order of the parser runtime reset, since the struct rt->psr is
> used in function _rt_flag_set before assignment.
> 
> Fixes: c84f8aa2100c ("net/ice/base: add parser runtime skeleton")
> 
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi