DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs
@ 2021-10-11 18:49 William Tu
  2021-10-12  1:54 ` Dmitry Kozlyuk
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: William Tu @ 2021-10-11 18:49 UTC (permalink / raw)
  To: dev; +Cc: pallavi.kadam, Dmitry.Kozliuk, ranjit.menon

Add Intel Ethernet e1000 device IDs to netuio inf file.

Signed-off-by: William Tu <u9012063@gmail.com>
--
DPDK patch at:
http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012063@gmail.com/T/#t
---
 windows/netuio/netuio.inf | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 816ff17c7936..28cd0be9de81 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -29,6 +29,7 @@ HKR,,Icon,,-5
 [Standard.NT$ARCH$]
 %netuio.DeviceDesc%=netuio_Device, Root\netuio
 %netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
+%Intel.F1521.Description%=netuio_Device, PCI\VEN_8086&DEV_1521
 %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
 %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
 %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
@@ -43,6 +44,7 @@ HKR,,Icon,,-5
 %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
 %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
 %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
+%Intel.F10D3.Description%=netuio_Device, PCI\VEN_8086&DEV_10D3
 %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
 %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
 %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
@@ -100,6 +102,7 @@ ClassName = "Windows UIO"
 DiskName = "DPDK netUIO Installation Disk"
 netuio.DeviceDesc = "netuio Device"
 netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
+Intel.F1521.Description = "Intel(R) I350 Gigabit Network Connection"
 Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
 Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
 Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"
@@ -114,6 +117,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
 Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
 Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
 Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
+Intel.F10D3.Description = "Intel(R) 82574L Gigabit Ethernet Controller"
 Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
 Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
 Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"
-- 
2.33.0.windows.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs
  2021-10-11 18:49 [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs William Tu
@ 2021-10-12  1:54 ` Dmitry Kozlyuk
  2021-10-12  3:31 ` Kadam, Pallavi
  2021-10-19 19:01 ` [dpdk-dev] [kmods PATCH v2] windows/netuio: add Intel device ID William Tu
  2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Kozlyuk @ 2021-10-12  1:54 UTC (permalink / raw)
  To: William Tu; +Cc: dev, pallavi.kadam, ranjit.menon

2021-10-11 11:49 (UTC-0700), William Tu:
> Add Intel Ethernet e1000 device IDs to netuio inf file.
> 
> Signed-off-by: William Tu <u9012063@gmail.com>

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs
  2021-10-11 18:49 [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs William Tu
  2021-10-12  1:54 ` Dmitry Kozlyuk
@ 2021-10-12  3:31 ` Kadam, Pallavi
  2021-10-19 19:01 ` [dpdk-dev] [kmods PATCH v2] windows/netuio: add Intel device ID William Tu
  2 siblings, 0 replies; 5+ messages in thread
From: Kadam, Pallavi @ 2021-10-12  3:31 UTC (permalink / raw)
  To: William Tu, dev; +Cc: Dmitry.Kozliuk, ranjit.menon

Hi William,

On 10/11/2021 11:49 AM, William Tu wrote:
> Add Intel Ethernet e1000 device IDs to netuio inf file.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> --
> DPDK patch at:
> http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012063@gmail.com/T/#t
> ---
>   windows/netuio/netuio.inf | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index 816ff17c7936..28cd0be9de81 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -29,6 +29,7 @@ HKR,,Icon,,-5
>   [Standard.NT$ARCH$]
>   %netuio.DeviceDesc%=netuio_Device, Root\netuio
>   %netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
> +%Intel.F1521.Description%=netuio_Device, PCI\VEN_8086&DEV_1521
>   %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
>   %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
>   %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
> @@ -43,6 +44,7 @@ HKR,,Icon,,-5
>   %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
>   %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
>   %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> +%Intel.F10D3.Description%=netuio_Device, PCI\VEN_8086&DEV_10D3
>   %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
>   %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
>   %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
> @@ -100,6 +102,7 @@ ClassName = "Windows UIO"
>   DiskName = "DPDK netUIO Installation Disk"
>   netuio.DeviceDesc = "netuio Device"
>   netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
> +Intel.F1521.Description = "Intel(R) I350 Gigabit Network Connection"
>   Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
>   Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
>   Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"
> @@ -114,6 +117,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
>   Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
>   Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
>   Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
> +Intel.F10D3.Description = "Intel(R) 82574L Gigabit Ethernet Controller"

As per NDIS inf, the string should be as below:

Intel (R) 82574L Gigabit Network Connection

Thanks,

Pallavi

>   Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
>   Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
>   Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [kmods PATCH v2] windows/netuio: add Intel device ID
  2021-10-11 18:49 [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs William Tu
  2021-10-12  1:54 ` Dmitry Kozlyuk
  2021-10-12  3:31 ` Kadam, Pallavi
@ 2021-10-19 19:01 ` William Tu
  2021-11-24 16:11   ` William Tu
  2 siblings, 1 reply; 5+ messages in thread
From: William Tu @ 2021-10-19 19:01 UTC (permalink / raw)
  To: dev; +Cc: Dmitry Kozlyuk, Pallavi Kadam

The patch adds three Intel device IDs,
I350 (0x1521), 82574L (0x10D3), and 82599 (0x10ED).

Signed-off-by: William Tu <u9012063@gmail.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
---
v2:
* fix the device string suggested by Pallavi
* combine this patch with the 82599 ixgbevf

---
 windows/netuio/netuio.inf | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 816ff17c7936..99dd53c6953f 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -29,6 +29,7 @@ HKR,,Icon,,-5
 [Standard.NT$ARCH$]
 %netuio.DeviceDesc%=netuio_Device, Root\netuio
 %netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
+%Intel.F1521.Description%=netuio_Device, PCI\VEN_8086&DEV_1521
 %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
 %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
 %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
@@ -43,6 +44,8 @@ HKR,,Icon,,-5
 %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
 %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
 %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
+%Intel.F10D3.Description%=netuio_Device, PCI\VEN_8086&DEV_10D3
+%Intel.F10ED.Description%=netuio_Device, PCI\VEN_8086&DEV_10ED
 %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
 %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
 %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
@@ -100,6 +103,7 @@ ClassName = "Windows UIO"
 DiskName = "DPDK netUIO Installation Disk"
 netuio.DeviceDesc = "netuio Device"
 netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
+Intel.F1521.Description = "Intel(R) I350 Gigabit Network Connection"
 Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
 Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
 Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"
@@ -114,6 +118,8 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
 Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
 Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
 Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
+Intel.F10D3.Description = "Intel(R) 82574L Gigabit Network Connection"
+Intel.F10ED.Description = "Intel(R) 82599 Virtual Function"
 Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
 Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
 Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"
-- 
2.33.0.windows.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [kmods PATCH v2] windows/netuio: add Intel device ID
  2021-10-19 19:01 ` [dpdk-dev] [kmods PATCH v2] windows/netuio: add Intel device ID William Tu
@ 2021-11-24 16:11   ` William Tu
  0 siblings, 0 replies; 5+ messages in thread
From: William Tu @ 2021-11-24 16:11 UTC (permalink / raw)
  To: dpdk-dev; +Cc: Dmitry Kozlyuk, Pallavi Kadam

Hi,
Can we merge this patch? Thank you!
William

On Tue, Oct 19, 2021 at 12:02 PM William Tu <u9012063@gmail.com> wrote:
>
> The patch adds three Intel device IDs,
> I350 (0x1521), 82574L (0x10D3), and 82599 (0x10ED).
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
> ---
> v2:
> * fix the device string suggested by Pallavi
> * combine this patch with the 82599 ixgbevf
>
> ---
>  windows/netuio/netuio.inf | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index 816ff17c7936..99dd53c6953f 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -29,6 +29,7 @@ HKR,,Icon,,-5
>  [Standard.NT$ARCH$]
>  %netuio.DeviceDesc%=netuio_Device, Root\netuio
>  %netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
> +%Intel.F1521.Description%=netuio_Device, PCI\VEN_8086&DEV_1521
>  %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
>  %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
>  %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
> @@ -43,6 +44,8 @@ HKR,,Icon,,-5
>  %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
>  %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
>  %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> +%Intel.F10D3.Description%=netuio_Device, PCI\VEN_8086&DEV_10D3
> +%Intel.F10ED.Description%=netuio_Device, PCI\VEN_8086&DEV_10ED
>  %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
>  %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
>  %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
> @@ -100,6 +103,7 @@ ClassName = "Windows UIO"
>  DiskName = "DPDK netUIO Installation Disk"
>  netuio.DeviceDesc = "netuio Device"
>  netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
> +Intel.F1521.Description = "Intel(R) I350 Gigabit Network Connection"
>  Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
>  Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
>  Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"
> @@ -114,6 +118,8 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
>  Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
>  Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
>  Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
> +Intel.F10D3.Description = "Intel(R) 82574L Gigabit Network Connection"
> +Intel.F10ED.Description = "Intel(R) 82599 Virtual Function"
>  Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
>  Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
>  Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"
> --
> 2.33.0.windows.2
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-24 16:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 18:49 [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs William Tu
2021-10-12  1:54 ` Dmitry Kozlyuk
2021-10-12  3:31 ` Kadam, Pallavi
2021-10-19 19:01 ` [dpdk-dev] [kmods PATCH v2] windows/netuio: add Intel device ID William Tu
2021-11-24 16:11   ` William Tu

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git