DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, Shahaji Bhosle <sbhosle@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings
Date: Mon, 11 Oct 2021 19:46:26 -0700	[thread overview]
Message-ID: <20211011194626.34709481@hermes.local> (raw)
In-Reply-To: <20211010040755.3882-1-ajit.khaparde@broadcom.com>

On Sat,  9 Oct 2021 21:07:55 -0700
Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:

> +		if ((uint32_t)item->type >=
> +		    (uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_END) {


This doesn't look right, you are casting away your troubles, not addressing
the root cause.

item->type is type rte_flow_item_type
BNXT_FLOW_ITEM_TYPE_END is the first item in that enum.

So yes the warning is valid and the code is wrong.

  parent reply	other threads:[~2021-10-12  2:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10  4:07 Ajit Khaparde
2021-10-11 17:55 ` Ajit Khaparde
2021-10-12  2:46 ` Stephen Hemminger [this message]
2021-10-12  4:08   ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011194626.34709481@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=sbhosle@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).