From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDAEAA034F; Tue, 12 Oct 2021 04:46:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81887410E0; Tue, 12 Oct 2021 04:46:31 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 6FECC410DC for ; Tue, 12 Oct 2021 04:46:30 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id oa4so13904313pjb.2 for ; Mon, 11 Oct 2021 19:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HLMJIhqGkk3nrX7HZ7kPDBL42c77KgPj8BidyvzxGZ4=; b=0ihkst0DOKtZ15y1z0/KH4O2ChNRc0hiHCAzRORkLu6tYVLsNcd5ZykvRgpB1XTxDx tQR8qbvKjQaXOS4F1ffJkv8ag1Xm+EKgLJFHTFnl7Ij0+2/4T7rmes887aA304vhJGWp vM6EEduODUDnQaHDrpDlfR5QgU8Jp3y0vRJOAUK5W8EaXt2mjfw01/vTKb+y/U3zMujk BRbX2pTD8OJN0GhpRaOvxdsEonQTvcAH0CxEIrX+KdwPOxlBm4YU52DSGBtuZgKQQ94J 0y0doIMeys14aMza21zVtEx/9ueIHmV+AKrcuMArTEnyutLSbAS17S/lJg1hK5DJXq9T YIlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HLMJIhqGkk3nrX7HZ7kPDBL42c77KgPj8BidyvzxGZ4=; b=Y2NQkD+jrDuCvnLgCFTdNvF5i7wQgRyaQHdaFKaUVLnf2lWnjBwuMsvch6EpIZCVjK ihNRYW/mv/v0YPcLbTXUl9Odx8fkKAjlXoerE1gqQt2T0XKV0kMyk7axLgzY1PQX66bO cfQzUafHUYdwwB80ekU5L4C6n5u1+CMQ/CnTtHerCT5DH6w4SoS4qI150EI6pgKA67r3 tLbCEPYlMnW4Ch4jnIB+7Xx9ek8yA1fA+CRLnXBc3jBOBXsOgOt6Zck/Y7h/MQWoD5mS 8TlCMMIhCk0/HpV4sbGmWEO558u7gNu7UMkGaKqArbC57ZrHgQHa3u06tQdKlryeM38g R/xQ== X-Gm-Message-State: AOAM533/Gljfd/UXGGThRSKloPAaPrXj+DS/UXtZ0DGTKqaQ4vRbWzma BFaMZbuQT1K7rP48tBRq+tU1DA== X-Google-Smtp-Source: ABdhPJwpF5S6LtjvhwRwnhP8s9jWJPbzGHQ+2ji+6uG3yut1qdSF6tUn5uDMZpbUpPxGHCfM48x4yg== X-Received: by 2002:a17:90b:1101:: with SMTP id gi1mr3039116pjb.11.1634006789477; Mon, 11 Oct 2021 19:46:29 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id g19sm756886pjl.25.2021.10.11.19.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 19:46:29 -0700 (PDT) Date: Mon, 11 Oct 2021 19:46:26 -0700 From: Stephen Hemminger To: Ajit Khaparde Cc: dev@dpdk.org, Shahaji Bhosle Message-ID: <20211011194626.34709481@hermes.local> In-Reply-To: <20211010040755.3882-1-ajit.khaparde@broadcom.com> References: <20211010040755.3882-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 9 Oct 2021 21:07:55 -0700 Ajit Khaparde wrote: > + if ((uint32_t)item->type >= > + (uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_END) { This doesn't look right, you are casting away your troubles, not addressing the root cause. item->type is type rte_flow_item_type BNXT_FLOW_ITEM_TYPE_END is the first item in that enum. So yes the warning is valid and the code is wrong.