From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C91DBA0C47; Tue, 12 Oct 2021 12:49:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F3B541147; Tue, 12 Oct 2021 12:49:42 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2075.outbound.protection.outlook.com [40.107.236.75]) by mails.dpdk.org (Postfix) with ESMTP id E069041143 for ; Tue, 12 Oct 2021 12:49:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+K83wdFH+8AIUgMJGBgMc/vBy4O/VPhgE20Ua2b70c/ub7jCoTDtvAUSqryiqMi+XR+XaYbuYPTcuO06wiDxMqbo/QlXJoXLXO+Ojkk5m92T1xJdtFZHZ7kmS4SvUMkQ3Ml7l6jV40zoGWkZA6dWx/zE24H/uch5RImpKUlEfUBgrrd/sDONPniptAMlnEEQ+RswBl3VgW8Wd5JRkGcPVWHvuB3QEYNJ5y3U9sMVv4Y7Qt7SmFVkUvTZJYuGAz34q+HuBGkc6TSLpeSP+ZBrimd4EAm/3NXzp2at/RHaZ6aLSh+NAViKV7vIRPUYPfTNbSR32ZJfUTnEAUsSEr/UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VkxsIto1/z4I27rdXMAb0rUVpaTULiL1OYmGkLw+V/Q=; b=dQU+Fm3KbhbvWS180bPzi6SpenEBX/5i+EeUtZKoxUerejrv49vk7cX/fFsUJxh9+2lDttAzGkkrp18vNB9rzI1nOz+KRbJ01g/uEVF/tF/Vwe5DQIN6cGty+JuKFo/FqyFade+wKk+ZJ8eto7qppznS1ZKf55IjoJuvQHzSRgYTTUCm7Wu+KYvI1YNK78wXF48dixkdn76o/r3Sc+jd3hI/T/FtIbOESh7GTyMDVaiERPT7qIAWaF07wXKMnfJutFerLr6NYwOqH3OfxjkAOOE7hZLf6XM/U48ZfKNOWQECwrpgjxNSJsmVGv6W2A9BgiTrJ3opJDahBuezbSe38Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VkxsIto1/z4I27rdXMAb0rUVpaTULiL1OYmGkLw+V/Q=; b=YLOyMCjMiM1vV7g/0+Iv8hmNh3NcHADQYEoDs8CcJrtWBSJXLFdLnM4e+bpir9FznECdJvJZUOUHkOJdJrtmw5Oajodlf0YTnEubx6fAQyXrmu2pa2hOVO2B+gHHBcVuJqFZAIS14WyJ1AylsDH/xMK570PBXjO1D1ZuPcXPQK5SulS548RzOQ74/h3sN4YToMhVd8yDyA2OMnsjnVMGdgS2cGLJsofpkljjYVa5AEMKdbBNov64Sq+U5CVc6XEkP9wS/uoH/iyK644nK6L/zlJOMnhO9s4MplLSNlx309JbjE1LqvVBxQeTXIhj1mdVG2ZJElRjEpc5k1QWk3AgOA== Received: from BN6PR1101CA0009.namprd11.prod.outlook.com (2603:10b6:405:4a::19) by SN6PR12MB2685.namprd12.prod.outlook.com (2603:10b6:805:67::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Tue, 12 Oct 2021 10:49:39 +0000 Received: from BN8NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:405:4a:cafe::6e) by BN6PR1101CA0009.outlook.office365.com (2603:10b6:405:4a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Tue, 12 Oct 2021 10:49:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT065.mail.protection.outlook.com (10.13.177.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.23 via Frontend Transport; Tue, 12 Oct 2021 10:49:38 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 10:49:36 +0000 From: Viacheslav Ovsiienko To: CC: , , , , , Date: Tue, 12 Oct 2021 13:49:14 +0300 Message-ID: <20211012104919.13145-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210922180418.20663-1-viacheslavo@nvidia.com> References: <20210922180418.20663-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a30f3440-8c88-4cec-a617-08d98d6dfd43 X-MS-TrafficTypeDiagnostic: SN6PR12MB2685: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lv8icTftnWK5XcWaR12YI7ZTQsVt7E8CvohHR6s5XiuK9PHcxwI0/qiZcTfTqmeVj7TriH+91HxzjTxXYgz43y079kKc4Cz8JtCdho9pT6fu95ZTzo5upniLxrv4izBQcdzQSy4jiADKDS0qyrvIPGwVeI4rCfY/fI9u/d9GpQ7yVbWm8nlQ72WNDnJuZpw0VFuMMcX9pFITgdWMijyN4+z7I/A7Yfczgyq38t9z/R6LQ4IV83kTgKeWYl6Tevc5pd3OxdGKVtJRzE8H/GWPiU1T23V1FYLBnYzYiWqaVRJCQLf6Al3Npabt92t72botwD4VY20z6PvanuUMOjVK/g6QRu+OI+oGWRkUbGHHTQzzY91F+v/ZrdcfNgobdsKiCDcKoCzR5sgxrnYe4Qktc3pGWNzKI4hTt/nq9uhUFxUtQvOn/Phf/sSjvjBy8fJoocfnz7s5KNNY3BmDdzH6psUc/QhOxoA8S+aNwYTHdaJoRtY3jhT3i1RfAL3gLB9DwAzii+yCrTWlHjJFbmtGMPxcQWWDFgmRpPYOWB6yAjRX51Oi52G02xlxZvWWFcqmUvnLZ1OZb49SXdpzLjUlQglaODVuvpnKjIIr8fpr6Q5gB1uOV8Qb49wr/hF2wMAYnS9hI0NQYUOPkAUereUbabvnqfdjOacXYczNyi7zH7MJ26oI611JzeCPXH1dbSs1o4r9E7WkQcWh7LXN9vraWPi4fXb/ilzRHie8cMAUA5K+sZ4W2nBLZSq3mcQO7+Jtmp5F4dVwsLt8WMbs4o3DrrFSxqKnp1CEz4Vpj43U8yn/q7h8M5ViYAC+63iU0boefGDZMbs2FY5KUUVHTnsUEQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(2906002)(26005)(86362001)(508600001)(356005)(1076003)(966005)(70206006)(316002)(70586007)(2616005)(5660300002)(36860700001)(54906003)(47076005)(36756003)(426003)(6286002)(186003)(16526019)(336012)(4326008)(82310400003)(6666004)(55016002)(8936002)(6916009)(8676002)(15650500001)(7636003)(83380400001)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 10:49:38.7977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a30f3440-8c88-4cec-a617-08d98d6dfd43 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2685 Subject: [dpdk-dev] [PATCH v4 0/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the byte ordering for 64-bit integer was not specified. Many fields have lesser lengths and byte ordering is crucial. - how the bit offset is applied to the immediate source field was not defined and documented - 64-bit integer size is not enough to provide MAC and IPv6 addresses In order to cover the issues and exclude any ambiguities the following is done: - introduce the explicit pointer field in rte_flow_action_modify_data structure - replace the 64-bit unsigned integer with 16-byte array - update the modify field flow action documentation Appropriate commit message has been removed. [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ [4] v1 - http://patches.dpdk.org/project/dpdk/cover/20211001195223.31909-1-viacheslavo@nvidia.com/ [5] v2 - http://patches.dpdk.org/project/dpdk/patch/20211010234547.1495-2-viacheslavo@nvidia.com/ [6] v3 - http://patches.dpdk.org/project/dpdk/cover/20211012080631.28504-1-viacheslavo@nvidia.com/ v2: - comments addressed - documentation updated - typos fixed - mlx5 PMD updated v3: - comments addressed - documentation updated - typos fixed v4: - removed errorneously added Ack by Ori K. for mlx5 patch - mlx5 patch updated - bug fixes and cleanup Viacheslav Ovsiienko (5): ethdev: update modify field flow action ethdev: fix missed experimental tag for modify field action app/testpmd: update modify field flow action support app/testpmd: fix hex string parser in flow commands net/mlx5: update modify field action app/test-pmd/cmdline_flow.c | 60 ++++++++---- doc/guides/prog_guide/rte_flow.rst | 24 ++++- doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_21_11.rst | 7 ++ drivers/net/mlx5/mlx5_flow_dv.c | 123 +++++++++---------------- lib/ethdev/rte_flow.h | 19 +++- 6 files changed, 129 insertions(+), 108 deletions(-) -- 2.18.1