From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A312AA0C47; Tue, 12 Oct 2021 14:58:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D6D34111E; Tue, 12 Oct 2021 14:58:19 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 5EFD640E0F for ; Tue, 12 Oct 2021 14:58:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10134"; a="207246949" X-IronPort-AV: E=Sophos;i="5.85,367,1624345200"; d="scan'208";a="207246949" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 05:56:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,367,1624345200"; d="scan'208";a="490954408" Received: from silpixa00401012.ir.intel.com ([10.243.22.70]) by orsmga008.jf.intel.com with ESMTP; 12 Oct 2021 05:56:19 -0700 From: Przemyslaw Zegan To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Przemyslaw Zegan , pablo.de.lara.guarch@intel.com Date: Tue, 12 Oct 2021 12:56:11 +0000 Message-Id: <20211012125611.2774670-1-przemyslawx.zegan@intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211011080452.2710095-1-przemyslawx.zegan@intel.com> References: <20211011080452.2710095-1-przemyslawx.zegan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [dpdk-dev v4] app: fix buffer overrun X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes a possible buffer overrun problem in crypto perf test. Previously when user configured aad size is over 12 bytes the copy of template aad will cause a buffer overrun. The problem is fixed by only copy up to 12 bytes of aad template. Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters") Cc: pablo.de.lara.guarch@intel.com Signed-off-by: Przemyslaw Zegan Acked-by: Fan Zhang --- v4: - rebased on top of latest master v3: - replaced hardcoded values by sizeof(aad) v2: - changed to correct fixed line. app/test-crypto-perf/cperf_test_vectors.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-crypto-perf/cperf_test_vectors.c index 4bba405961..314e2b7710 100644 --- a/app/test-crypto-perf/cperf_test_vectors.c +++ b/app/test-crypto-perf/cperf_test_vectors.c @@ -590,6 +590,10 @@ cperf_test_vector_get_dummy(struct cperf_options *options) rte_free(t_vec); return NULL; } + + if(options->aead_aad_sz > sizeof(aad)) + options->aead_aad_sz = sizeof(aad); + memcpy(t_vec->aad.data, aad, options->aead_aad_sz); t_vec->aad.phys_addr = rte_malloc_virt2iova(t_vec->aad.data); t_vec->aad.length = options->aead_aad_sz; -- 2.30.2