DPDK patches and discussions
 help / color / mirror / Atom feed
From: zhihongx.peng@intel.com
To: olivier.matz@6wind.com, dmitry.kozliuk@gmail.com
Cc: dev@dpdk.org, Zhihong Peng <zhihongx.peng@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v4 2/2] app/test: delete cmdline free function
Date: Wed, 13 Oct 2021 01:52:23 +0000	[thread overview]
Message-ID: <20211013015223.1155876-2-zhihongx.peng@intel.com> (raw)
In-Reply-To: <20211013015223.1155876-1-zhihongx.peng@intel.com>

From: Zhihong Peng <zhihongx.peng@intel.com>

Cmdline will be released in cmdline_stdin_exit function,
so it does not need to be released here.

Fixes: acdabc450ea0 ("test: fix terminal settings on exit")
Cc: stable@dpdk.org

Signed-off-by: Zhihong Peng <zhihongx.peng@intel.com>
---
 app/test/test.c             | 1 -
 app/test/test_cmdline_lib.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/app/test/test.c b/app/test/test.c
index 173d202e47..5194131026 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -233,7 +233,6 @@ main(int argc, char **argv)
 
 		cmdline_interact(cl);
 		cmdline_stdin_exit(cl);
-		cmdline_free(cl);
 	}
 #endif
 	ret = 0;
diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c
index d5a09b4541..6bcfa6511e 100644
--- a/app/test/test_cmdline_lib.c
+++ b/app/test/test_cmdline_lib.c
@@ -174,7 +174,6 @@ test_cmdline_socket_fns(void)
 	/* void functions */
 	cmdline_stdin_exit(NULL);
 
-	cmdline_free(cl);
 	return 0;
 error:
 	printf("Error: function accepted null parameter!\n");
-- 
2.25.1


  reply	other threads:[~2021-10-13  2:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  2:28 [dpdk-dev] [PATCH] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-08-31 16:59 ` Stephen Hemminger
2021-09-06  5:45   ` Peng, ZhihongX
2021-08-31 17:52 ` Dmitry Kozlyuk
2021-09-06  5:51   ` Peng, ZhihongX
2021-09-06  7:33     ` Dmitry Kozlyuk
2021-09-30  6:53       ` Peng, ZhihongX
2021-09-30  7:44         ` Dmitry Kozlyuk
2021-10-08  6:55           ` Peng, ZhihongX
2021-09-17  2:15 ` [dpdk-dev] [PATCH v2 1/2] " zhihongx.peng
2021-09-17  2:15   ` [dpdk-dev] [PATCH v2 2/2] app/test: Delete cmdline free function zhihongx.peng
2021-10-08  6:41     ` [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit zhihongx.peng
2021-10-08  6:41       ` [dpdk-dev] [PATCH v3 2/2] app/test: delete cmdline free function zhihongx.peng
2021-10-11  8:26         ` Dmitry Kozlyuk
2021-10-11  5:20       ` [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit Peng, ZhihongX
2021-10-11  8:25       ` Dmitry Kozlyuk
2021-10-13  1:53         ` Peng, ZhihongX
2021-10-13  2:36           ` Dmitry Kozlyuk
2021-10-13  3:12             ` Peng, ZhihongX
2021-10-13  1:52       ` [dpdk-dev] [PATCH v4 " zhihongx.peng
2021-10-13  1:52         ` zhihongx.peng [this message]
2021-10-18 13:58           ` [dpdk-dev] [PATCH v5] " zhihongx.peng
2021-10-18 14:29             ` Dmitry Kozlyuk
2021-10-20  7:03               ` Olivier Matz
2021-10-22 21:33                 ` Thomas Monjalon
2021-10-20  9:22             ` Peng, ZhihongX
2021-10-15 12:58         ` [dpdk-dev] [PATCH v4 1/2] " Olivier Matz
2021-10-18  5:16           ` Peng, ZhihongX
2021-09-30  6:47   ` [dpdk-dev] [PATCH v2 " Peng, ZhihongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211013015223.1155876-2-zhihongx.peng@intel.com \
    --to=zhihongx.peng@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).