DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic
@ 2021-08-23  3:20 Joyce Kong
  2021-09-27 19:27 ` Olivier Matz
  2021-10-13 20:48 ` [dpdk-dev] [PATCH v2] " Dharmik Thakkar
  0 siblings, 2 replies; 5+ messages in thread
From: Joyce Kong @ 2021-08-23  3:20 UTC (permalink / raw)
  To: Olivier Matz; +Cc: ruifeng.wang, dev, nd

In stack module, remove the duplicated header file rte_atomic.h
as it has been included in rte_spinlock.h/rte_pause.h

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test/test_stack.c | 1 -
 lib/stack/rte_stack.c | 1 -
 lib/stack/rte_stack.h | 1 -
 3 files changed, 3 deletions(-)

diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 00efb38e2a..bc38961433 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -4,7 +4,6 @@
 
 #include <string.h>
 
-#include <rte_atomic.h>
 #include <rte_lcore.h>
 #include <rte_malloc.h>
 #include <rte_random.h>
diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c
index f1cbb9803f..d3bfc57955 100644
--- a/lib/stack/rte_stack.c
+++ b/lib/stack/rte_stack.c
@@ -5,7 +5,6 @@
 #include <string.h>
 
 #include <rte_string_fns.h>
-#include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_errno.h>
diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h
index 27640f87b2..321f4cec1a 100644
--- a/lib/stack/rte_stack.h
+++ b/lib/stack/rte_stack.h
@@ -19,7 +19,6 @@
 extern "C" {
 #endif
 
-#include <rte_atomic.h>
 #include <rte_compat.h>
 #include <rte_debug.h>
 #include <rte_errno.h>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic
  2021-08-23  3:20 [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic Joyce Kong
@ 2021-09-27 19:27 ` Olivier Matz
  2021-10-13 20:48 ` [dpdk-dev] [PATCH v2] " Dharmik Thakkar
  1 sibling, 0 replies; 5+ messages in thread
From: Olivier Matz @ 2021-09-27 19:27 UTC (permalink / raw)
  To: Joyce Kong; +Cc: ruifeng.wang, dev, nd

Hi Joyce,

On Sun, Aug 22, 2021 at 10:20:34PM -0500, Joyce Kong wrote:
> In stack module, remove the duplicated header file rte_atomic.h
> as it has been included in rte_spinlock.h/rte_pause.h
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Sorry for the late feedback.

No objection about the patch itself, but I don't think the commit log
should say that rte_atomic.h is indirectly included by
rte_spinlock.h/rte_pause.h.

To me, it is not a good reason to remove an include. However, it looks
that no function from rte_atomic.h is used in these files, especially
since commit c51e67c2ee18 ("test/stack: remove thread synchronisation")
for the test app.

Thanks,
Olivier

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v2] stack: remove duplicated include of atomic
  2021-08-23  3:20 [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic Joyce Kong
  2021-09-27 19:27 ` Olivier Matz
@ 2021-10-13 20:48 ` Dharmik Thakkar
  2021-10-15 12:59   ` Olivier Matz
  1 sibling, 1 reply; 5+ messages in thread
From: Dharmik Thakkar @ 2021-10-13 20:48 UTC (permalink / raw)
  To: Olivier Matz
  Cc: dev, nd, honnappa.nagarahalli, ruifeng.wang, joyce.kong, dharmik.thakkar

From: Joyce Kong <joyce.kong@arm.com>

In stack module, remove the header file rte_atomic.h
as it is not being used.

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
v2:
  Change commit message (Olivier)

---
 app/test/test_stack.c | 1 -
 lib/stack/rte_stack.c | 1 -
 lib/stack/rte_stack.h | 1 -
 3 files changed, 3 deletions(-)

diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 00efb38e2ab8..bc3896143334 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -4,7 +4,6 @@
 
 #include <string.h>
 
-#include <rte_atomic.h>
 #include <rte_lcore.h>
 #include <rte_malloc.h>
 #include <rte_random.h>
diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c
index 5e56cd9f0cd3..56bf2c8d6d3d 100644
--- a/lib/stack/rte_stack.c
+++ b/lib/stack/rte_stack.c
@@ -6,7 +6,6 @@
 #include <sys/queue.h>
 
 #include <rte_string_fns.h>
-#include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_errno.h>
diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h
index 27640f87b245..321f4cec1a10 100644
--- a/lib/stack/rte_stack.h
+++ b/lib/stack/rte_stack.h
@@ -19,7 +19,6 @@
 extern "C" {
 #endif
 
-#include <rte_atomic.h>
 #include <rte_compat.h>
 #include <rte_debug.h>
 #include <rte_errno.h>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] stack: remove duplicated include of atomic
  2021-10-13 20:48 ` [dpdk-dev] [PATCH v2] " Dharmik Thakkar
@ 2021-10-15 12:59   ` Olivier Matz
  2021-10-19 14:02     ` David Marchand
  0 siblings, 1 reply; 5+ messages in thread
From: Olivier Matz @ 2021-10-15 12:59 UTC (permalink / raw)
  To: Dharmik Thakkar; +Cc: dev, nd, honnappa.nagarahalli, ruifeng.wang, joyce.kong

On Wed, Oct 13, 2021 at 03:48:12PM -0500, Dharmik Thakkar wrote:
> From: Joyce Kong <joyce.kong@arm.com>
> 
> In stack module, remove the header file rte_atomic.h
> as it is not being used.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] stack: remove duplicated include of atomic
  2021-10-15 12:59   ` Olivier Matz
@ 2021-10-19 14:02     ` David Marchand
  0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2021-10-19 14:02 UTC (permalink / raw)
  To: Joyce Kong
  Cc: Dharmik Thakkar, dev, nd, Honnappa Nagarahalli,
	Ruifeng Wang (Arm Technology China),
	Olivier Matz

On Fri, Oct 15, 2021 at 2:59 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Wed, Oct 13, 2021 at 03:48:12PM -0500, Dharmik Thakkar wrote:
> > From: Joyce Kong <joyce.kong@arm.com>
> >
> > In stack module, remove the header file rte_atomic.h
> > as it is not being used.
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks.

-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-19 14:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23  3:20 [dpdk-dev] [PATCH v1] stack: remove duplicated include of atomic Joyce Kong
2021-09-27 19:27 ` Olivier Matz
2021-10-13 20:48 ` [dpdk-dev] [PATCH v2] " Dharmik Thakkar
2021-10-15 12:59   ` Olivier Matz
2021-10-19 14:02     ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git