From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE6E7A034F; Thu, 14 Oct 2021 02:59:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A54964067C; Thu, 14 Oct 2021 02:59:09 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 3950440041 for ; Thu, 14 Oct 2021 02:59:08 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id j21so19883413lfe.0 for ; Wed, 13 Oct 2021 17:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l4EUwwAeX8S1p1w4EXLoNbND4bRG7/dmsmpfiKlmKAs=; b=OJce0N/Ju9+fEQX50l6Ecoa+uswg3LfktQoGe/Tzqo3+9tQOA9CsIrbOfr1hnsgAUo sf+IbofopPckvyKpyIcCCrIcIMC7CMo3HYtlMkCuJ40B5ZRhv+bT9AP8a5n8LhMwVN4Z j4DrS1Nrkw9zzvlqbUZu4PwG03GrYEBJzA3PzgJ8MRqL13e8Xm9Gp+YNFJ9pYcBsUd8R LR5PIPXmqbBplsitgUtvtFdTivf+lU0aemRyQ6z+tcSstykHDSY/kOpkCcU102ClWNbd Q+X463n27ZLMjQI5S/m4/ZHPUdhIuTTKyLC1gWDdqzGeWsAccWHCRDid7B1Tg7MGwX4F 8KMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l4EUwwAeX8S1p1w4EXLoNbND4bRG7/dmsmpfiKlmKAs=; b=FHqbvxh6mSuMdRClIEs78kTCwzReU0xprUh+E5xFMsLLvsfzFZmDv0itO/Hhqh/MSB PXOcgT0xuZ5ct7lNuJ4sLAIK5RI7Git6VNp9HH8Fr2EcdqSJGa6SFYGtByxu5B9d49Gq a8OkbwOwbZU9iZ3Q8/kPptHIsJATF8jNO3rIH30oqhx9WKiR7E4E9pVSWYg/DtStzO8R 7y11LVjVt9FESEz9PnCxxjZTkF9zC0yrPgbJodxGaafN+UOajzPBE1JrsG/w11N8IPem j9HWp79LndKdRovulvbsHxFYULRoWCRUpW8An01yKlNvi1oV/GfUG1Z8T9YcUKs2MPUw YUcA== X-Gm-Message-State: AOAM5315yYnb8JuE1bjaETbWisWWGJCBwWIUkPIqGWl/obZEyCk3HR/d isqs7XWDV/RTvuGYBd+CMxkiFtB4/q4= X-Google-Smtp-Source: ABdhPJwOMMibIeJLaVgIV+It1byqoe246T5NU3W/AxtFcknJWJwdiLsnw+HckQpDT2+RyMKnaKRqkg== X-Received: by 2002:a2e:8099:: with SMTP id i25mr2810146ljg.277.1634173147827; Wed, 13 Oct 2021 17:59:07 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z24sm107006ljm.75.2021.10.13.17.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 17:59:07 -0700 (PDT) Date: Thu, 14 Oct 2021 03:59:06 +0300 From: Dmitry Kozlyuk To: Harman Kalra Cc: , Bruce Richardson , , Message-ID: <20211014035906.188f76da@sovereign> In-Reply-To: <20211005121502.66964-3-hkalra@marvell.com> References: <20210826145726.102081-1-hkalra@marvell.com> <20211005121502.66964-1-hkalra@marvell.com> <20211005121502.66964-3-hkalra@marvell.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-10-05 17:44 (UTC+0530), Harman Kalra: > Making changes to the interrupt framework to use interrupt handle > APIs to get/set any field. Direct access to any of the fields > should be avoided to avoid any ABI breakage in future. How is ABI breakage applicable to internal consumers? This protects against fields renaming for sure, but convenience is arguable. If EAL needs to add a EAL-private field to struct rte_intr_handle, it must add an accessor even though the field is likely OS-specific. It would be simpler if the definition was in some private EAL header and could be accessed directly by EAL code.