From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42C32A0C4B; Thu, 14 Oct 2021 19:53:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F6F5410E5; Thu, 14 Oct 2021 19:53:33 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id A4FF84003C for ; Thu, 14 Oct 2021 19:53:31 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id j21so30876081lfe.0 for ; Thu, 14 Oct 2021 10:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sr8MF/xUqcPhAlZlf/wmn6CAEwPXTNG6iQvK/+j/1Bc=; b=TchE8dIQZLqyDB3J2OGE6D529lmvaOeEbvkYto6owAfySyakIEGLOpR4b40ZvQ9PUs HHsWdkY6ARjb0Rgy4YcNuD2n7H6N/r+2BeH2NNOpPW2/Vx5tgSV8vSKVUB9y3N36TyNu UxM2lvubCKAUjB4mSTQgnpj6Kg3VC2MjeYDQyPT1umXhDU7RNIBa494aDGSyYSvXz2Zd QDYEl6EmMFQFoJcbwtWZilXg9qBRkUT5f71OZc3WTaKT2ur/WHyy+fEC/O3rXJMIX2ph Ygg41KEM6rQ015KVpk8ZIl+CfyhWF3yGzX3a5dsDaLW91q39WWJRqiMB5TZldBILbrcf uUWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sr8MF/xUqcPhAlZlf/wmn6CAEwPXTNG6iQvK/+j/1Bc=; b=QOlzSH3S/t47xRf8C76sJ7L35kCm3LK6Z2PDfQcjGQQkUtstkZAMYrayXwkFOhBg2c dIzmal8QILm0qxz/hfAYIYiTm3yYZlEVyYrFqEcxFplPoxbZa+YPDki2QwVQ2pMSeaM8 lB7hl+la9U0nB87J2f7bcYZBFdbqI71BIdtRoMoyVUOaNOILzTevcsxFJCBkeE9Dw0qA +HWeKjyl1PHk9ReXramnGepuZlTyC7LHDTiHOp1a735w2nsoCj4GSkpQ7MU7o29syefw h9SCDJefh16+ebKnSps1pbN5BxeE0Ct0Joh2PzxgtlNbk+4aTQ6VzNHdmxNH2WpAqU1M b9GA== X-Gm-Message-State: AOAM533aqOKhZVaNlOyVU8d/Ro806aZXxqZBKN+K46zXxPD6LbRX1kPk 9EV1x4UpIDm3XmyLH9lFOYc= X-Google-Smtp-Source: ABdhPJxdkdLAITbcS9mv/T2JV6v2CCDxevjqn5DVxUbuPtFxMF/zQakJIhjLTlFEL8s4t1LMj5QzHQ== X-Received: by 2002:a2e:5d8:: with SMTP id 207mr7510765ljf.429.1634234011320; Thu, 14 Oct 2021 10:53:31 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id p21sm270953lfg.18.2021.10.14.10.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 10:53:31 -0700 (PDT) Date: Thu, 14 Oct 2021 20:53:30 +0300 From: Dmitry Kozlyuk To: Harman Kalra Cc: "dev@dpdk.org" , Bruce Richardson , "david.marchand@redhat.com" , "mdr@ashroe.eu" Message-ID: <20211014205330.69ee1c0b@sovereign> In-Reply-To: References: <20210826145726.102081-1-hkalra@marvell.com> <20211005121502.66964-1-hkalra@marvell.com> <20211005121502.66964-3-hkalra@marvell.com> <20211014035906.188f76da@sovereign> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-10-14 17:31 (UTC+0000), Harman Kalra: > > -----Original Message----- > > From: Dmitry Kozlyuk > > Sent: Thursday, October 14, 2021 6:29 AM > > To: Harman Kalra > > Cc: dev@dpdk.org; Bruce Richardson ; > > david.marchand@redhat.com; mdr@ashroe.eu > > Subject: [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to > > interrupt handle > > > > External Email > > > > ---------------------------------------------------------------------- > > 2021-10-05 17:44 (UTC+0530), Harman Kalra: > > > Making changes to the interrupt framework to use interrupt handle APIs > > > to get/set any field. Direct access to any of the fields should be > > > avoided to avoid any ABI breakage in future. > > > > How is ABI breakage applicable to internal consumers? > > > > This protects against fields renaming for sure, but convenience is arguable. > > If EAL needs to add a EAL-private field to struct rte_intr_handle, it must add > > an accessor even though the field is likely OS-specific. > > It would be simpler if the definition was in some private EAL header and > > could be accessed directly by EAL code. > > Initially we thought to implement this way only i.e. defining rte_intr_handle inside internal headers > but supporting out of tree drivers was one of the reason to go via this get/set approach. All drivers > internal and external should follow the same way, that was the intention. > > Thanks > Harman True for drivers, I understand this, but the question is about EAL itself. I shouldn't say "internal consumers", I only meant EAL, not inbox drivers.