From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC472A034F; Fri, 15 Oct 2021 18:18:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DC50410E0; Fri, 15 Oct 2021 18:18:41 +0200 (CEST) Received: from AZHDRRW-EX02.NVIDIA.COM (azhdrrw-ex02.nvidia.com [20.64.145.131]) by mails.dpdk.org (Postfix) with ESMTP id 3D67A4067C for ; Fri, 15 Oct 2021 18:18:40 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by mxs.oss.nvidia.com (10.13.234.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Fri, 15 Oct 2021 09:18:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=an5cBXqjS4Hxagfhd7MTfiOKHKPtj/3ZcmRtVO02M3Fo+e6qhbzzXhqD75HreRjpx1gN2Lx+F1TjCQjWK5e0AMpKUFGSWi1AB6V3DY0/w3qXIv+33x5LVGP0H8sHAZ1xjHgwVo7yJW7Ds8lPHtA1x557qatlLN95SbjnGo4cUJCP+RL7kyeXm5jyMSKIwt0rWB0Pw0qznieo5BbBnFDWk2wRBuM2mi+mii0v8wOyQ4l8sO6W1UKcsfGyGyawT/1gdLnvGuBWLt+f/818kju7hTmKAgJxFtTe72TPMKf5dN7gtI0olxyf2v/96QWlmkR4yaKQP+QKmIRJ4Ey3qZ+/ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ab8mUv1DbkScfkzl+K7UGibggrmeBgCLE8r1adqkwr0=; b=ZSy/bGKoTEQswJoawk9al5yV6A5OUUa41oMQrHcIbZ9hnnLkyGbNT3AjVGmMGYsMuhz2twAEmGIv8ZDV/vKYaT4mOTYNyNyEgtGzJ0kuKekETWYbHxD4Wepxc1Gjg5q53G6/jpFNS/pFd6KeILERbLCCXKWgEOAkVPcQSE+xK8J7U6GwmJu33L+uddaNRI+MBJBn6UhwsrQCUUDxho6Ly1WFNmzAdU8x3w0IiHAChLs70aYfk8scfYgIsDrX7XbJ2noihiV5BwTmxfW/07oV5fw0rKrD7GZ7kfSUAFku2uKhTZKoovDnPLraoXK+H6QorOQNDPnrwjYqL9XUq/BEzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ab8mUv1DbkScfkzl+K7UGibggrmeBgCLE8r1adqkwr0=; b=hMqHzCpudkIwXFJgZmMNcapprRZjEV6Yo7lO/4+NvedCOCzqXILnoZPlU2fXgQhp4m4JVC5r8tH0bqadj1ZMEKB/E5RLiwbRii3MVR1kEVOfgLPQSClTVhl/G6HRRMj5f07SwSJCy+qhqKAN/kIrUIvRZv0K/5l5gghxdX08vjFpvokX7v++3Pc8QKyrmLol4pphpURfwlHV5yAGYVKd+fF6e1D/d/kuDbLzAlOH8OmrZdA0aSyC3zjNX6iPcS9WDhTrzeJKVzy1zGVg87lwBvSe4PY8+bq1k7+cyqxWHalORlrOHuphQJ2CrPKYidPCPKBYH7iQXEYnLe6vt9H6pA== Received: from DM5PR18CA0063.namprd18.prod.outlook.com (2603:10b6:3:22::25) by BN6PR1201MB0148.namprd12.prod.outlook.com (2603:10b6:405:55::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct 2021 16:18:37 +0000 Received: from DM6NAM11FT051.eop-nam11.prod.protection.outlook.com (2603:10b6:3:22:cafe::9c) by DM5PR18CA0063.outlook.office365.com (2603:10b6:3:22::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 16:18:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT051.mail.protection.outlook.com (10.13.172.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 16:18:37 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 15 Oct 2021 16:18:36 +0000 From: Dmitry Kozlyuk To: Date: Fri, 15 Oct 2021 19:18:17 +0300 Message-ID: <20211015161822.3099818-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211005005216.2427489-1-dkozlyuk@nvidia.com> References: <20211005005216.2427489-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34f63782-8dec-448f-5ebc-08d98ff7719f X-MS-TrafficTypeDiagnostic: BN6PR1201MB0148: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oJk++25w8AErUvtKas7b+Z+NADjOln5rku7h5WTQb5NHhZZy2fFHQ6hnsQPl0rlpFOhF/QRmyskN8Ev379CSwCwQDCiVquZricye5Vuc/NDlUxgFHlVDeadGrTXUY0xMDZ4VXMH4T+0cB8+UDNUgR94YOWAsV/qzlISR5U+QE6TfS8KHeM9GjPBVjR5Gx5CO0gpJ6nzLBIh2kVklNmzOEDyIw2Dem/8J1G9PUz8zAgda1dscVmyiLLg900/owGq4cTRu1tqeZPMw1X+VopNaljy4U4tFrzfw/GIRXqpT28XqkbJv9bNxJGiV7X+TpOsZF4bar4ciFnWvuv2OTBZmDYDDIXA4mCGxgEMl+6w2uKSYQ4BpvWUZD+jr8+7XGt6bhCzxtMigKSL1Hy4Zu0Gi3g8/SMvesu+r1GYD6OUKUKHUtUuIOA3eFwOt2fDPLiYyezNEt9M/QAKzblFuf60116SF7LhxKNDUkSfbiCUUHUwVPRzIq9kpQOPE2ikuD1cfVrf9qWJRoKPmHkMYHy9euB8Ie5mCSZSdDMT9TyZ8aNHC36ga8BlTf8q7YWscRQnhskhTeQi4qlzj9LCUhf9hanWWIu5belFrZQbIal1cj9ZjWjzcQW/e3LOV7i1/9xiK9IKl8vq97tRq8IucRUI5cA7+4gLksuz3Cs3cViUKhjj4MMQvrdDDREMdSdAf1Gv1xnxwCyMw5DcFrd0QsGh1EL+A3SE3ycx4tOVZq16CyhPsSf+Cv3zqi309IrcDes0ksXr529z2C19dlEZDbYb9Pig7mwqmU/Nga+9cUXyeRBU= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(508600001)(7696005)(36860700001)(5660300002)(966005)(6916009)(316002)(26005)(7636003)(356005)(8676002)(82310400003)(8936002)(6286002)(36756003)(70206006)(186003)(16526019)(1076003)(2906002)(86362001)(70586007)(55016002)(6666004)(426003)(336012)(47076005)(2616005)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 16:18:37.4530 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34f63782-8dec-448f-5ebc-08d98ff7719f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT051.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0148 Subject: [dpdk-dev] [PATCH v2 0/5] Flow entites behavior on port restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD would keep indirect actions. In the end, applications are greatly affected by whatever contract there is and need to know it. It is proposed to advertise capabilities of keeping flow rules and indirect actions (as a special case of shared object) using a combination of ethdev info and rte_flow calls. Then a bug is fixed in mlx5 PMD that prevented indirect RSS action from being kept, and the driver starts advertising the new capability. Prior discussions: 1) http://inbox.dpdk.org/dev/20210727073121.895620-1-dkozlyuk@nvidia.com/ 2) http://inbox.dpdk.org/dev/20210901085516.3647814-1-dkozlyuk@nvidia.com/ Dmitry Kozlyuk (5): ethdev: add capability to keep flow rules on restart ethdev: add capability to keep shared objects on restart net/mlx5: discover max flow priority using DevX net/mlx5: create drop queue using DevX net/mlx5: preserve indirect actions on restart doc/guides/prog_guide/rte_flow.rst | 51 +++++ drivers/net/mlx5/linux/mlx5_os.c | 5 - drivers/net/mlx5/mlx5_devx.c | 211 ++++++++++++++++++--- drivers/net/mlx5/mlx5_ethdev.c | 1 + drivers/net/mlx5/mlx5_flow.c | 292 ++++++++++++++++++++++++++--- drivers/net/mlx5/mlx5_flow.h | 6 + drivers/net/mlx5/mlx5_flow_dv.c | 103 ++++++++++ drivers/net/mlx5/mlx5_flow_verbs.c | 77 +------- drivers/net/mlx5/mlx5_rx.h | 4 + drivers/net/mlx5/mlx5_rxq.c | 99 ++++++++-- drivers/net/mlx5/mlx5_trigger.c | 10 + lib/ethdev/rte_ethdev.h | 10 + lib/ethdev/rte_flow.h | 1 + 13 files changed, 733 insertions(+), 137 deletions(-) -- 2.25.1