DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Subject: [dpdk-dev] [PATCH v2 0/4] mbuf: offload flags namespace
Date: Fri, 15 Oct 2021 21:24:04 +0200	[thread overview]
Message-ID: <20211015192408.21798-1-olivier.matz@6wind.com> (raw)
In-Reply-To: <20210929214817.18082-1-olivier.matz@6wind.com>

This patchset fixes the mbuf offload flags namespace by adding an RTE_
prefix to the definitions. The old flags remain usable, but a deprecation
warning is issued at compilation.

v2
* rebase
* remove part about PKT_RX_EIP_CKSUM_BAD, already in 74a74bf98c
* mark old vlan flags as deprecated instead of removing them
* clarify that rx checksum flags are not really removed (just remove dup)


Olivier Matz (4):
  mbuf: remove duplicate definition of cksum offload flags
  mbuf: mark old VLAN offload flags as deprecated
  cocci: add cocci script to rename mbuf offload flags
  mbuf: add rte prefix to offload flags

 app/test-pmd/csumonly.c                       |  62 +--
 app/test-pmd/flowgen.c                        |   8 +-
 app/test-pmd/ieee1588fwd.c                    |   6 +-
 app/test-pmd/macfwd.c                         |   8 +-
 app/test-pmd/macswap_common.h                 |  12 +-
 app/test-pmd/txonly.c                         |   8 +-
 app/test-pmd/util.c                           |  18 +-
 app/test/test_cryptodev_security_ipsec.c      |   4 +-
 app/test/test_ipsec.c                         |   4 +-
 app/test/test_mbuf.c                          | 144 +++---
 .../cocci/prefix_mbuf_offload_flags.cocci     | 441 ++++++++++++++++++
 doc/guides/nics/bnxt.rst                      |   8 +-
 doc/guides/nics/enic.rst                      |   8 +-
 doc/guides/nics/features.rst                  |  70 +--
 doc/guides/nics/ixgbe.rst                     |   2 +-
 doc/guides/nics/mlx5.rst                      |   6 +-
 .../generic_segmentation_offload_lib.rst      |   4 +-
 doc/guides/prog_guide/mbuf_lib.rst            |  18 +-
 doc/guides/prog_guide/metrics_lib.rst         |   2 +-
 doc/guides/prog_guide/rte_flow.rst            |  14 +-
 doc/guides/rel_notes/deprecation.rst          |   5 -
 doc/guides/rel_notes/release_21_11.rst        |   3 +
 drivers/compress/mlx5/mlx5_compress.c         |   2 +-
 drivers/crypto/cnxk/cn10k_cryptodev_ops.c     |  12 +-
 drivers/crypto/cnxk/cn10k_ipsec_la_ops.h      |   4 +-
 drivers/crypto/mlx5/mlx5_crypto.c             |   2 +-
 drivers/event/cnxk/cn9k_worker.h              |   2 +-
 drivers/event/octeontx/ssovf_worker.c         |  36 +-
 drivers/event/octeontx/ssovf_worker.h         |   2 +-
 drivers/event/octeontx2/otx2_worker.h         |   2 +-
 drivers/net/af_packet/rte_eth_af_packet.c     |   4 +-
 drivers/net/atlantic/atl_rxtx.c               |  46 +-
 drivers/net/avp/avp_ethdev.c                  |   8 +-
 drivers/net/axgbe/axgbe_rxtx.c                |  64 +--
 drivers/net/axgbe/axgbe_rxtx_vec_sse.c        |   2 +-
 drivers/net/bnx2x/bnx2x.c                     |   2 +-
 drivers/net/bnx2x/bnx2x_rxtx.c                |   2 +-
 drivers/net/bnxt/bnxt_rxr.c                   |  50 +-
 drivers/net/bnxt/bnxt_rxr.h                   |  32 +-
 drivers/net/bnxt/bnxt_txr.c                   |  40 +-
 drivers/net/bnxt/bnxt_txr.h                   |  38 +-
 drivers/net/bonding/rte_eth_bond_pmd.c        |   2 +-
 drivers/net/cnxk/cn10k_ethdev.c               |  18 +-
 drivers/net/cnxk/cn10k_rx.h                   |  38 +-
 drivers/net/cnxk/cn10k_tx.h                   | 178 +++----
 drivers/net/cnxk/cn9k_ethdev.c                |  18 +-
 drivers/net/cnxk/cn9k_rx.h                    |  32 +-
 drivers/net/cnxk/cn9k_tx.h                    | 170 +++----
 drivers/net/cnxk/cnxk_ethdev.h                |  10 +-
 drivers/net/cnxk/cnxk_lookup.c                |  40 +-
 drivers/net/cxgbe/sge.c                       |  46 +-
 drivers/net/dpaa/dpaa_ethdev.h                |   7 +-
 drivers/net/dpaa/dpaa_rxtx.c                  |  10 +-
 drivers/net/dpaa2/dpaa2_rxtx.c                |  30 +-
 drivers/net/e1000/em_rxtx.c                   |  39 +-
 drivers/net/e1000/igb_rxtx.c                  |  81 ++--
 drivers/net/ena/ena_ethdev.c                  |  53 ++-
 drivers/net/enetc/enetc_rxtx.c                |  44 +-
 drivers/net/enic/enic_main.c                  |  10 +-
 drivers/net/enic/enic_res.c                   |  12 +-
 drivers/net/enic/enic_rxtx.c                  |  24 +-
 drivers/net/enic/enic_rxtx_common.h           |  18 +-
 drivers/net/enic/enic_rxtx_vec_avx2.c         |  80 ++--
 drivers/net/fm10k/fm10k_rxtx.c                |  43 +-
 drivers/net/fm10k/fm10k_rxtx_vec.c            |  25 +-
 drivers/net/hinic/hinic_pmd_rx.c              |  22 +-
 drivers/net/hinic/hinic_pmd_tx.c              |  56 +--
 drivers/net/hinic/hinic_pmd_tx.h              |  13 +-
 drivers/net/hns3/hns3_ethdev.h                |   2 +-
 drivers/net/hns3/hns3_rxtx.c                  | 108 ++---
 drivers/net/hns3/hns3_rxtx.h                  |  25 +-
 drivers/net/hns3/hns3_rxtx_vec_neon.h         |   2 +-
 drivers/net/hns3/hns3_rxtx_vec_sve.c          |   2 +-
 drivers/net/i40e/i40e_rxtx.c                  | 157 +++----
 drivers/net/i40e/i40e_rxtx_vec_altivec.c      |  22 +-
 drivers/net/i40e/i40e_rxtx_vec_avx2.c         |  70 +--
 drivers/net/i40e/i40e_rxtx_vec_avx512.c       |  62 +--
 drivers/net/i40e/i40e_rxtx_vec_neon.c         |  50 +-
 drivers/net/i40e/i40e_rxtx_vec_sse.c          |  60 +--
 drivers/net/iavf/iavf_rxtx.c                  |  90 ++--
 drivers/net/iavf/iavf_rxtx.h                  |  28 +-
 drivers/net/iavf/iavf_rxtx_vec_avx2.c         | 140 +++---
 drivers/net/iavf/iavf_rxtx_vec_avx512.c       | 140 +++---
 drivers/net/iavf/iavf_rxtx_vec_common.h       |  16 +-
 drivers/net/iavf/iavf_rxtx_vec_sse.c          | 112 ++---
 drivers/net/ice/ice_rxtx.c                    | 117 +++--
 drivers/net/ice/ice_rxtx_vec_avx2.c           | 158 +++----
 drivers/net/ice/ice_rxtx_vec_avx512.c         | 158 +++----
 drivers/net/ice/ice_rxtx_vec_common.h         |  16 +-
 drivers/net/ice/ice_rxtx_vec_sse.c            | 112 ++---
 drivers/net/igc/igc_txrx.c                    |  67 +--
 drivers/net/ionic/ionic_rxtx.c                |  59 ++-
 drivers/net/ixgbe/ixgbe_ethdev.c              |   4 +-
 drivers/net/ixgbe/ixgbe_rxtx.c                | 113 +++--
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c       |  38 +-
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c        |  44 +-
 drivers/net/liquidio/lio_rxtx.c               |  16 +-
 drivers/net/mlx4/mlx4_rxtx.c                  |  22 +-
 drivers/net/mlx5/mlx5_flow.c                  |   2 +-
 drivers/net/mlx5/mlx5_rx.c                    |  18 +-
 drivers/net/mlx5/mlx5_rx.h                    |   4 +-
 drivers/net/mlx5/mlx5_rxq.c                   |   2 +-
 drivers/net/mlx5/mlx5_rxtx.c                  |  18 +-
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h      |  76 +--
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h         |  36 +-
 drivers/net/mlx5/mlx5_rxtx_vec_sse.h          |  38 +-
 drivers/net/mlx5/mlx5_tx.h                    | 104 ++---
 drivers/net/mvneta/mvneta_ethdev.h            |   6 +-
 drivers/net/mvneta/mvneta_rxtx.c              |  16 +-
 drivers/net/mvpp2/mrvl_ethdev.c               |  22 +-
 drivers/net/netvsc/hn_rxtx.c                  |  28 +-
 drivers/net/nfp/nfp_rxtx.c                    |  26 +-
 drivers/net/octeontx/octeontx_rxtx.h          |  38 +-
 drivers/net/octeontx2/otx2_ethdev.c           |  18 +-
 drivers/net/octeontx2/otx2_lookup.c           |  40 +-
 drivers/net/octeontx2/otx2_rx.c               |  12 +-
 drivers/net/octeontx2/otx2_rx.h               |  22 +-
 drivers/net/octeontx2/otx2_tx.c               |  86 ++--
 drivers/net/octeontx2/otx2_tx.h               |  70 +--
 drivers/net/qede/qede_rxtx.c                  | 104 ++---
 drivers/net/qede/qede_rxtx.h                  |  20 +-
 drivers/net/sfc/sfc_dp_tx.h                   |  14 +-
 drivers/net/sfc/sfc_ef100_rx.c                |  18 +-
 drivers/net/sfc/sfc_ef100_tx.c                |  52 +--
 drivers/net/sfc/sfc_ef10_essb_rx.c            |   6 +-
 drivers/net/sfc/sfc_ef10_rx.c                 |   6 +-
 drivers/net/sfc/sfc_ef10_rx_ev.h              |  16 +-
 drivers/net/sfc/sfc_ef10_tx.c                 |  18 +-
 drivers/net/sfc/sfc_rx.c                      |  22 +-
 drivers/net/sfc/sfc_tso.c                     |   2 +-
 drivers/net/sfc/sfc_tso.h                     |   2 +-
 drivers/net/sfc/sfc_tx.c                      |   4 +-
 drivers/net/tap/rte_eth_tap.c                 |  28 +-
 drivers/net/thunderx/nicvf_rxtx.c             |  24 +-
 drivers/net/thunderx/nicvf_rxtx.h             |   2 +-
 drivers/net/txgbe/txgbe_ethdev.c              |   4 +-
 drivers/net/txgbe/txgbe_rxtx.c                | 172 +++----
 drivers/net/vhost/rte_eth_vhost.c             |   2 +-
 drivers/net/virtio/virtio_rxtx.c              |  14 +-
 drivers/net/virtio/virtio_rxtx_packed.h       |   6 +-
 drivers/net/virtio/virtqueue.h                |  14 +-
 drivers/net/vmxnet3/vmxnet3_rxtx.c            |  59 ++-
 drivers/regex/mlx5/mlx5_regex_fastpath.c      |   2 +-
 examples/bpf/t2.c                             |   4 +-
 examples/ip_fragmentation/main.c              |   2 +-
 examples/ip_reassembly/main.c                 |   2 +-
 examples/ipsec-secgw/esp.c                    |   6 +-
 examples/ipsec-secgw/ipsec-secgw.c            |  20 +-
 examples/ipsec-secgw/ipsec_worker.c           |  12 +-
 examples/ipsec-secgw/sa.c                     |   2 +-
 examples/ptpclient/ptpclient.c                |   4 +-
 examples/qos_meter/main.c                     |  12 +-
 examples/vhost/main.c                         |  12 +-
 lib/ethdev/rte_ethdev.h                       |   4 +-
 lib/ethdev/rte_flow.h                         |  33 +-
 lib/eventdev/rte_event_eth_rx_adapter.c       |   4 +-
 lib/gso/gso_common.h                          |  40 +-
 lib/gso/gso_tunnel_tcp4.c                     |   2 +-
 lib/gso/rte_gso.c                             |  10 +-
 lib/gso/rte_gso.h                             |   4 +-
 lib/ipsec/esp_inb.c                           |  10 +-
 lib/ipsec/esp_outb.c                          |   4 +-
 lib/ipsec/misc.h                              |   2 +-
 lib/ipsec/rte_ipsec_group.h                   |   6 +-
 lib/ipsec/sa.c                                |   2 +-
 lib/mbuf/rte_mbuf.c                           | 220 ++++-----
 lib/mbuf/rte_mbuf.h                           |  30 +-
 lib/mbuf/rte_mbuf_core.h                      | 422 ++++++++++-------
 lib/mbuf/rte_mbuf_dyn.c                       |   2 +-
 lib/net/rte_ether.h                           |   6 +-
 lib/net/rte_ip.h                              |   4 +-
 lib/net/rte_net.h                             |  22 +-
 lib/pipeline/rte_table_action.c               |  10 +-
 lib/security/rte_security.h                   |  10 +-
 lib/vhost/virtio_net.c                        |  42 +-
 175 files changed, 3561 insertions(+), 3031 deletions(-)
 create mode 100644 devtools/cocci/prefix_mbuf_offload_flags.cocci

-- 
2.30.2


  parent reply	other threads:[~2021-10-15 19:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 21:48 [dpdk-dev] [PATCH 0/3] " Olivier Matz
2021-09-29 21:48 ` [dpdk-dev] [PATCH 1/3] mbuf: remove deprecated offload flags Olivier Matz
2021-10-04  8:29   ` David Marchand
2021-10-04  9:46     ` Olivier Matz
2021-09-29 21:48 ` [dpdk-dev] [PATCH 2/3] cocci: add cocci script to rename mbuf " Olivier Matz
2021-09-29 21:48 ` [dpdk-dev] [PATCH 3/3] mbuf: add rte prefix to " Olivier Matz
2021-10-15 19:24 ` Olivier Matz [this message]
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 1/4] mbuf: remove duplicate definition of cksum " Olivier Matz
2021-10-16  7:47     ` Andrew Rybchenko
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 2/4] mbuf: mark old VLAN offload flags as deprecated Olivier Matz
2021-10-16  7:50     ` Andrew Rybchenko
2021-10-17 14:46       ` Ajit Khaparde
2021-10-18  8:10       ` Olivier Matz
2021-10-18 11:15         ` Somnath Kotur
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 3/4] cocci: add cocci script to rename mbuf offload flags Olivier Matz
2021-10-15 19:24   ` [dpdk-dev] [PATCH v2 4/4] mbuf: add rte prefix to " Olivier Matz
2021-10-16  7:57     ` Andrew Rybchenko
2021-10-17 14:45       ` Ajit Khaparde
2021-10-18 11:15         ` Somnath Kotur
2021-10-24 11:43   ` [dpdk-dev] [PATCH v2 0/4] mbuf: offload flags namespace David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015192408.21798-1-olivier.matz@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).