From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1064A034F; Sat, 16 Oct 2021 10:43:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4369B41152; Sat, 16 Oct 2021 10:43:16 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062.outbound.protection.outlook.com [40.107.220.62]) by mails.dpdk.org (Postfix) with ESMTP id D0C3F41147 for ; Sat, 16 Oct 2021 10:43:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gF/ALukO9FiBhe8cLXwHxYceOutcLaxvz8rbFyjFqhQVcpt+/thXAnzGhpL9V3Kl3++1D3QZiGLPngdZzFdZVr5oRsrRJrtDUeD5a0GxG3KIeUmJaWlU6Psc/kIO9BC6DmM0OY5OzeXJAk/+pej6vaZj7xgd0ebI9V2dNSDnZF14/PJAM9hvr/0kakRMKKhxzQnccGnb4LlVqbD2vr2RXYG61+D2c469FsV3vVW8teZlOQTNC99xyQI6vYhyp5I828hyxMLJNTq5NRUB3hEX9vMXPjsyt2+MlGNYp9YfWfWjb86JErR4TQY6NcLDkOt6sAmRSTCj94jJJWj+elvGzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aPno+qiWaxz+BALuzuzRox9CojD/7z4y4W4SaxeboDw=; b=GkIH3M9FPD1anvXbNya4f2Apt6CIWl3IZwwbMIMgBkfJv1UzmdoHuL8BjyY6ZkjomyTTpaXbuy7q6YkVNGELYYUMBM5ekQr0pEhu7OmSjISgWGwgAaYmNCzsGAM/YgS3EOv6r62f5h/DhbfpHN3GfkQnp/viMv3qWRWtSlMcebo1r4DsLHj2GcnjIZsnGdP8iUWqmiXdz7lP/SohrJ7fUr7ABQneWHgPxAp2vwpi4xtY+WM2kG3erjMDeHJUgnuoPJmMCUT+AvXai224bSjh82Lo/vViKSd2x5xKDx1g4XtsJ+88Q+EtBXUPRtd9zQLl6A+BuKdchO/lELCoTdEXog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aPno+qiWaxz+BALuzuzRox9CojD/7z4y4W4SaxeboDw=; b=ArqQl+NRq+z3hiC2SW+WpUJc2GOU+4UA0av0ec1HUtugBsRdhTKlxsY63EZ8Jm8UKwHgcCUO4/1H47eBJ+zCAMHF2/4vw3/aZk+XJXXEIAN2K+LCGIpgp3GFW0ARIjFLTUUSUMOnLHrJsZn0BRy+QVR336KRMizofpqGL+uYnsDyJLh3/1tsSPqdPQpmmb+j7NcxO8N+rZO83s+gaw0HiAhyi+jJVbt1pBsmIiN4fmmHf2o9LPttNWMrQQuNefUfeNoOGx2hQ068qbPxwomUnCb8+MDmAtvg0+1+ZZtaq8FBcbRQawTtuQwhIIfz+P82rTCvY+boWuABaLPAubJRkA== Received: from MW4PR04CA0338.namprd04.prod.outlook.com (2603:10b6:303:8a::13) by BL0PR12MB4868.namprd12.prod.outlook.com (2603:10b6:208:1c4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Sat, 16 Oct 2021 08:43:09 +0000 Received: from CO1NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::9e) by MW4PR04CA0338.outlook.office365.com (2603:10b6:303:8a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Sat, 16 Oct 2021 08:43:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT055.mail.protection.outlook.com (10.13.175.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4608.15 via Frontend Transport; Sat, 16 Oct 2021 08:43:08 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sat, 16 Oct 2021 08:43:05 +0000 From: Xueming Li To: CC: , Jerin Jacob , Ferruh Yigit , Andrew Rybchenko , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , "Ananyev Konstantin" , Xiaoyun Li Date: Sat, 16 Oct 2021 16:42:34 +0800 Message-ID: <20211016084237.1808161-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211016084237.1808161-1-xuemingl@nvidia.com> References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211016084237.1808161-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 01545429-1143-45e7-3f6a-08d99080faa1 X-MS-TrafficTypeDiagnostic: BL0PR12MB4868: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6dyucQ+Oc4jjIb3L1isUR5iKZRWbLQN5kyTbRU5PjU7ie578YNc5J+y3Ala+mKg2PGFJpdjW0ZFEsCiVrtxL97hlxUVTH1YKP0+firTizidLz+KXug0tDWSkckIL8Do0YuGTDkSNh7Ck+O8n1choPe1FuSFQmdHWcWH/18LG+Guan1ZXTKndMUlxaTNq6tl6kzil9uyXm73S9RVPq2XSHh086TMUOJbLoc8nAM9Bgpoi+0Vd8cF5x/y1WiZsGk4d/HaoNcjSmM8RxcbvRzqniJmMC1+OrVFIVYBl1oPh8ACeJtm720pQzcYqfJVomWZZ37w18gGQnlv1AYLKwbWgGbpz71B+QUyqWciZQx1KGi0HnwasVwF3xD6rNLWCxUKQrWo3ipdby3gUOfTK5Iw7jDEMG3h9WBVo5Y/rvtRQCiL7XhSqUbdi6nLMknVZDQgUVfo1jkoV4BEEXgXV1SuGH3vVojJLqExXgSjO7y99/lqkA/KTybsdk8uw49yYYwLC2wLn08fSO4rQrtS5RqlcCdBvpnCJQu5BpPL4/GEv6TufRqbcHgiWyjUX5eLgAU8vJrhwQ6ASq39nEAoRUhad+ketU2XCUqNZztNkMB1vDwticJkEod19nV+uSYJ+VXdUT7y/RVMu9OtvgCu1VyWuq4x4gAyFQq1dkz4oBmuaiLq3ArzH39D7wwv/DKb2TAi7B+8Lhcya610nojUhC11X1g== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(54906003)(55016002)(70206006)(82310400003)(4326008)(26005)(70586007)(86362001)(5660300002)(2906002)(7696005)(8676002)(2616005)(6916009)(426003)(316002)(7636003)(36756003)(83380400001)(8936002)(1076003)(356005)(336012)(47076005)(36860700001)(6666004)(186003)(508600001)(6286002)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2021 08:43:08.3741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01545429-1143-45e7-3f6a-08d99080faa1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4868 Subject: [dpdk-dev] [PATCH v7 2/5] app/testpmd: new parameter to enable shared Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Adds "--rxq-share=X" parameter to enable shared RxQ, share if device supports, otherwise fallback to standard RxQ. Share group number grows per X ports. X defaults to MAX, implies all ports join share group 1. Forwarding engine "shared-rxq" should be used which Rx only and update stream statistics correctly. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 6 +++++- app/test-pmd/parameters.c | 13 +++++++++++++ app/test-pmd/testpmd.c | 18 +++++++++++++++--- app/test-pmd/testpmd.h | 2 ++ doc/guides/testpmd_app_ug/run_app.rst | 7 +++++++ 5 files changed, 42 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 9c66329e96e..96fc2ab888b 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2709,7 +2709,11 @@ rxtx_config_display(void) printf(" RX threshold registers: pthresh=%d hthresh=%d " " wthresh=%d\n", pthresh_tmp, hthresh_tmp, wthresh_tmp); - printf(" RX Offloads=0x%"PRIx64"\n", offloads_tmp); + printf(" RX Offloads=0x%"PRIx64, offloads_tmp); + if (rx_conf->share_group > 0) + printf(" share group=%u", + rx_conf->share_group); + printf("\n"); } /* per tx queue config only for first queue to be less verbose */ diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 3f94a82e321..30dae326310 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -167,6 +167,7 @@ usage(char* progname) printf(" --tx-ip=src,dst: IP addresses in Tx-only mode\n"); printf(" --tx-udp=src[,dst]: UDP ports in Tx-only mode\n"); printf(" --eth-link-speed: force link speed.\n"); + printf(" --rxq-share: number of ports per shared rxq groups, defaults to MAX(1 group)\n"); printf(" --disable-link-check: disable check on link status when " "starting/stopping ports.\n"); printf(" --disable-device-start: do not automatically start port\n"); @@ -607,6 +608,7 @@ launch_args_parse(int argc, char** argv) { "rxpkts", 1, 0, 0 }, { "txpkts", 1, 0, 0 }, { "txonly-multi-flow", 0, 0, 0 }, + { "rxq-share", 2, 0, 0 }, { "eth-link-speed", 1, 0, 0 }, { "disable-link-check", 0, 0, 0 }, { "disable-device-start", 0, 0, 0 }, @@ -1271,6 +1273,17 @@ launch_args_parse(int argc, char** argv) } if (!strcmp(lgopts[opt_idx].name, "txonly-multi-flow")) txonly_multi_flow = 1; + if (!strcmp(lgopts[opt_idx].name, "rxq-share")) { + if (optarg == NULL) { + rxq_share = UINT32_MAX; + } else { + n = atoi(optarg); + if (n >= 0) + rxq_share = (uint32_t)n; + else + rte_exit(EXIT_FAILURE, "rxq-share must be >= 0\n"); + } + } if (!strcmp(lgopts[opt_idx].name, "no-flush-rx")) no_flush_rx = 1; if (!strcmp(lgopts[opt_idx].name, "eth-link-speed")) { diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17ec..4c501bf43f3 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -498,6 +498,11 @@ uint8_t record_core_cycles; */ uint8_t record_burst_stats; +/* + * Number of ports per shared Rx queue group, 0 disable. + */ +uint32_t rxq_share; + unsigned int num_sockets = 0; unsigned int socket_ids[RTE_MAX_NUMA_NODES]; @@ -3393,14 +3398,21 @@ dev_event_callback(const char *device_name, enum rte_dev_event_type type, } static void -rxtx_port_config(struct rte_port *port) +rxtx_port_config(portid_t pid) { uint16_t qid; uint64_t offloads; + struct rte_port *port = &ports[pid]; for (qid = 0; qid < nb_rxq; qid++) { offloads = port->rx_conf[qid].offloads; port->rx_conf[qid] = port->dev_info.default_rxconf; + + if (rxq_share > 0 && + (port->dev_info.dev_capa & RTE_ETH_DEV_CAPA_RXQ_SHARE)) + /* Non-zero share group to enable RxQ share. */ + port->rx_conf[qid].share_group = pid / rxq_share + 1; + if (offloads != 0) port->rx_conf[qid].offloads = offloads; @@ -3558,7 +3570,7 @@ init_port_config(void) port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; } - rxtx_port_config(port); + rxtx_port_config(pid); ret = eth_macaddr_get_print_err(pid, &port->eth_addr); if (ret != 0) @@ -3772,7 +3784,7 @@ init_port_dcb_config(portid_t pid, memcpy(&rte_port->dev_conf, &port_conf, sizeof(struct rte_eth_conf)); - rxtx_port_config(rte_port); + rxtx_port_config(pid); /* VLAN filter */ rte_port->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER; for (i = 0; i < RTE_DIM(vlan_tags); i++) diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5863b2f43f3..3dfaaad94c0 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -477,6 +477,8 @@ extern enum tx_pkt_split tx_pkt_split; extern uint8_t txonly_multi_flow; +extern uint32_t rxq_share; + extern uint16_t nb_pkt_per_burst; extern uint16_t nb_pkt_flowgen_clones; extern int nb_flows_flowgen; diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 640eadeff73..ff5908dcd50 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst @@ -389,6 +389,13 @@ The command line options are: Generate multiple flows in txonly mode. +* ``--rxq-share=[X]`` + + Create queues in shared Rx queue mode if device supports. + Group number grows per X ports. X defaults to MAX, implies all ports + join share group 1. Forwarding engine "shared-rxq" should be used + which Rx only and update stream statistics correctly. + * ``--eth-link-speed`` Set a forced link speed to the ethernet port:: -- 2.33.0