From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFC70A0C43; Mon, 18 Oct 2021 11:56:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43B6440141; Mon, 18 Oct 2021 11:56:14 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 224C04003C; Mon, 18 Oct 2021 11:56:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C24E05C0044; Mon, 18 Oct 2021 05:56:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 18 Oct 2021 05:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=sLIxdHcoghWHUJsqSWsEJDSano WKzgq/FjAbMTfzJFI=; b=JcSGfGC8rufX7uSo5Po/sDzfHpjF3XdxRGYmumyvJN ypOXH9YYxG6h3oC+NZnMc+wqRXyPiPh2xy7fBdBOOIs13ZDaSKZCHW26ypxd6Yeg S+kjweIC6cSG8jq50jt5F+fRUFz7C+/aPV9SEOOAnEpJfw1W7BYQXqp3eMDUS02u 9YZQzFJ8DP156OA07njAQ79hAQbn5Uyz5KIqE63qQzBK6Fh7GmTzb8bM649VVrks gFZgtxigTjVfPqzhi2529fM1IdZWeB0IftT7nGzApEUPfSEZuoEwhOWLsJLYH1GY mpjMLrJ3GyfI+2icsl2BwoUO2bBfkYaEfovFa4OJOkmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=sLIxdHcoghWHUJsqS WsEJDSanoWKzgq/FjAbMTfzJFI=; b=fZMA4TDE+mqS6jHv7IyhwVTZ59ADl05G9 xEXpoY13Wpi/RuJmsW6q7wF/8xZ0IzXVtEkcpjw2Z0DTNU0GNo0k01sRmMkd21Db ds5umstZ82tS/ALxJ4V4l7DRlU6YHbB90Rg4IbXMx3T8RkjfeWUFWaIpDymiPVE6 ICfbqeIsgq7EeL+umH2ijlo1b48voeSaTbw/l7Wp+tEP6SggZzNS7ugTifB7h9Rs p5Ry9vp0ant8tVBOdP8pdaIMbPlXgaGN5ad0Xhe/ywkzEj+nOVICo6x74/dwnOhz AazHxgENRdZ2722UU8SqIiaqjd9XsRVt472dWNeNDKZjX9BEvRXbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvtddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnhepvdelvdduhedvudduveeuvdevheegudelgeeigfejheduhedttdegudff jeeihffgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Oct 2021 05:56:10 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: stable@dpdk.org, Ferruh Yigit , Sean Morrissey Date: Mon, 18 Oct 2021 11:55:58 +0200 Message-Id: <20211018095558.354074-1-thomas@monjalon.net> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] devtools: fix letter case check in commit title X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The prefix (before the colon) of the title is lowercase. The check of uppercase/lowercase in the commit title was supposed to apply after the colon, but some greps were not limited to the exact word. So in the case of "test/dma: add basic dmadev instance tests", the lowercase word "dmadev" was wrongly suggested to be uppercase. The words of the dictionary must be filtered as whole word with the grep option -w. Fixes: d448efa259e9 ("devtools: export dictionary for commit title check") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon --- devtools/check-git-log.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 9988bf863d..885d444b3d 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -111,12 +111,12 @@ IFS=' ' words="$selfdir/words-case.txt" for word in $(cat $words); do - bad=$(echo "$headlines" | grep -iw $word | grep -v $word) + bad=$(echo "$headlines" | grep -iw $word | grep -vw $word) if [ "$word" = "Tx" ]; then bad=$(echo $bad | grep -v 'OCTEON\ TX') fi for bad_line in $bad; do - bad_word=$(echo $bad_line | cut -d":" -f2 | grep -io $word) + bad_word=$(echo $bad_line | cut -d":" -f2 | grep -iwo $word) [ -z "$bad_word" ] || { printf "Wrong headline case:\n\ \"$bad_line\": $bad_word --> $word\n" && failure=true;} done -- 2.33.0