From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C03CFA0C41; Tue, 19 Oct 2021 17:35:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 823BF4121E; Tue, 19 Oct 2021 17:35:15 +0200 (CEST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id F3DA341216 for ; Tue, 19 Oct 2021 17:35:13 +0200 (CEST) Received: by mail-pj1-f53.google.com with SMTP id q2-20020a17090a2e0200b001a0fd4efd49so2121801pjd.1 for ; Tue, 19 Oct 2021 08:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mddf19bHazvbNj1aUO92no6uvB3JjjHhCcJ+C0trSyE=; b=GFjOLNFso6R4zu1L8U1fud0/bl59/xgGieOPCXF1MC3MD0y42BaxEIULBMmU3nlci0 yjW6E2TVPTVc/4U0dbsOyezRup/OfnQasbxgshbF5AOUSwoib4hxZm4QoRkB5O++hOpu EWMj5Gt1YI2czr/M8nO638IARuBzFNKJLJSFzXuJpEDibTlAQ2cq8T/yWl1k4v6iRzNb s6T6ZWPL0jrlSPNYc5yPSNQQRFI4lVd42hNFS2cACAXmGduojrac1GdEM5alq3ytlzAw 2NtA3GgMKf92x2YJcYXblQT7OR1i4/aI2bbWjvemd9+R1rqsecb+tbqAln6HKsU6G6QO Umvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mddf19bHazvbNj1aUO92no6uvB3JjjHhCcJ+C0trSyE=; b=dbDunE9wkt9w3T3FhaPdJ859UsCMZt7LdjWTVXmDQLqg0Gk0+wUucS3hSlIN7z4Efx k+bYgXrwmpoJQfdu7shYfI7kiYFt5PShtqb1BW7ObS0oqcekabkiCui888u+NLy8C/Qs cpiuo06A7r0/H6fp43GKuhCCZUWxLygOhcOwEtPv83Zg/tG0AzNFz+GPt9kY1kmK3YL7 TOtWbY5xmdevJC93rfGtImKtVQa3sjSbUoSY9zNi/082wZDOAebpQtXXjhHuAeM5jaIC NNdk2J5ptUwPnaOMG7m8nSR14XHkpbJKI06z06qAkYhNyzjsqMhz6xSCHxfe1xG/E+Dn EfSQ== X-Gm-Message-State: AOAM532sO+yW9BOJ3loy/FYmfKwwyNCCWLb4mZ7Euf7tdBFn5vC4p6vl uLa9Gm5ol3x3YxNc6YLNxAO0zg== X-Google-Smtp-Source: ABdhPJwldoQby2PC4q6g42FdHRqldnWIS/zFYV/NZ8zjtZ2jWdczmE/j3J0AaupF7crEmXGzNSlGtQ== X-Received: by 2002:a17:902:ba8e:b0:13e:c690:5acb with SMTP id k14-20020a170902ba8e00b0013ec6905acbmr33933513pls.63.1634657713150; Tue, 19 Oct 2021 08:35:13 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id c24sm17562910pgj.63.2021.10.19.08.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 08:35:12 -0700 (PDT) Date: Tue, 19 Oct 2021 08:35:06 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Aman Kumar , dev@dpdk.org, rasland@nvidia.com, asafp@nvidia.com, shys@nvidia.com, viacheslavo@nvidia.com, akozyrev@nvidia.com, matan@nvidia.com, anatoly.burakov@intel.com, keesang.song@amd.com, jerinjacobk@gmail.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, david.marchand@redhat.com Message-ID: <20211019083506.078bbbc5@hermes.local> In-Reply-To: <1936725.1xRPv8SPVf@thomas> References: <20210823084411.29592-1-aman.kumar@vvdntech.in> <20211019104724.19416-1-aman.kumar@vvdntech.in> <1936725.1xRPv8SPVf@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 19 Oct 2021 14:31:01 +0200 Thomas Monjalon wrote: > 19/10/2021 12:47, Aman Kumar: > > This patch provides rte_memcpy* calls optimized for > > AMD EPYC platforms. Use config/x86/x86_amd_epyc_linux_gcc > > as cross-file with meson to build dpdk for AMD EPYC platforms. > > Please split in 2 patches: platform & memcpy. > > What optimization is specific to EPYC? > > I dislike the asm code below. > What is AMD specific inside? > Can it use compiler intrinsics as it is done elsewhere? And why is this not done by Gcc?