From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27AB8A0C43; Wed, 20 Oct 2021 21:31:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D678940150; Wed, 20 Oct 2021 21:31:38 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id CE71740142 for ; Wed, 20 Oct 2021 21:31:37 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id v17so127676wrv.9 for ; Wed, 20 Oct 2021 12:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eESgzd7jHlKiCRpdWHDbKyawWwDNGwpo+409F+dj2i0=; b=Dd2DWtHfD5qt8Gl6dDMZvAeC8igJ5IPwVjcpvx4DsFZ9nvHmhYLEbejVZCkilZqZPv DvF4EPrx4No8KvsCaUtR9V4e9oMcFG7lIchS2EcnI3F7dkR6Qx62I7PrC3b2NQ9yxVji YzRwUJxWK5havSftXa5dgr8jwuBWBeMY9lYvl/BKuvYNt2UJBovt7KvUKp1Aq848557A vimHGsd5SRAWa3f0Nv1yWuV/EZFOM8VLe6TWSleGHAaIugCwnKq9h+XRisd+dCmILqhc AdxMR9xKet8GuLJXVRH/wJ0YVys1qIex6+jOrqBr0lR6sZf+gDpTQCQq8Z6XOWgAeHfJ QLQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eESgzd7jHlKiCRpdWHDbKyawWwDNGwpo+409F+dj2i0=; b=LgSykHz0ZX3uQwErXkZISR5ncChoePmBfk9Xa8m53Y9I1fzKkaVQwH6G0mUSa5BszU A0StpcuFm+1wUucnkCyabDOPy4+J87wFp3THk5bOOuedPCxDlApmkK3rxNwoYb2R6ofz ebKoWdIFEK8Vmhgvs/PpeiT3QGzFY4fYqLJU9RlWpgUkDdsPMqBBlZXYR2ivilw87xiI S150dIxeYa8Bg5Ujq0pp+rIpOva/v/mGC5+F3KrNR5p4Y5B6uCIde6WPAGtdi6hVlVU/ FkkCnCSI+BIdr94aNPUbER1/zuFshbVI9MAvx0R5eQACnKwwIh6VSqclFU81Vr0ITjxU IvJQ== X-Gm-Message-State: AOAM530iqSLj3iRl9lZLJW/cAXPG95zL/IGzMYjpo2/tnd3ibZhM0wWg 8XSREgrTkIcoQMeHdxpZXAR8Iw== X-Google-Smtp-Source: ABdhPJzra1+U41yb8ooiEPSHf/zXh2NWQSkJ5n/bmkjUFGaLCAHpwe6JOSNpocMH9Wsi8yGtvpg5SQ== X-Received: by 2002:a05:6000:552:: with SMTP id b18mr1551912wrf.112.1634758297572; Wed, 20 Oct 2021 12:31:37 -0700 (PDT) Received: from 6wind.com (2a01cb000f483e003b320a5f125af7b5.ipv6.abo.wanadoo.fr. [2a01:cb00:f48:3e00:3b32:a5f:125a:f7b5]) by smtp.gmail.com with ESMTPSA id j1sm3155765wrd.28.2021.10.20.12.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:31:37 -0700 (PDT) Date: Wed, 20 Oct 2021 21:31:36 +0200 From: Robin Jarry To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Neil Horman , Dmitry Kozlyuk , Stephen Hemminger , Bruce Richardson Message-ID: <20211020193136.6tkty3fcxg4fk2ck@6wind.com> References: <20211019125230.27480-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211019125230.27480-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH] usertools/pmdinfo: fix plugin auto scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, 2021-10-19, David Marchand: > Migration to argparse was incomplete. > > $ dpdk-pmdinfo.py -p $(which dpdk-testpmd) > Traceback (most recent call last): > File "/usr/bin/dpdk-pmdinfo.py", line 626, in > main() > File "/usr/bin/dpdk-pmdinfo.py", line 596, in main > exit(scan_for_autoload_pmds(args[0])) > TypeError: 'Namespace' object does not support indexing > > Fixes: 81255f27c65c ("usertools: replace optparse with argparse") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand It is sad that pylint does not report an error: https://pycodequ.al/docs/pylint-messages/e1136-unsubscriptable-object.html Anyway, this fix looks good. Reviewed-by: Robin Jarry