From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E1ACA0C43; Fri, 22 Oct 2021 16:07:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C73244117E; Fri, 22 Oct 2021 16:07:48 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 4746341149 for ; Fri, 22 Oct 2021 16:07:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="229251537" X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="229251537" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 07:07:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="633338332" Received: from silpixa00399839.ir.intel.com (HELO localhost.localdomain) ([10.237.222.139]) by fmsmga001.fm.intel.com with ESMTP; 22 Oct 2021 07:07:28 -0700 From: Ciara Loftus To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Ciara Loftus Date: Fri, 22 Oct 2021 14:07:17 +0000 Message-Id: <20211022140717.11103-1-ciara.loftus@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/af_xdp: set the max Rx pktlen value correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Commit 1bb4a528c41f ("ethdev: fix max Rx packet length") clarified the expected usage of the max_rx_pktlen and max_mtu values and implemented some extra checks on these values to ensure they are sane. After this, the AF_XDP PMD fails to initialise. The value for max_rx_pktlen which represents the max size of the Ethernet frame was set to ETH_FRAME_LEN (1514) and the max_mtu which represents the size of the payload was set to the max size of the Ethernet frame. This did not make sense, as naturally the maximum frame size should be greater than the payload size. Fix this by setting the max_rx_pktlen equal to the max size of the Ethernet frame as expected, and the max MTU equal to the max_rx_pktlen less the overhead which is set to the size of an Ethernet header plus CRC. Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/rte_eth_af_xdp.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index b362ccdcd3..8a3fa19043 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -78,6 +78,7 @@ RTE_LOG_REGISTER_DEFAULT(af_xdp_logtype, NOTICE); #define ETH_AF_XDP_RX_BATCH_SIZE XSK_RING_CONS__DEFAULT_NUM_DESCS #define ETH_AF_XDP_TX_BATCH_SIZE XSK_RING_CONS__DEFAULT_NUM_DESCS +#define ETH_AF_XDP_ETH_OVERHEAD (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN) struct xsk_umem_info { struct xsk_umem *umem; @@ -826,19 +827,19 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->if_index = internals->if_index; dev_info->max_mac_addrs = 1; - dev_info->max_rx_pktlen = ETH_FRAME_LEN; dev_info->max_rx_queues = internals->queue_cnt; dev_info->max_tx_queues = internals->queue_cnt; dev_info->min_mtu = RTE_ETHER_MIN_MTU; #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG) - dev_info->max_mtu = getpagesize() - - sizeof(struct rte_mempool_objhdr) - - sizeof(struct rte_mbuf) - - RTE_PKTMBUF_HEADROOM - XDP_PACKET_HEADROOM; + dev_info->max_rx_pktlen = getpagesize() - + sizeof(struct rte_mempool_objhdr) - + sizeof(struct rte_mbuf) - + RTE_PKTMBUF_HEADROOM - XDP_PACKET_HEADROOM; #else - dev_info->max_mtu = ETH_AF_XDP_FRAME_SIZE - XDP_PACKET_HEADROOM; + dev_info->max_rx_pktlen = ETH_AF_XDP_FRAME_SIZE - XDP_PACKET_HEADROOM; #endif + dev_info->max_mtu = dev_info->max_rx_pktlen - ETH_AF_XDP_ETH_OVERHEAD; dev_info->default_rxportconf.burst_size = ETH_AF_XDP_DFLT_BUSY_BUDGET; dev_info->default_txportconf.burst_size = ETH_AF_XDP_DFLT_BUSY_BUDGET; -- 2.17.1