DPDK patches and discussions
 help / color / mirror / Atom feed
From: Francis Kelly <fkelly@nvidia.com>
To: <tmonjalon@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: <jamhunter@nvidia.com>, <aagbarih@nvidia.com>, <dev@dpdk.org>,
	Ady Agbarih <adypodoman@gmail.com>
Subject: [dpdk-dev] [PATCH 06/10] regex/mlx5: remove start/stop engine API
Date: Fri, 22 Oct 2021 15:45:56 +0000	[thread overview]
Message-ID: <20211022154600.2180938-6-fkelly@nvidia.com> (raw)
In-Reply-To: <20211022154600.2180938-1-fkelly@nvidia.com>

From: Ady Agbarih <adypodoman@gmail.com>

Remove the engine start/stop DevX commands,
as they have been deprecated and moved to FW.

Signed-off-by: Ady Agbarih <adypodoman@gmail.com>
---
 drivers/regex/mlx5/mlx5_regex.c      |  5 ----
 drivers/regex/mlx5/mlx5_regex.h      |  2 --
 drivers/regex/mlx5/mlx5_regex_devx.c | 42 ----------------------------
 3 files changed, 49 deletions(-)

diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c
index f9eb3a2fab..d58851d41d 100644
--- a/drivers/regex/mlx5/mlx5_regex.c
+++ b/drivers/regex/mlx5/mlx5_regex.c
@@ -49,16 +49,11 @@ int
 mlx5_regex_stop(struct rte_regexdev *dev __rte_unused)
 {
 	struct mlx5_regex_priv *priv = dev->data->dev_private;
-	uint32_t i;
 
 	mlx5_regex_clean_ctrl(dev);
 	rte_free(priv->qps);
 	priv->qps = NULL;
 
-	for (i = 0; i < priv->nb_engines; i++)
-		/* Stop engine. */
-		mlx5_devx_regex_database_stop(priv->ctx, i);
-
 	return 0;
 }
 
diff --git a/drivers/regex/mlx5/mlx5_regex.h b/drivers/regex/mlx5/mlx5_regex.h
index 9741421e7a..5c2bda36c9 100644
--- a/drivers/regex/mlx5/mlx5_regex.h
+++ b/drivers/regex/mlx5/mlx5_regex.h
@@ -101,8 +101,6 @@ int mlx5_regex_rules_db_import(struct rte_regexdev *dev,
 			       const char *rule_db, uint32_t rule_db_len);
 
 /* mlx5_regex_devx.c */
-int mlx5_devx_regex_database_stop(void *ctx, uint8_t engine);
-int mlx5_devx_regex_database_resume(void *ctx, uint8_t engine);
 int mlx5_devx_regex_rules_program(void *ctx, uint8_t engine, uint32_t rof_mkey,
 				uint32_t rof_size, uint64_t db_mkey_offset);
 
diff --git a/drivers/regex/mlx5/mlx5_regex_devx.c b/drivers/regex/mlx5/mlx5_regex_devx.c
index 262f301121..a8aa64c325 100644
--- a/drivers/regex/mlx5/mlx5_regex_devx.c
+++ b/drivers/regex/mlx5/mlx5_regex_devx.c
@@ -12,48 +12,6 @@
 #include "mlx5_regex.h"
 #include "mlx5_regex_utils.h"
 
-int
-mlx5_devx_regex_database_stop(void *ctx, uint8_t engine)
-{
-	uint32_t out[MLX5_ST_SZ_DW(set_regexp_params_out)] = {0};
-	uint32_t in[MLX5_ST_SZ_DW(set_regexp_params_in)] = {0};
-	int ret;
-
-	MLX5_SET(set_regexp_params_in, in, opcode, MLX5_CMD_SET_REGEX_PARAMS);
-	MLX5_SET(set_regexp_params_in, in, engine_id, engine);
-	MLX5_SET(set_regexp_params_in, in, regexp_params.stop_engine, 1);
-	MLX5_SET(set_regexp_params_in, in, field_select.stop_engine, 1);
-	ret = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out,
-					  sizeof(out));
-	if (ret) {
-		DRV_LOG(ERR, "Database stop failed %d", ret);
-		rte_errno = errno;
-		return -errno;
-	}
-	return 0;
-}
-
-int
-mlx5_devx_regex_database_resume(void *ctx, uint8_t engine)
-{
-	uint32_t out[MLX5_ST_SZ_DW(set_regexp_params_out)] = {0};
-	uint32_t in[MLX5_ST_SZ_DW(set_regexp_params_in)] = {0};
-	int ret;
-
-	MLX5_SET(set_regexp_params_in, in, opcode, MLX5_CMD_SET_REGEX_PARAMS);
-	MLX5_SET(set_regexp_params_in, in, engine_id, engine);
-	MLX5_SET(set_regexp_params_in, in, regexp_params.stop_engine, 0);
-	MLX5_SET(set_regexp_params_in, in, field_select.stop_engine, 1);
-	ret = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out,
-					  sizeof(out));
-	if (ret) {
-		DRV_LOG(ERR, "Database start failed %d", ret);
-		rte_errno = errno;
-		return -errno;
-	}
-	return 0;
-}
-
 int
 mlx5_devx_regex_rules_program(void *ctx, uint8_t engine, uint32_t rof_mkey,
 				uint32_t rof_size, uint64_t rof_mkey_va)
-- 
2.25.1


  parent reply	other threads:[~2021-10-22 15:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 15:45 [dpdk-dev] [PATCH 01/10] common/mlx5: update PRM definitions for regex availability Francis Kelly
2021-10-22 15:45 ` [dpdk-dev] [PATCH 02/10] regex/mlx5: add cleanup code Francis Kelly
2021-10-22 15:45 ` [dpdk-dev] [PATCH 03/10] common/mlx5: update regex DevX commands Francis Kelly
2021-10-24 13:39   ` Ori Kam
2021-10-22 15:45 ` [dpdk-dev] [PATCH 04/10] regex/mlx5: remove regexp register read/write Francis Kelly
2021-10-24 13:40   ` Ori Kam
2021-10-22 15:45 ` [dpdk-dev] [PATCH 05/10] regex/mlx5: move RXP to CrSpace Francis Kelly
2021-10-24 13:41   ` Ori Kam
2021-10-22 15:45 ` Francis Kelly [this message]
2021-10-22 15:45 ` [dpdk-dev] [PATCH 07/10] regex/mlx5: removed redundant rxp csr file Francis Kelly
2021-10-24 13:42   ` Ori Kam
2021-10-22 15:45 ` [dpdk-dev] [PATCH 08/10] regex/mlx5: fix uninitialized QP destroy Francis Kelly
2021-10-24 13:42   ` Ori Kam
2021-10-22 15:45 ` [dpdk-dev] [PATCH 09/10] regex/mlx5: prevent QP double setup Francis Kelly
2021-10-24 13:43   ` Ori Kam
2021-10-22 15:46 ` [dpdk-dev] [PATCH 10/10] doc: updated release notes and mlx5 file Francis Kelly
2021-10-24 13:43   ` Ori Kam
2021-11-03 22:13     ` Thomas Monjalon
2021-10-24 13:38 ` [dpdk-dev] [PATCH 01/10] common/mlx5: update PRM definitions for regex availability Ori Kam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211022154600.2180938-6-fkelly@nvidia.com \
    --to=fkelly@nvidia.com \
    --cc=aagbarih@nvidia.com \
    --cc=adypodoman@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jamhunter@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=tmonjalon@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).