From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Harman Kalra <hkalra@marvell.com> Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ray Kinsella <mdr@ashroe.eu>, <david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH v5 1/6] eal/interrupts: implement get set APIs Date: Sat, 23 Oct 2021 02:33:45 +0300 Message-ID: <20211023023345.558c5f5c@sovereign> (raw) In-Reply-To: <20211022204934.132186-2-hkalra@marvell.com> 2021-10-23 02:19 (UTC+0530), Harman Kalra: > Prototype/Implement get set APIs for interrupt handle fields. > User wont be able to access any of the interrupt handle fields > directly while should use these get/set APIs to access/manipulate > them. > > Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, > as APIs defined are moved to rte_interrupts.h and epoll specific > definitions are moved to a new header rte_epoll.h. > Later in the series rte_eal_interrupt.h will be removed. > > Signed-off-by: Harman Kalra <hkalra@marvell.com> > Acked-by: Ray Kinsella <mdr@ashroe.eu> Hi Harman, After fixing some comment below feel free to add: Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> > --- > MAINTAINERS | 1 + > lib/eal/common/eal_common_interrupts.c | 421 ++++++++++++++++ > lib/eal/common/meson.build | 1 + > lib/eal/include/meson.build | 1 + > lib/eal/include/rte_eal_interrupts.h | 209 +------- > lib/eal/include/rte_epoll.h | 118 +++++ > lib/eal/include/rte_interrupts.h | 648 ++++++++++++++++++++++++- > lib/eal/version.map | 46 +- > 8 files changed, 1232 insertions(+), 213 deletions(-) > create mode 100644 lib/eal/common/eal_common_interrupts.c > create mode 100644 lib/eal/include/rte_epoll.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 04ea23a04a..d2950400d2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -211,6 +211,7 @@ F: app/test/test_memzone.c > > Interrupt Subsystem > M: Harman Kalra <hkalra@marvell.com> > +F: lib/eal/include/rte_epoll.h > F: lib/eal/*/*interrupts.* > F: app/test/test_interrupts.c > > diff --git a/lib/eal/common/eal_common_interrupts.c b/lib/eal/common/eal_common_interrupts.c > [...] > +int rte_intr_efds_index_get(const struct rte_intr_handle *intr_handle, > + int index) > +{ > + CHECK_VALID_INTR_HANDLE(intr_handle); > + > + if (index >= intr_handle->nb_intr) { > + RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", index, "size" -> "index" > + intr_handle->nb_intr); > + rte_errno = EINVAL; > + goto fail; > + } > + > + return intr_handle->efds[index]; > +fail: > + return -rte_errno; > +} > [...] > +int rte_intr_vec_list_alloc(struct rte_intr_handle *intr_handle, > + const char *name, int size) > +{ > + CHECK_VALID_INTR_HANDLE(intr_handle); > + > + /* Vector list already allocated */ > + if (intr_handle->intr_vec != NULL) > + return 0; What if `size > intr_handle->vec_list_size`? > + > + if (size > intr_handle->nb_intr) { > + RTE_LOG(ERR, EAL, "Invalid size %d, max limit %d\n", size, > + intr_handle->nb_intr); > + rte_errno = ERANGE; > + goto fail; > + } > + > + intr_handle->intr_vec = rte_zmalloc(name, size * sizeof(int), 0); > + if (intr_handle->intr_vec == NULL) { > + RTE_LOG(ERR, EAL, "Failed to allocate %d intr_vec", size); > + rte_errno = ENOMEM; > + goto fail; > + } > + > + intr_handle->vec_list_size = size; > + > + return 0; > +fail: > + return -rte_errno; > +} > [...] > diff --git a/lib/eal/include/rte_interrupts.h b/lib/eal/include/rte_interrupts.h > index cc3bf45d8c..a29232e16a 100644 > --- a/lib/eal/include/rte_interrupts.h > +++ b/lib/eal/include/rte_interrupts.h > @@ -5,8 +5,11 @@ > #ifndef _RTE_INTERRUPTS_H_ > #define _RTE_INTERRUPTS_H_ > > +#include <stdbool.h> > + > #include <rte_common.h> > #include <rte_compat.h> > +#include <rte_epoll.h> > > /** > * @file > @@ -22,6 +25,16 @@ extern "C" { > /** Interrupt handle */ > struct rte_intr_handle; > > +/** Interrupt instance allocation flags > + * @see rte_intr_instance_alloc > + */ > +/** Interrupt instance would not be shared within primary secondary process. */ > +#define RTE_INTR_INSTANCE_F_UNSHARED 0x00000001 > +/** Interrupt instance could be shared within primary secondary process. */ > +#define RTE_INTR_INSTANCE_F_SHARED 0x00000002 Nits: "would not" -> "will not" "could" -> "will be" "within primary secondary process" -> "between primary and secondary processes" You previously suggested PRIVATE instead of UNSHARED, it sounded better, but no strog opinion. > [...] > +/** > + * @internal > + * This API is used to populate interrupt handle with src handler fields. "handler" -> "handle" > + * > + * @param intr_handle > + * Interrupt handle pointer. > + * @param src > + * Source interrupt handle to be cloned. > + * > + * @return > + * - On success, zero. > + * - On failure, a negative value and rte_errno is set. > + */ > +__rte_internal > +int > +rte_intr_instance_copy(struct rte_intr_handle *intr_handle, > + const struct rte_intr_handle *src); > [...] > +/** > + * @internal > + * This API returns the sources from where memory is allocated for interrupt > + * instance. > + * > + * @param intr_handle > + * pointer to the interrupt handle. > + * > + * @return > + * - On success, 1 corresponds to memory allocated via DPDK allocator APIs > + * - On success, 0 corresponds to memory allocated from traditional heap. > + * - On failure, negative value. > + */ > +__rte_internal > +int > +rte_intr_instance_alloc_flag_get(const struct rte_intr_handle *intr_handle); It returns flags passed on allow, so return value type and description is inaccurate. Should be uint32_t and a reference to the flag constants.
next prev parent reply other threads:[~2021-10-22 23:33 UTC|newest] Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-26 14:57 [dpdk-dev] [RFC 0/7] make rte_intr_handle internal Harman Kalra 2021-08-26 14:57 ` [dpdk-dev] [RFC 1/7] eal: interrupt handle API prototypes Harman Kalra 2021-08-31 15:52 ` Kinsella, Ray 2021-08-26 14:57 ` [dpdk-dev] [RFC 2/7] eal/interrupts: implement get set APIs Harman Kalra 2021-08-31 15:53 ` Kinsella, Ray 2021-08-26 14:57 ` [dpdk-dev] [RFC 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra 2021-08-26 14:57 ` [dpdk-dev] [RFC 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra 2021-08-26 14:57 ` [dpdk-dev] [RFC 5/7] drivers: remove direct access to interrupt handle fields Harman Kalra 2021-08-26 14:57 ` [dpdk-dev] [RFC 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra 2021-08-26 14:57 ` [dpdk-dev] [RFC 7/7] eal/alarm: introduce alarm fini routine Harman Kalra 2021-09-03 12:40 ` [dpdk-dev] [PATCH v1 0/7] make rte_intr_handle internal Harman Kalra 2021-09-03 12:40 ` [dpdk-dev] [PATCH v1 1/7] eal: interrupt handle API prototypes Harman Kalra 2021-09-03 12:40 ` [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement get set APIs Harman Kalra 2021-09-28 15:46 ` David Marchand 2021-10-04 8:51 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-04 9:57 ` David Marchand 2021-10-12 15:22 ` Thomas Monjalon 2021-10-13 17:54 ` Harman Kalra 2021-10-13 17:57 ` Harman Kalra 2021-10-13 18:52 ` Thomas Monjalon 2021-10-14 8:22 ` Thomas Monjalon 2021-10-14 9:31 ` Harman Kalra 2021-10-14 9:37 ` David Marchand 2021-10-14 9:41 ` Thomas Monjalon 2021-10-14 10:31 ` Harman Kalra 2021-10-14 10:35 ` Thomas Monjalon 2021-10-14 10:44 ` Harman Kalra 2021-10-14 12:04 ` Thomas Monjalon 2021-10-14 10:25 ` Dmitry Kozlyuk 2021-10-03 18:05 ` [dpdk-dev] " Dmitry Kozlyuk 2021-10-04 10:37 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-04 11:18 ` Dmitry Kozlyuk 2021-10-04 14:03 ` Harman Kalra 2021-09-03 12:40 ` [dpdk-dev] [PATCH v1 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra 2021-09-03 12:40 ` [dpdk-dev] [PATCH v1 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra 2021-09-03 12:41 ` [dpdk-dev] [PATCH v1 5/7] drivers: remove direct access to interrupt handle fields Harman Kalra 2021-09-03 12:41 ` [dpdk-dev] [PATCH v1 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra 2021-10-03 18:16 ` Dmitry Kozlyuk 2021-10-04 14:09 ` [dpdk-dev] [EXT] " Harman Kalra 2021-09-03 12:41 ` [dpdk-dev] [PATCH v1 7/7] eal/alarm: introduce alarm fini routine Harman Kalra 2021-09-15 14:13 ` [dpdk-dev] [PATCH v1 0/7] make rte_intr_handle internal Harman Kalra 2021-09-23 8:20 ` David Marchand 2021-10-05 12:14 ` [dpdk-dev] [PATCH v2 0/6] " Harman Kalra 2021-10-05 12:14 ` [dpdk-dev] [PATCH v2 1/6] eal/interrupts: implement get set APIs Harman Kalra 2021-10-14 0:58 ` Dmitry Kozlyuk 2021-10-14 17:15 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-14 17:53 ` Dmitry Kozlyuk 2021-10-15 7:53 ` Thomas Monjalon 2021-10-14 7:31 ` [dpdk-dev] " David Marchand 2021-10-05 12:14 ` [dpdk-dev] [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle Harman Kalra 2021-10-14 0:59 ` Dmitry Kozlyuk 2021-10-14 17:31 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-14 17:53 ` Dmitry Kozlyuk 2021-10-05 12:14 ` [dpdk-dev] [PATCH v2 3/6] test/interrupt: apply get set interrupt handle APIs Harman Kalra 2021-10-05 12:15 ` [dpdk-dev] [PATCH v2 4/6] drivers: remove direct access to interrupt handle Harman Kalra 2021-10-05 12:15 ` [dpdk-dev] [PATCH v2 5/6] eal/interrupts: make interrupt handle structure opaque Harman Kalra 2021-10-05 12:15 ` [dpdk-dev] [PATCH v2 6/6] eal/alarm: introduce alarm fini routine Harman Kalra 2021-10-05 16:07 ` [dpdk-dev] [RFC 0/7] make rte_intr_handle internal Stephen Hemminger 2021-10-07 10:57 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 " Harman Kalra 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 1/7] malloc: introduce malloc is ready API Harman Kalra 2021-10-19 15:53 ` Thomas Monjalon 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 2/7] eal/interrupts: implement get set APIs Harman Kalra 2021-10-18 22:07 ` Dmitry Kozlyuk 2021-10-19 8:50 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-19 18:44 ` Harman Kalra 2021-10-18 22:56 ` [dpdk-dev] " Stephen Hemminger 2021-10-19 8:32 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-19 15:58 ` Thomas Monjalon 2021-10-20 15:30 ` Dmitry Kozlyuk 2021-10-21 9:16 ` Harman Kalra 2021-10-21 12:33 ` Dmitry Kozlyuk 2021-10-21 13:32 ` David Marchand 2021-10-21 16:05 ` Harman Kalra 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 5/7] drivers: remove direct access to interrupt handle Harman Kalra 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra 2021-10-18 19:37 ` [dpdk-dev] [PATCH v3 7/7] eal/alarm: introduce alarm fini routine Harman Kalra 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 0/7] make rte_intr_handle internal Harman Kalra 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 1/7] malloc: introduce malloc is ready API Harman Kalra 2021-10-19 22:01 ` Dmitry Kozlyuk 2021-10-19 22:04 ` Dmitry Kozlyuk 2021-10-20 9:01 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 2/7] eal/interrupts: implement get set APIs Harman Kalra 2021-10-20 6:14 ` David Marchand 2021-10-20 14:29 ` Dmitry Kozlyuk 2021-10-20 16:15 ` Dmitry Kozlyuk 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 3/7] eal/interrupts: avoid direct access to interrupt handle Harman Kalra 2021-10-19 21:27 ` Dmitry Kozlyuk 2021-10-20 9:25 ` [dpdk-dev] [EXT] " Harman Kalra 2021-10-20 9:52 ` Dmitry Kozlyuk 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 4/7] test/interrupt: apply get set interrupt handle APIs Harman Kalra 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 5/7] drivers: remove direct access to interrupt handle Harman Kalra 2021-10-20 1:57 ` Hyong Youb Kim (hyonkim) 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 6/7] eal/interrupts: make interrupt handle structure opaque Harman Kalra 2021-10-19 18:35 ` [dpdk-dev] [PATCH v4 7/7] eal/alarm: introduce alarm fini routine Harman Kalra 2021-10-19 21:39 ` Dmitry Kozlyuk 2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 0/6] make rte_intr_handle internal Harman Kalra 2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 1/6] eal/interrupts: implement get set APIs Harman Kalra 2021-10-22 23:33 ` Dmitry Kozlyuk [this message] 2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 2/6] eal/interrupts: avoid direct access to interrupt handle Harman Kalra 2021-10-22 23:33 ` Dmitry Kozlyuk 2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 3/6] test/interrupt: apply get set interrupt handle APIs Harman Kalra 2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 4/6] drivers: remove direct access to interrupt handle Harman Kalra 2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 5/6] eal/interrupts: make interrupt handle structure opaque Harman Kalra 2021-10-22 23:33 ` Dmitry Kozlyuk 2021-10-22 20:49 ` [dpdk-dev] [PATCH v5 6/6] eal/alarm: introduce alarm fini routine Harman Kalra 2021-10-22 23:33 ` Dmitry Kozlyuk 2021-10-22 23:37 ` Dmitry Kozlyuk 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 0/9] make rte_intr_handle internal David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 1/9] interrupts: add allocator and accessors David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 2/9] interrupts: remove direct access to interrupt handle David Marchand 2021-10-25 6:57 ` David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 3/9] test/interrupts: " David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 4/9] alarm: " David Marchand 2021-10-25 10:49 ` Dmitry Kozlyuk 2021-10-25 11:09 ` David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 5/9] lib: " David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 6/9] drivers: " David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 7/9] interrupts: make interrupt handle structure opaque David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 8/9] interrupts: rename device specific file descriptor David Marchand 2021-10-24 20:04 ` [dpdk-dev] [PATCH v6 9/9] interrupts: extend event list David Marchand 2021-10-25 10:49 ` Dmitry Kozlyuk 2021-10-25 11:11 ` David Marchand 2021-10-25 13:04 ` [dpdk-dev] [PATCH v5 0/6] make rte_intr_handle internal Raslan Darawsheh 2021-10-25 13:09 ` David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 0/9] " David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 1/9] interrupts: add allocator and accessors David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 2/9] interrupts: remove direct access to interrupt handle David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 3/9] test/interrupts: " David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 4/9] alarm: " David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 5/9] lib: " David Marchand 2021-10-28 6:14 ` Jiang, YuX 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 6/9] drivers: " David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 7/9] interrupts: make interrupt handle structure opaque David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 8/9] interrupts: rename device specific file descriptor David Marchand 2021-10-25 13:34 ` [dpdk-dev] [PATCH v7 9/9] interrupts: extend event list David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 0/9] make rte_intr_handle internal David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 1/9] interrupts: add allocator and accessors David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 2/9] interrupts: remove direct access to interrupt handle David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 3/9] test/interrupts: " David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 4/9] alarm: " David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 5/9] lib: " David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 6/9] drivers: " David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 7/9] interrupts: make interrupt handle structure opaque David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 8/9] interrupts: rename device specific file descriptor David Marchand 2021-10-25 14:27 ` [dpdk-dev] [PATCH v8 9/9] interrupts: extend event list David Marchand 2021-10-28 15:58 ` Ji, Kai 2021-10-28 17:16 ` David Marchand 2021-10-25 14:32 ` [dpdk-dev] [PATCH v8 0/9] make rte_intr_handle internal Raslan Darawsheh 2021-10-25 19:24 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211023023345.558c5f5c@sovereign \ --to=dmitry.kozliuk@gmail.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=hkalra@marvell.com \ --cc=mdr@ashroe.eu \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git