From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01FA9A0C4E; Sat, 23 Oct 2021 10:37:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 917D64069D; Sat, 23 Oct 2021 10:37:59 +0200 (CEST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id F17E440041 for ; Sat, 23 Oct 2021 10:37:58 +0200 (CEST) Received: by mail-lf1-f42.google.com with SMTP id i6so5558708lfv.9 for ; Sat, 23 Oct 2021 01:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SPDyMnA0/K9s19sC/TtKG/G/kO03MNoUzCt0J9PDpec=; b=VoXhqN68NfHQnVfYeGiN5TUYmsFC4yydv8uLrTzXyxRqiCUZntF2vYgyYhigXYG15i DQhgbByXHO9zpA3mgnyv0Ydk1aUw1xChIxyekepkrU86ZHtU9fhMX5UcBaRjuio9ItXe 3EWJoP9on2tceLMopciUG05wzO9uob33HHnhdg+N7hptoJct0X0sAKLcDlL4oYjjeakP oqp6WmFcuPP3Riw4BKdZGQKWlaU0WbKYyhbnumHN8XaL9sDKxU8/G7Tmm5hmSgxUnEZB 4NIv1f4bYjOKmqaxGW5E8ynhi1lmGxcgf3TVJl+uf2PfOYO5vRT9cO64iEIGQ5q3i/wK XCgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SPDyMnA0/K9s19sC/TtKG/G/kO03MNoUzCt0J9PDpec=; b=w6ouLQLa0m/YAZ6vGtvvQyoE5JFRNqaRkxvexhNHIym/5SAX/Z3O+5dWYHMkmqmNwi PMNd8z0JHY+gfv6xJVMGCZ79siaRRZmVrzBw0bPThMh4LFxJ8xC4q9En8gxwKhufWqIo CJH7tkECw+U76hGe0/ZeMiwyABsMvDD6c3x8iAFUnLXWT7nB1TG0CmKcdw3wHdDdVDD8 5rk9FKJxKpqxQM4GEAEa9SosSWGLO2y+L6qQ6lr1gvpbmDwp/S0wsQt+qXPe1d2dppwR FfH5C9BlXTMGHq1IabEvFqdztIqwTMLETO3sIRfiPmKnprxUkjpl+17E5rs67sJDmwza MR4g== X-Gm-Message-State: AOAM530U7Hx/5n2fwKtMo6dbo+PUOmYJJSq5gcU3AGm6+N5ljB4SGjc2 TdEAoJLPoIfFCho1sVzSFJU= X-Google-Smtp-Source: ABdhPJykIbRdr8FYcchPxjdKdgWtSYDvJvF9NsMeYQ0rz3KRBq91PA5T/m69/kzNBvjARASB2RCeQQ== X-Received: by 2002:a05:6512:3107:: with SMTP id n7mr4780289lfb.179.1634978278478; Sat, 23 Oct 2021 01:37:58 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id q10sm959820lfe.294.2021.10.23.01.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 01:37:58 -0700 (PDT) Date: Sat, 23 Oct 2021 11:37:57 +0300 From: Dmitry Kozlyuk To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, Bruce Richardson , Kevin Laatz , Chengwen Feng , Conor Walsh Message-ID: <20211023113757.728b2e32@sovereign> In-Reply-To: <20211023065558.818-1-david.marchand@redhat.com> References: <20211023065558.818-1-david.marchand@redhat.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-10-23 08:55 (UTC+0200), David Marchand: > Windows compilation gives us a splat: > In file included from ../drivers/dma/idxd/idxd_pci.c:10: > In file included from ..\drivers\dma\idxd/idxd_internal.h:11: > ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or > ';' after declaration specifiers > uint16_t __reserved[13]; > ~~~~~~~~ ^ > 1 error generated. > > Ironically, __reserved is probably a reserved token. Yes, and it's used in system headers for static analyzer annotations: https://docs.microsoft.com/en-us/windows/win32/winprog/header-annotations#advanced-annotations > Some drivers that build fine on Windows have structs with a "reserved" > field, let's go with this. > > Fixes: 82147042d062 ("dma/idxd: add datapath structures") > > Signed-off-by: David Marchand > --- > drivers/dma/idxd/idxd_hw_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/idxd/idxd_hw_defs.h b/drivers/dma/idxd/idxd_hw_defs.h > index 55ca9f7f52..2a219c1312 100644 > --- a/drivers/dma/idxd/idxd_hw_defs.h > +++ b/drivers/dma/idxd/idxd_hw_defs.h > @@ -43,7 +43,7 @@ struct idxd_hw_desc { > uint16_t intr_handle; /* completion interrupt handle */ > > /* remaining 26 bytes are reserved */ > - uint16_t __reserved[13]; > + uint16_t reserved[13]; > } __rte_aligned(64); > > #define IDXD_COMP_STATUS_INCOMPLETE 0