From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header
Date: Mon, 25 Oct 2021 00:58:57 +0300 [thread overview]
Message-ID: <20211025005857.15a19b6d@sovereign> (raw)
In-Reply-To: <1987625.VQ3m8ipJx8@thomas>
2021-10-11 21:07 (UTC+0200), Thomas Monjalon:
> 01/10/2021 18:37, Dmitry Kozlyuk:
> > The header was not intended to be a public one.
> > DPDK users should use `rte_mem_virt2iova()` to translate addresses.
> > Other virt2phys users should use the header from the driver instead.
> >
> > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> > headers += files(
> > 'rte_os.h',
> > - 'rte_virt2phys.h',
> > 'rte_windows.h',
> > )
>
> We should plan to rename it.
> Files starting with rte_ are supposed to be public.
Is "rte_eal_" prefix OK for internal headers, like in "rte_eal_paging.h"?
I want to put NetUIO interface to EAL, but also to use it from bus/pci.
next prev parent reply other threads:[~2021-10-24 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 16:37 [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
2021-10-11 19:07 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-10-24 21:58 ` Dmitry Kozlyuk [this message]
2021-10-01 16:37 ` [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
2021-10-01 16:39 ` Bruce Richardson
2021-10-11 19:10 ` [dpdk-dev] [PATCH 0/2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025005857.15a19b6d@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).