DPDK patches and discussions
 help / color / mirror / Atom feed
From: dapengx.yu@intel.com
To: Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, Dapeng Yu <dapengx.yu@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/ice: change RTE log level to DEBUG
Date: Tue, 26 Oct 2021 16:49:38 +0800	[thread overview]
Message-ID: <20211026084938.1684619-1-dapengx.yu@intel.com> (raw)

From: Dapeng Yu <dapengx.yu@intel.com>

When VF is reset in high frequency, the AdminQ command may fail, but
the failure can be recovered actually. So the error messages for getting
VF resource, getting VSI map, and re-directing flows should be
suppressed, in order to avoid causing concern for DCF users.

Fixes: 7564d5509611 ("net/ice: add DCF hardware initialization")
Cc: stable@dpdk.org

Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
---
 drivers/net/ice/ice_dcf.c           | 8 ++++----
 drivers/net/ice/ice_generic_flow.c  | 2 +-
 drivers/net/ice/ice_switch_filter.c | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 084f7a53db..9a53ba3538 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -241,7 +241,7 @@ ice_dcf_get_vf_resource(struct ice_dcf_hw *hw)
 	err = ice_dcf_send_cmd_req_no_irq(hw, VIRTCHNL_OP_GET_VF_RESOURCES,
 					  (uint8_t *)&caps, sizeof(caps));
 	if (err) {
-		PMD_DRV_LOG(ERR, "Failed to send msg OP_GET_VF_RESOURCE");
+		PMD_DRV_LOG(DEBUG, "Failed to send msg OP_GET_VF_RESOURCE");
 		return err;
 	}
 
@@ -249,7 +249,7 @@ ice_dcf_get_vf_resource(struct ice_dcf_hw *hw)
 					  (uint8_t *)hw->vf_res,
 					  ICE_DCF_VF_RES_BUF_SZ, NULL);
 	if (err) {
-		PMD_DRV_LOG(ERR, "Failed to get response of OP_GET_VF_RESOURCE");
+		PMD_DRV_LOG(DEBUG, "Failed to get response of OP_GET_VF_RESOURCE");
 		return -1;
 	}
 
@@ -283,7 +283,7 @@ ice_dcf_get_vf_vsi_map(struct ice_dcf_hw *hw)
 	err = ice_dcf_send_cmd_req_no_irq(hw, VIRTCHNL_OP_DCF_GET_VSI_MAP,
 					  NULL, 0);
 	if (err) {
-		PMD_DRV_LOG(ERR, "Failed to send msg OP_DCF_GET_VSI_MAP");
+		PMD_DRV_LOG(DEBUG, "Failed to send msg OP_DCF_GET_VSI_MAP");
 		return err;
 	}
 
@@ -291,7 +291,7 @@ ice_dcf_get_vf_vsi_map(struct ice_dcf_hw *hw)
 					  hw->arq_buf, ICE_DCF_AQ_BUF_SZ,
 					  &len);
 	if (err) {
-		PMD_DRV_LOG(ERR, "Failed to get response of OP_DCF_GET_VSI_MAP");
+		PMD_DRV_LOG(DEBUG, "Failed to get response of OP_DCF_GET_VSI_MAP");
 		return err;
 	}
 
diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index 02f854666a..4aca24de89 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -2551,7 +2551,7 @@ ice_flow_redirect(struct ice_adapter *ad,
 			continue;
 		ret = p_flow->engine->redirect(ad, p_flow, rd);
 		if (ret) {
-			PMD_DRV_LOG(ERR, "Failed to redirect flows");
+			PMD_DRV_LOG(DEBUG, "Failed to redirect flows");
 			break;
 		}
 	}
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 6b0c1bff1e..b4f3bbafff 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1943,7 +1943,7 @@ ice_switch_redirect(struct ice_adapter *ad,
 	ret = ice_rem_adv_rule(hw, list_itr->lkups,
 			       lkups_cnt, &rinfo);
 	if (ret) {
-		PMD_DRV_LOG(ERR, "Failed to delete the old rule %d",
+		PMD_DRV_LOG(DEBUG, "Failed to delete the old rule %d",
 			    rdata->rule_id);
 		ret = -EINVAL;
 		goto out;
@@ -1956,7 +1956,7 @@ ice_switch_redirect(struct ice_adapter *ad,
 	ret = ice_add_adv_rule(hw, lkups_dp, lkups_cnt,
 			       &rinfo, rdata);
 	if (ret) {
-		PMD_DRV_LOG(ERR, "Failed to replay the rule");
+		PMD_DRV_LOG(DEBUG, "Failed to replay the rule");
 		ret = -EINVAL;
 	}
 
-- 
2.27.0


                 reply	other threads:[~2021-10-26  8:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026084938.1684619-1-dapengx.yu@intel.com \
    --to=dapengx.yu@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).