From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57AEDA0C47; Tue, 26 Oct 2021 13:20:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B2BD40E0F; Tue, 26 Oct 2021 13:20:01 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 129AB406B4; Tue, 26 Oct 2021 13:19:58 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10148"; a="229827080" X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="229827080" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 04:19:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,182,1631602800"; d="scan'208";a="486142895" Received: from sivswdev08.ir.intel.com ([10.237.217.47]) by orsmga007.jf.intel.com with ESMTP; 26 Oct 2021 04:19:56 -0700 From: Konstantin Ananyev To: dev@dpdk.org Cc: david.marchand@redhat.com, reshma.pattan@intel.com, Konstantin Ananyev , stable@dpdk.org Date: Tue, 26 Oct 2021 12:19:43 +0100 Message-Id: <20211026111943.19957-1-konstantin.ananyev@intel.com> X-Mailer: git-send-email 2.18.0 Subject: [dpdk-dev] [PATCH] test: fix forwarding packets through not-ready port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" (bitratestats_autotest|latencystats_autotest|pdump_autotest) tests generate a log of error messages like that: test_packet_forward() line 104: Error sending packet to port 0 Send pkts Failed These tests use of app/test/sample_packet_forward.* code. This code creates a portid from a ring, but doesn't properly configure/start it. The fix adds code to configure/start given port before usage. Fixes: 7a0935239b9e ("ethdev: make fast-path functions to use new flat array") Fixes: a52966cd48fd ("test: add helpers using ring PMD Rx/Tx") Cc: stable@dpdk.org Reported-by: David Marchand Signed-off-by: Konstantin Ananyev --- app/test/sample_packet_forward.c | 29 +++++++++++++++++++++++++++++ app/test/sample_packet_forward.h | 3 +++ app/test/test_bitratestats.c | 12 +++++++++++- app/test/test_latencystats.c | 12 +++++++++++- app/test/test_pdump.c | 12 ++++++++++-- 5 files changed, 64 insertions(+), 4 deletions(-) diff --git a/app/test/sample_packet_forward.c b/app/test/sample_packet_forward.c index 61384b3d9b..aa897274d8 100644 --- a/app/test/sample_packet_forward.c +++ b/app/test/sample_packet_forward.c @@ -15,6 +15,35 @@ #include "sample_packet_forward.h" +/* + * heper function: configure and start test device + */ +int +test_dev_start(uint16_t port, struct rte_mempool *mp) +{ + int32_t rc; + struct rte_eth_conf pconf; + + memset(&pconf, 0, sizeof(pconf)); + + rc = rte_eth_dev_configure(port, NUM_QUEUES, NUM_QUEUES, &pconf); + if (rc != 0) + return rc; + + rc = rte_eth_rx_queue_setup(port, 0, RING_SIZE, SOCKET_ID_ANY, + NULL, mp); + if (rc != 0) + return rc; + + rc = rte_eth_tx_queue_setup(port, 0, RING_SIZE, SOCKET_ID_ANY, + NULL); + if (rc != 0) + return rc; + + rc = rte_eth_dev_start(port); + return rc; +} + /* Sample test to create virtual rings and tx,rx portid from rings */ int test_ring_setup(struct rte_ring **ring, uint16_t *portid) diff --git a/app/test/sample_packet_forward.h b/app/test/sample_packet_forward.h index 6789217de3..af0b1d9924 100644 --- a/app/test/sample_packet_forward.h +++ b/app/test/sample_packet_forward.h @@ -21,6 +21,9 @@ struct rte_ring; /* Sample test to create virtual rings and tx,rx portid from rings */ int test_ring_setup(struct rte_ring **ring, uint16_t *portid); +/* configure and start device created by test_ring_setup */ +int test_dev_start(uint16_t port, struct rte_mempool *mp); + /* Sample test to free the virtual rings */ void test_ring_free(struct rte_ring *rxtx); diff --git a/app/test/test_bitratestats.c b/app/test/test_bitratestats.c index f4a92c9be6..1ff540f4c4 100644 --- a/app/test/test_bitratestats.c +++ b/app/test/test_bitratestats.c @@ -11,6 +11,7 @@ #include #include #include +#include #include "sample_packet_forward.h" #include "test.h" @@ -159,12 +160,21 @@ test_bit_packet_forward(void) printf("allocate mbuf pool Failed\n"); return TEST_FAILED; } + ret = test_dev_start(portid, mp); + if (ret < 0) { + printf("test_dev_start(%hu, %p) failed, error code: %d\n", + portid, mp, ret); + return TEST_FAILED; + } + ret = test_packet_forward(pbuf, portid, QUEUE_ID); if (ret < 0) printf("send pkts Failed\n"); + + rte_eth_dev_stop(portid); test_put_mbuf_to_pool(mp, pbuf); - return TEST_SUCCESS; + return (ret >= 0) ? TEST_SUCCESS : TEST_FAILED; } static int diff --git a/app/test/test_latencystats.c b/app/test/test_latencystats.c index 724acbc315..db06c7d5c7 100644 --- a/app/test/test_latencystats.c +++ b/app/test/test_latencystats.c @@ -6,6 +6,7 @@ #include #include +#include #include #include "rte_lcore.h" #include "rte_metrics.h" @@ -158,12 +159,21 @@ static int test_latency_packet_forward(void) printf("allocate mbuf pool Failed\n"); return TEST_FAILED; } + ret = test_dev_start(portid, mp); + if (ret < 0) { + printf("test_dev_start(%hu, %p) failed, error code: %d\n", + portid, mp, ret); + return TEST_FAILED; + } + ret = test_packet_forward(pbuf, portid, QUEUE_ID); if (ret < 0) printf("send pkts Failed\n"); + + rte_eth_dev_stop(portid); test_put_mbuf_to_pool(mp, pbuf); - return TEST_SUCCESS; + return (ret >= 0) ? TEST_SUCCESS : TEST_FAILED; } static struct diff --git a/app/test/test_pdump.c b/app/test/test_pdump.c index b49fcfb3f1..ea03056b47 100644 --- a/app/test/test_pdump.c +++ b/app/test/test_pdump.c @@ -147,11 +147,19 @@ send_pkts(void *empty) ret = test_get_mbuf_from_pool(&mp, pbuf, poolname); if (ret < 0) printf("get_mbuf_from_pool failed\n"); - do { + + ret = test_dev_start(portid, mp); + if (ret < 0) + printf("test_dev_start(%hu, %p) failed, error code: %d\n", + portid, mp, ret); + + while (ret >= 0 && flag_for_send_pkts) { ret = test_packet_forward(pbuf, portid, QUEUE_ID); if (ret < 0) printf("send pkts Failed\n"); - } while (flag_for_send_pkts); + }; + + rte_eth_dev_stop(portid); test_put_mbuf_to_pool(mp, pbuf); return empty; } -- 2.26.3