From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67CB0A0547; Tue, 26 Oct 2021 21:57:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD11740E0F; Tue, 26 Oct 2021 21:57:43 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id E8B20407FF for ; Tue, 26 Oct 2021 21:57:42 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id 127so515947pfu.1 for ; Tue, 26 Oct 2021 12:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vUbd65Xi0k8Jg2LpYfnzyjbLBclcJ5PiLbMD4G6nXDw=; b=T3KqN0+lftvKddirrM+Wuc+6U3tnSWwCi8mVNeMaJUKmyPzhGX+FgL/6sYaSaUEXRS Hzhb7l3iFrgs5Uc9nS83v+XlEhPPNhLUDmUZsauvx7VjC5uFq18Lk92pLs8gV5Z9HPVD /l+NK4qbBW6t0wbNc3JAd4XpMgEhg/RxuDnHT41gLnHvJe3hqIjwkyvFNekaIgVL1VHR cYr0tE8kCtcifkFHfuYhlti+tCSkhezL4xVyjWW6vchyGF5BYP/ZiJ7+UcDM0K/kWLbk WWbxwuNTYRBNGUPme0aXa+IkM7US25lSY54CGumrtlelEMFFRdOI9L/8AAv558dREg88 MGGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vUbd65Xi0k8Jg2LpYfnzyjbLBclcJ5PiLbMD4G6nXDw=; b=p6wvFOAuS/1mRJkzzKFI1PBIHgoQ036knHooItAb/UuGiMwg/AtS6ILrvz4hbhMjFX Tf6TxCUsKsLAhKrPTSaEKfUOIimyrqVTD7OojURp4LW64zw6B1xqCFYb6lkkTRjaK8Ll ClChQ+f5b33bHnf2AfOaVPudDcypqp1B/LdiDCny0gfHSG6TFPfwVCJWkT6sqynzx73n 1YXevzztIA6GSv4Dpi9WP3ucV+TIjx6unIkHY3QIBV4ygJpHC3t6NktmBbdGjjQ5ZYKt 0Kh+oPqaAguuywbHpzYHF/bXv1wTBH6YCuxhMJEA8fbXQZNt5L0faRml3RCjIvM9bU1h LJbQ== X-Gm-Message-State: AOAM533kv5FyGxzGOvUtrV1vyuvcy5dv8FvQ6pZanRoYVpbyuLNECZjU L9LO2f2aFu9Q3ct5ALEKwylimA== X-Google-Smtp-Source: ABdhPJzey5LYH+tU/Cc6FY2YGS1QUTphgHDtcNSio7guEWOEgP30/4eOf4LCHictqvXaRCA4r0DMNQ== X-Received: by 2002:a05:6a00:b48:b0:47c:23e:ecb7 with SMTP id p8-20020a056a000b4800b0047c023eecb7mr10933510pfo.42.1635278261975; Tue, 26 Oct 2021 12:57:41 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id z2sm2009983pfh.135.2021.10.26.12.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 12:57:41 -0700 (PDT) Date: Tue, 26 Oct 2021 12:57:38 -0700 From: Stephen Hemminger To: Konstantin Ananyev Cc: dev@dpdk.org, reshma.pattan@intel.com Message-ID: <20211026125738.69f70afb@hermes.local> In-Reply-To: <20211026115301.5456-1-konstantin.ananyev@intel.com> References: <20211026115301.5456-1-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 26 Oct 2021 12:53:01 +0100 Konstantin Ananyev wrote: > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c > index 71602685d5..a708935861 100644 > --- a/lib/pdump/rte_pdump.c > +++ b/lib/pdump/rte_pdump.c > @@ -74,6 +74,7 @@ static const char MZ_RTE_PDUMP_STATS[] = "rte_pdump_stats"; > static struct { > struct rte_pdump_stats rx[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT]; > struct rte_pdump_stats tx[RTE_MAX_ETHPORTS][RTE_MAX_QUEUES_PER_PORT]; > + const struct rte_memzone *mz; > } *pdump_stats; Thanks for fixing. Acked-by: Stephen Hemminger