* [dpdk-dev] [PATCH] pdump: initialize snaplen if enabled by device id
[not found] <bug-840-3@http.bugs.dpdk.org>
@ 2021-10-27 18:08 ` Stephen Hemminger
2021-10-28 17:21 ` Stephen Hemminger
2021-10-31 23:39 ` Thomas Monjalon
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2021-10-27 18:08 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
If packet dump was enabled via pdump_enable_by_deviceid
the packet snapshot length was not being set.
Bugzilla ID: 840
Fixes: 10f726efe26c ("pdump: support pcapng and filtering")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/pdump/rte_pdump.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 71602685d544..3086b2a1688b 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -631,6 +631,9 @@ pdump_enable_by_deviceid(const char *device_id, uint16_t queue,
if (ret < 0)
return ret;
+ if (snaplen == 0)
+ snaplen = UINT32_MAX;
+
return pdump_prepare_client_request(device_id, queue, flags, snaplen,
ENABLE, ring, mp, prm);
}
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] pdump: initialize snaplen if enabled by device id
2021-10-27 18:08 ` [dpdk-dev] [PATCH] pdump: initialize snaplen if enabled by device id Stephen Hemminger
@ 2021-10-28 17:21 ` Stephen Hemminger
2021-10-31 23:39 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2021-10-28 17:21 UTC (permalink / raw)
To: dev
On Wed, 27 Oct 2021 11:08:47 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:
> If packet dump was enabled via pdump_enable_by_deviceid
> the packet snapshot length was not being set.
>
> Bugzilla ID: 840
> Fixes: 10f726efe26c ("pdump: support pcapng and filtering")
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/pdump/rte_pdump.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
> index 71602685d544..3086b2a1688b 100644
> --- a/lib/pdump/rte_pdump.c
> +++ b/lib/pdump/rte_pdump.c
> @@ -631,6 +631,9 @@ pdump_enable_by_deviceid(const char *device_id, uint16_t queue,
> if (ret < 0)
> return ret;
>
> + if (snaplen == 0)
> + snaplen = UINT32_MAX;
> +
> return pdump_prepare_client_request(device_id, queue, flags, snaplen,
> ENABLE, ring, mp, prm);
> }
There appears to be bug in the CI system reporting bogus failure on
this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] pdump: initialize snaplen if enabled by device id
2021-10-27 18:08 ` [dpdk-dev] [PATCH] pdump: initialize snaplen if enabled by device id Stephen Hemminger
2021-10-28 17:21 ` Stephen Hemminger
@ 2021-10-31 23:39 ` Thomas Monjalon
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-10-31 23:39 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
27/10/2021 20:08, Stephen Hemminger:
> If packet dump was enabled via pdump_enable_by_deviceid
> the packet snapshot length was not being set.
>
> Bugzilla ID: 840
> Fixes: 10f726efe26c ("pdump: support pcapng and filtering")
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-31 23:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-840-3@http.bugs.dpdk.org>
2021-10-27 18:08 ` [dpdk-dev] [PATCH] pdump: initialize snaplen if enabled by device id Stephen Hemminger
2021-10-28 17:21 ` Stephen Hemminger
2021-10-31 23:39 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).