From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9508A0032; Fri, 29 Oct 2021 21:55:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81AA240DDB; Fri, 29 Oct 2021 21:55:29 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 1BFD640688 for ; Fri, 29 Oct 2021 21:55:28 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id v20so7493401plo.7 for ; Fri, 29 Oct 2021 12:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vaNYCAmVMW8Q5anRnZ8w/hPpU62IYzMzmhXAQGQs+6o=; b=vnurppF3egFHz6Gky0/FmSgwbMl5apDJ8wrDalbuzsyYScnBrAeElk413AyU6B+arP HyyRtsmt5k8Jy/1+ecynbZZ8xfY8RkEqbi3KrJYJKdJTS9m0nKKdQH5PqdIA0kSLcOSE riMI7xCQJBh9XGdHFZ8J+6h5tcAlmTgZIsBE0AK2K1An2C4hMemHRY1s9lWNj13Ilj2f 8Z8tF6G8+I+e/PbVh1UlYh5W12x5R6hSDACZ3hVMctGQvI2zaRfpy5YznYLvWOKH8t3y xi7dxQ/zskKX6tZqHl7WAxf5UKq5dfK2eiIf0Su656SEuYsX/0xnI8cM1AMEBmtQ8Jsm SECQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vaNYCAmVMW8Q5anRnZ8w/hPpU62IYzMzmhXAQGQs+6o=; b=nynGKghShCugTQC6Nh1oSpsZQVFexlYsvbgGy6NKr+PuYm2hSn4X2CjswjYzhG5ja0 rOThjQ/Jnp9JQe8XGO3RhkCKIn8VzTzEuEG2r6PkYmFWNWkAup8X7rBy5ScOgyNRi/xX ajSeTUrn38cdo1rpkvEWPxS4SUPhL+JbHKNFS0HmK3p8kQZVMkFswNnb5kW4O21x9Ltf HBMHCuBZo1c0NJnq/xgsY16Roe5WA/NZQhNakBJiPEXMhLcF+VzPO1UN8lIsNycVY0x/ UWWjXHX51dCp8PP46dcZJzXC9scY0cumWgAiL+Um7q3TnwZ+A94QVILVx2ljAG523v6p lWqQ== X-Gm-Message-State: AOAM5311jRiNuSQaLnI7h/Nl6o1ihrnySZ4yfkgGfaCA3ubRClmb5yqZ uHPzVKKrlKO+9ofbTjVbuv/GTsyBRbKVcQ== X-Google-Smtp-Source: ABdhPJwMGOefivD4rne5pxLf0JOMtua48tfJJe9+R4TAaOa7voGDth6j0bLb/9sASut5x1aEYMHLGw== X-Received: by 2002:a17:903:120c:b0:13f:d043:3477 with SMTP id l12-20020a170903120c00b0013fd0433477mr11409429plh.89.1635537327272; Fri, 29 Oct 2021 12:55:27 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id np17sm12081475pjb.7.2021.10.29.12.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 12:55:26 -0700 (PDT) Date: Fri, 29 Oct 2021 12:55:24 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: , Reshma Pattan , Ray Kinsella Message-ID: <20211029125524.7294dd51@hermes.local> In-Reply-To: <2bdfc985-1011-d866-7e89-32baf8f1669b@intel.com> References: <20210903004732.109023-1-stephen@networkplumber.org> <20211020214236.71444-1-stephen@networkplumber.org> <20211020214236.71444-3-stephen@networkplumber.org> <2bdfc985-1011-d866-7e89-32baf8f1669b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 29 Oct 2021 18:50:57 +0100 Ferruh Yigit wrote: > On 10/20/2021 10:42 PM, Stephen Hemminger wrote: > > + /* DPDK reports in units of Mbps */ > > + rte_eth_link_get(port, &link); > > + if (link.link_status == ETH_LINK_UP) > > Should use renamed 'RTE_ETH_LINK_UP' macro with RTE_ prefix. Sure, that wasn't there when this was first written. Should we deprecate old one?