From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22DDCA0C57; Mon, 1 Nov 2021 17:15:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9CADB40E28; Mon, 1 Nov 2021 17:15:52 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id A83CC40DF6 for ; Mon, 1 Nov 2021 17:15:51 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id y14-20020a17090a2b4e00b001a5824f4918so9570948pjc.4 for ; Mon, 01 Nov 2021 09:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HFmQ53W+Ma5X+XwXCuKqd37wONtOpstksb/Isw7roCw=; b=jf2v+mpOFoutLRD9BLFCqvXT/nytcOQDW8ajLc9quaW/iXOKurk8jEmLAfZCg0d/Fn VDCxz0zfr/RwTCt/IhiBTW1MBaC1UqzN3nv6q/7FZKA/1O3oHOmyYNVktLsLLkoM/Vv7 asyuRj5LaalC5xb37C3+iiyVBRx8p/liJJAKyh9m+XY0Y2jkT0aNikQ200ZT1Uy36aG0 5AbbKBHYf1dW1bWM6h785F4+uysKWy5mrcM5Jb61l8ehoatTlsiL1p2ZOYhwuA3g+NiT Es3Dq7q/tpfq8mMNgKEp4qz9zcAvS2sLpQbL8uK+go6FqVdzpHmzYsCvjQwa01fo+Qo0 Pazg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HFmQ53W+Ma5X+XwXCuKqd37wONtOpstksb/Isw7roCw=; b=Xt3vtTmi7RBcguPe4hKKY+8F8u8Ws1qzXV7NUL8kfEP2xWHe9CghZjOTQW8m2BuFQ3 wkZPQX+SPgeNJeAIxsB8cycyTzIMbfk9yCFXbBlmZUSqCuLl0rnI1v6TcRnHYWdOau/p XNdX8ysthFLH2gpXya8PUUtkq580p8eGZorJNipCbze8AVv4Zf56XgetBB61vpAw2DVg ceit/bY5w1JIAar5G4z7BA9igrsEV25/QGkaqanGNKbm4Mx9Z3hadg41ej4KS5BptKvH QMTdSORF5vKXz0tBg68S2RTXTYL3zt9lGdwR/kSzL0J9Ou8YuUd+3i2qQSbP01S3Cgxw y4NA== X-Gm-Message-State: AOAM530D3LKkVdCGddW3zqd1ojzh1ptisYDCWnhorRt84trnZ04Shy65 puXEcbQbtDCFvEkvNtTuOfSdeA== X-Google-Smtp-Source: ABdhPJxdwYcDKpB/Peugv10TwEN4KKFmQJtpPjcNzLpTYLCCNjEHMFvdDgYzIqWELxoKH+lux2K3ng== X-Received: by 2002:a17:902:b18b:b0:13a:354a:3e9d with SMTP id s11-20020a170902b18b00b0013a354a3e9dmr26063723plr.36.1635783344813; Mon, 01 Nov 2021 09:15:44 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id 130sm6777284pfu.170.2021.11.01.09.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:15:44 -0700 (PDT) Date: Mon, 1 Nov 2021 09:15:42 -0700 From: Stephen Hemminger To: Konstantin Ananyev Cc: dev@dpdk.org Message-ID: <20211101091542.0ac30da8@hermes.local> In-Reply-To: <20211101145246.23465-1-konstantin.ananyev@intel.com> References: <20211101145246.23465-1-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] bpf: fix convert API can be undefined X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 1 Nov 2021 14:52:46 +0000 Konstantin Ananyev wrote: > rte_bpf_convert() implementation depends on libpcap. > Right now it is defined only when this library is installed and > RTE_PORT_PCAP is defined. > Fix that by providing for such case stub rte_bpf_convert() > implementation that will always return an error. > Also move stub for another function (rte_bpf_elf_load) into > the same place (bpf_stub.c). > > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") > > Signed-off-by: Konstantin Ananyev It would be better to fail calls at compile time rather than returning an error.