From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64508A0C4E; Tue, 2 Nov 2021 09:10:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A677410FF; Tue, 2 Nov 2021 09:10:55 +0100 (CET) Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by mails.dpdk.org (Postfix) with ESMTP id 4C4D140DF6 for ; Tue, 2 Nov 2021 09:10:53 +0100 (CET) X-QQ-mid: bizesmtp34t1635840640twp1z7gq Received: from jiawenwu.trustnetic.com (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Tue, 02 Nov 2021 16:10:33 +0800 (CST) X-QQ-SSF: 01400000002000E0I000000A0000000 X-QQ-FEAT: SAUrQiVpIXFSVnQV2zxVc/y4+sgs7r3HNyXpSRvgiqBq25NwhIbEThWHlXJFz 2VbgW3s4ZQj0CzT9I39l5PEiOpRf+6Q8M9YSldF6r1lugAwI33rzu/SzsljR7oG2VKF25kU nHZUISKDEVJXSlhUunVHaj45Z+WRovEBgP5nuLm2O3NMmxIFDRPr1/ssY9Gus0dhotSg5ph UQdvpUGw/9vc03ORMFKdl/yh2DnsTsvO0QDKGtU0Ha1fy6t1TxUfHxm5gpynV6/FTXl/mkr +56BHYqqK328IqFrNSR+F+UqwzXXiNtj0wymPmZT+vdXHKBknsEibuWwXFKnANAM2kl+WfB dwIvgnM6SFh0RdgAivX/70zB/GqZH0+nA6J3gRzNMciFhKQtQU= X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Date: Tue, 2 Nov 2021 16:10:26 +0800 Message-Id: <20211102081026.22440-2-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20211102081026.22440-1-jiawenwu@trustnetic.com> References: <20211102081026.22440-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Subject: [dpdk-dev] [PATCH 2/2] net/txgbe: fix link process in KR mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Set the 'present' parameter to 0 by default. It is configured by hardware, users can set it to 1 for manual configuration. Fixes: f611dada1af8 ("net/txgbe: update link setup process of backplane NICs") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_phy.c | 2 +- drivers/net/txgbe/txgbe_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_phy.c b/drivers/net/txgbe/base/txgbe_phy.c index 2db87ae0c5..3f5229ecc2 100644 --- a/drivers/net/txgbe/base/txgbe_phy.c +++ b/drivers/net/txgbe/base/txgbe_phy.c @@ -1456,7 +1456,7 @@ txgbe_set_link_to_kr(struct txgbe_hw *hw, bool autoneg) wr32_epcs(hw, SR_AN_CTRL, 0); wr32_epcs(hw, VR_AN_KR_MODE_CL, 0); } - if (hw->devarg.present == 1) { + if (hw->devarg.present == 1) { value = rd32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1); value |= TXGBE_PHY_TX_EQ_CTL1_DEF; wr32_epcs(hw, TXGBE_PHY_TX_EQ_CTL1, value); diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 169272ded5..8628ce455f 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -495,7 +495,7 @@ txgbe_parse_devargs(struct txgbe_hw *hw, struct rte_devargs *devargs) struct rte_kvargs *kvlist; u16 auto_neg = 1; u16 poll = 0; - u16 present = 1; + u16 present = 0; u16 sgmii = 0; u16 ffe_set = 0; u16 ffe_main = 27; -- 2.21.0.windows.1