DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: <dev@dpdk.org>
Cc: <viacheslavo@nvidia.com>, <stable@dpdk.org>,
	Ori Kam <orika@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com>
Subject: [dpdk-dev] [PATCH] app/testpmd: fix gtp psc extention header length
Date: Thu, 4 Nov 2021 11:35:16 +0200	[thread overview]
Message-ID: <20211104093518.8922-1-rasland@nvidia.com> (raw)

Current implementation for raw encap sets the length to be in bytes,
but, GTP extention header length is an 8-bit feild in 4-octet units.

This fixes the length calculation of the header length.

Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
Cc: viacheslavo@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 24b224e632..b4c5aacdbe 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
 					uint8_t qfi:6;
 					uint8_t next;
 				} psc;
-				psc.len = sizeof(psc);
+				psc.len = sizeof(psc) / 4;
 				psc.pdu_type = opt->hdr.type;
 				psc.qfi = opt->hdr.qfi;
 				psc.next = 0;
-- 
2.25.1


             reply	other threads:[~2021-11-04  9:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  9:35 Raslan Darawsheh [this message]
2021-11-04  9:40 ` [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension " Raslan Darawsheh
2021-11-15 19:02   ` Ferruh Yigit
2021-11-16 13:42     ` Slava Ovsiienko
2021-11-16 14:27       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104093518.8922-1-rasland@nvidia.com \
    --to=rasland@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=orika@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).