DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix gtp psc extention header length
@ 2021-11-04  9:35 Raslan Darawsheh
  2021-11-04  9:40 ` [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension " Raslan Darawsheh
  0 siblings, 1 reply; 5+ messages in thread
From: Raslan Darawsheh @ 2021-11-04  9:35 UTC (permalink / raw)
  To: dev; +Cc: viacheslavo, stable, Ori Kam, Xiaoyun Li

Current implementation for raw encap sets the length to be in bytes,
but, GTP extention header length is an 8-bit feild in 4-octet units.

This fixes the length calculation of the header length.

Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
Cc: viacheslavo@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 24b224e632..b4c5aacdbe 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -9213,7 +9213,7 @@ cmd_set_raw_parsed(const struct buffer *in)
 					uint8_t qfi:6;
 					uint8_t next;
 				} psc;
-				psc.len = sizeof(psc);
+				psc.len = sizeof(psc) / 4;
 				psc.pdu_type = opt->hdr.type;
 				psc.qfi = opt->hdr.qfi;
 				psc.next = 0;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-16 14:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04  9:35 [dpdk-dev] [PATCH] app/testpmd: fix gtp psc extention header length Raslan Darawsheh
2021-11-04  9:40 ` [dpdk-dev] [PATCH v2] app/testpmd: fix gtp psc extension " Raslan Darawsheh
2021-11-15 19:02   ` Ferruh Yigit
2021-11-16 13:42     ` Slava Ovsiienko
2021-11-16 14:27       ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).