From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E258A0C55; Fri, 5 Nov 2021 17:26:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CF4C40E5A; Fri, 5 Nov 2021 17:26:56 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 62B5940689 for ; Fri, 5 Nov 2021 17:26:55 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id n8so11407353plf.4 for ; Fri, 05 Nov 2021 09:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SO7goIQD2oP7brykyLo6yYn3CbW+uw2Ok5ryi3AVkFg=; b=0Kzde6e4763oDO3n0DKgFhtM3VcYzZRCxUt99gKixN6lE+V6IZ2Ov/E0E9ELp0DRdk vVGSDmCMHY/yZaPtbT1rcHfHvNu4/LHSdcEXPGf17o2f44dKnjz1X37upQIJEviLv+H8 yfil/zc66pwMLP35wUMVW1pe7uEeyRg6dLezucU7XYwmgjW5Dxp3HA+Cw+NN458mubFs IyjG6P61i/REdF1+INp/INYUIEk38bgOILYVAtMrGKJQuVhNvg7ru5R50C93W/R2nljb 0f46FtBJ0JfX6/A8wHJn2bUh5JTSogYM+5LiAUkQGR5vYUoF0D+hTOvDd5XrmBbRTqfa MuyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SO7goIQD2oP7brykyLo6yYn3CbW+uw2Ok5ryi3AVkFg=; b=Ur2+WfEU5XGbj10G6oio5Lh+6OzdKqHYWx+d0537ULGNFsLaqSq/rfawOx1n8DQOVV pIJ36he1wnk+rLrPMP+NnU6l+IRhWKYpIqjgLonAwDpEvfmmcPMzutnJ9EF9XrBHe6e4 zSrq+/SYT+AYvJdNZndAZTMTccx1o7XdysSzgNP+/foxXxmmT2dE8C19qdb7IBj0Qa/g 0FJZIdjHsmolG8k9is45HfNpPasYAq4EpcL60NwuHEni2YLhFpjShoF3APEf/m6zNAT5 3m04mLrxXo/7/SI5ao/hfcG11WubHHuAQszSxaC2tZF2vbIUxqYy2D5wmXb4UZsomWZe 2DxA== X-Gm-Message-State: AOAM531ZZfKyBQ6FkhGhGsnsQpj+Pupxek3CP0npKY119pHyV9B/GnVJ WqnUJTJQ4aER/VDma63vmSWvSA== X-Google-Smtp-Source: ABdhPJws1uwzumpsRJOS1YbPY28kmLze2Y+K/VydoC4lbOVakBxEhnrRnKnhYZ1VL1PA8goYE1Dn9A== X-Received: by 2002:a17:90b:3a83:: with SMTP id om3mr11774468pjb.0.1636129614594; Fri, 05 Nov 2021 09:26:54 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id x2sm4842280pfd.144.2021.11.05.09.26.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 09:26:54 -0700 (PDT) Date: Fri, 5 Nov 2021 09:26:49 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, David Marchand , Olivier Matz Message-ID: <20211105092649.32fadae4@hermes.local> In-Reply-To: <2425969.3b2ZdX0MHy@thomas> References: <20211102234434.2639807-1-ferruh.yigit@intel.com> <2611380.4jmpmGm5TL@thomas> <0db26ffd-1c1c-e920-0390-ee863862b071@oktetlabs.ru> <2425969.3b2ZdX0MHy@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 05 Nov 2021 16:05:14 +0100 Thomas Monjalon wrote: > > >> > > >> What do you think about marking old macros as deprecated? > > >> > > >> This will cause warning in application code that is using > > >> old macros, but shouldn't fail their build (unless -Werror > > >> is issued). > > > > > > It looks to be the right thing to do. > > > I wonder whether we could wait 22.02 to apply it, > > > so users of LTS are not annoyed by it. > > > > I have no strong opinion, but tend to agree with Thomas. > > However, if an application jumps from LTS to LTS, these > > defines will be available in 21.11 without any warnings > > and simply disappear in 22.11. So, may be it is more > > friendly to deprecate in 21.11. > > That's true for a lot of deprecations done in the year. > Jumping from LTS to LTS is for production. > Intermediate releases should help in the upgrade preparation process. Agree, the deprecation cycle is long enough and it is just a trivial warning easy to fix, or for those that ignore warnings they just won't care.