* [dpdk-dev] [PATCH] app: fix testpmd dependency on jansson
@ 2021-11-05 13:29 David Marchand
2021-11-07 6:32 ` Gregory Etelson
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-11-05 13:29 UTC (permalink / raw)
To: dev
Cc: bruce.richardson, ferruh.yigit, thomas, Viacheslav Ovsiienko,
Gregory Etelson
ext_deps is not used in app/meson.build.
testpmd currently can be linked because metrics library is pulling
the dependency on libjansson.
Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
app/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/meson.build b/app/meson.build
index e41a2e3902..986c1a4ad4 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -61,7 +61,7 @@ foreach app:apps
c_args: cflags,
link_args: ldflags,
link_whole: link_libs,
- dependencies: dep_objs,
+ dependencies: ext_deps + dep_objs,
include_directories: includes,
install_rpath: join_paths(get_option('prefix'), driver_install_path),
install: true)
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app: fix testpmd dependency on jansson
2021-11-05 13:29 [dpdk-dev] [PATCH] app: fix testpmd dependency on jansson David Marchand
@ 2021-11-07 6:32 ` Gregory Etelson
2021-11-07 16:19 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Gregory Etelson @ 2021-11-07 6:32 UTC (permalink / raw)
To: David Marchand, dev
Cc: bruce.richardson, ferruh.yigit, NBU-Contact-Thomas Monjalon,
Slava Ovsiienko
Hello David,
Thank you for the update.
Regards,
Gregory
>
> ext_deps is not used in app/meson.build.
> testpmd currently can be linked because metrics
> library is pulling
> the dependency on libjansson.
>
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> item commands")
>
> Signed-off-by: David Marchand
> <david.marchand@redhat.com>
> ---
> app/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/meson.build b/app/meson.build
> index e41a2e3902..986c1a4ad4 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -61,7 +61,7 @@ foreach app:apps
> c_args: cflags,
> link_args: ldflags,
> link_whole: link_libs,
> - dependencies: dep_objs,
> + dependencies: ext_deps + dep_objs,
Reviewed-by: Gregory Etelson <getelson@nvidia.com>
> include_directories: includes,
> install_rpath:
> join_paths(get_option('prefix'),
> driver_install_path),
> install: true)
> --
> 2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app: fix testpmd dependency on jansson
2021-11-07 6:32 ` Gregory Etelson
@ 2021-11-07 16:19 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-11-07 16:19 UTC (permalink / raw)
To: David Marchand
Cc: dev, bruce.richardson, ferruh.yigit, Slava Ovsiienko, Gregory Etelson
Strictly speaking, the jansson dependency is already described,
so the fix is more about fixing the linking in general.
That's why I chose this title: "app: fix external dependency linking"
> > ext_deps is not used in app/meson.build.
> > testpmd currently can be linked because metrics
> > library is pulling
> > the dependency on libjansson.
> >
> > Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> > item commands")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
[...]
> > --- a/app/meson.build
> > +++ b/app/meson.build
> > - dependencies: dep_objs,
> > + dependencies: ext_deps + dep_objs,
>
> Reviewed-by: Gregory Etelson <getelson@nvidia.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-07 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 13:29 [dpdk-dev] [PATCH] app: fix testpmd dependency on jansson David Marchand
2021-11-07 6:32 ` Gregory Etelson
2021-11-07 16:19 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).