DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raja Zidane <rzidane@nvidia.com>
To: <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH V2 2/4] crypto/mlx5: fix driver destroy before the configuration
Date: Mon, 8 Nov 2021 12:33:52 +0000	[thread overview]
Message-ID: <20211108123354.2194-3-rzidane@nvidia.com> (raw)
In-Reply-To: <20211108123354.2194-1-rzidane@nvidia.com>

When calling device close, unset dek is called which destroys a hash list.
In case of error during dev probe, close is called when dek hlist is not
initialized.
Ensure non null list destroy.

Fixes: 90646d6c6e22 ("crypto/mlx5: support basic operations")
Cc: stable@dpdk.org

Signed-off-by: Raja Zidane <rzidane@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/crypto/mlx5/mlx5_crypto_dek.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/mlx5/mlx5_crypto_dek.c b/drivers/crypto/mlx5/mlx5_crypto_dek.c
index de0d2545d1..472ee373aa 100644
--- a/drivers/crypto/mlx5/mlx5_crypto_dek.c
+++ b/drivers/crypto/mlx5/mlx5_crypto_dek.c
@@ -156,6 +156,8 @@ mlx5_crypto_dek_setup(struct mlx5_crypto_priv *priv)
 void
 mlx5_crypto_dek_unset(struct mlx5_crypto_priv *priv)
 {
-	mlx5_hlist_destroy(priv->dek_hlist);
-	priv->dek_hlist = NULL;
+	if (priv->dek_hlist) {
+		mlx5_hlist_destroy(priv->dek_hlist);
+		priv->dek_hlist = NULL;
+	}
 }
-- 
2.17.1


  parent reply	other threads:[~2021-11-08 12:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 12:49 [dpdk-dev] [PATCH 0/4] fixes to queue size config Raja Zidane
2021-11-04 12:49 ` [dpdk-dev] [PATCH 1/4] common/mlx5: fix overflows in DevX queues size calculations Raja Zidane
2021-11-04 12:49 ` [dpdk-dev] [PATCH 2/4] crypto/mlx5: fix driver destroy before the configuration Raja Zidane
2021-11-04 12:49 ` [dpdk-dev] [PATCH 3/4] crypto/mlx5: fix the queue size configuration Raja Zidane
2021-11-04 18:59   ` Tal Shnaiderman
2021-11-04 12:49 ` [dpdk-dev] [PATCH 4/4] common/mlx5: fix RQ size configuration in QP create Raja Zidane
2021-11-08  9:02 ` [dpdk-dev] [PATCH 0/4] fixes to queue size config Thomas Monjalon
2021-11-08 12:33 ` [dpdk-dev] [PATCH V2 " Raja Zidane
2021-11-08 12:33   ` [dpdk-dev] [PATCH V2 1/4] common/mlx5: fix overflows in DevX queues size calculations Raja Zidane
2021-11-08 12:33   ` Raja Zidane [this message]
2021-11-08 12:33   ` [dpdk-dev] [PATCH V2 3/4] crypto/mlx5: fix the queue size configuration Raja Zidane
2021-11-08 12:33   ` [dpdk-dev] [PATCH V2 4/4] common/mlx5: fix RQ size configuration in QP create Raja Zidane
2021-11-08 13:09   ` [dpdk-dev] [PATCH V2 0/4] fixes to queue size config Raja Zidane
2021-11-08 13:09     ` [dpdk-dev] [PATCH V2 1/4] common/mlx5: fix overflows in DevX queues size calculations Raja Zidane
2021-11-08 13:09     ` [dpdk-dev] [PATCH V2 2/4] crypto/mlx5: fix driver destroy before the configuration Raja Zidane
2021-11-08 13:09     ` [dpdk-dev] [PATCH V2 3/4] crypto/mlx5: fix the queue size configuration Raja Zidane
2021-11-08 13:09     ` [dpdk-dev] [PATCH V2 4/4] common/mlx5: fix RQ size configuration in QP create Raja Zidane
2021-11-08 18:44     ` [dpdk-dev] [PATCH V2 0/4] fixes to queue size config Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108123354.2194-3-rzidane@nvidia.com \
    --to=rzidane@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).