DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] build: enable ASan for arm64
@ 2021-11-08 13:45 Volodymyr Fialko
  2021-11-08 15:01 ` David Marchand
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Volodymyr Fialko @ 2021-11-08 13:45 UTC (permalink / raw)
  To: dev, Bruce Richardson, Anatoly Burakov; +Cc: jerinj, Volodymyr Fialko

This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan
documentation. This offset should cover all arm64 VMAs supported by
ASan.

Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
 config/meson.build             | 2 +-
 doc/guides/prog_guide/asan.rst | 2 +-
 lib/eal/common/malloc_elem.h   | 3 +++
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/config/meson.build b/config/meson.build
index 17b5bec406..7eb710c08d 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -428,7 +428,7 @@ if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == 'address
         dpdk_extra_ldflags += '-lasan'
     endif
 
-    if is_linux and arch_subdir == 'x86' and dpdk_conf.get('RTE_ARCH_64')
+    if is_linux and arch_subdir in ['x86', 'arm'] and dpdk_conf.get('RTE_ARCH_64')
         dpdk_conf.set10('RTE_MALLOC_ASAN', true)
     endif
 endif
diff --git a/doc/guides/prog_guide/asan.rst b/doc/guides/prog_guide/asan.rst
index 6d1b871c93..7a584427dd 100644
--- a/doc/guides/prog_guide/asan.rst
+++ b/doc/guides/prog_guide/asan.rst
@@ -33,7 +33,7 @@ Example::
     "stty echo" command when an error occurs.
 
 ASan is aware of DPDK memory allocations, thanks to added instrumentation.
-This is only enabled on x86_64 at the moment.
+This is only enabled on x86_64 and arm64 at the moment.
 Other architectures may have to define ASAN_SHADOW_OFFSET.
 
 Example heap-buffer-overflow error
diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
index 262d69bb3e..c00c7845ab 100644
--- a/lib/eal/common/malloc_elem.h
+++ b/lib/eal/common/malloc_elem.h
@@ -107,6 +107,9 @@ malloc_elem_cookies_ok(const struct malloc_elem *elem)
 #ifdef RTE_ARCH_X86_64
 #define ASAN_SHADOW_OFFSET    0x00007fff8000
 #endif
+#ifdef RTE_ARCH_ARM64
+#define ASAN_SHADOW_OFFSET    0x001000000000
+#endif
 
 #define ASAN_SHADOW_GRAIN_SIZE	8
 #define ASAN_MEM_FREE_FLAG	0xfd
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2] eal/arm64: support ASan
@ 2021-11-08 22:34 Volodymyr Fialko
  0 siblings, 0 replies; 8+ messages in thread
From: Volodymyr Fialko @ 2021-11-08 22:34 UTC (permalink / raw)
  To: dev, Bruce Richardson, Anatoly Burakov
  Cc: jerinj, Volodymyr Fialko, David Marchand

This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan
documentation. This offset should cover all arm64 VMAs supported by
ASan.

Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
Changes since v1:
- changed the subject
- rewrite checks in "elif" manner
---
 config/meson.build             | 2 +-
 doc/guides/prog_guide/asan.rst | 2 +-
 lib/eal/common/malloc_elem.h   | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/config/meson.build b/config/meson.build
index 17b5bec406..7eb710c08d 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -428,7 +428,7 @@ if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == 'address
         dpdk_extra_ldflags += '-lasan'
     endif
 
-    if is_linux and arch_subdir == 'x86' and dpdk_conf.get('RTE_ARCH_64')
+    if is_linux and arch_subdir in ['x86', 'arm'] and dpdk_conf.get('RTE_ARCH_64')
         dpdk_conf.set10('RTE_MALLOC_ASAN', true)
     endif
 endif
diff --git a/doc/guides/prog_guide/asan.rst b/doc/guides/prog_guide/asan.rst
index 6d1b871c93..28b2382fc7 100644
--- a/doc/guides/prog_guide/asan.rst
+++ b/doc/guides/prog_guide/asan.rst
@@ -33,7 +33,7 @@ Example::
     "stty echo" command when an error occurs.
 
 ASan is aware of DPDK memory allocations, thanks to added instrumentation.
-This is only enabled on x86_64 at the moment.
+This is enabled on x86_64 and arm64 at the moment.
 Other architectures may have to define ASAN_SHADOW_OFFSET.
 
 Example heap-buffer-overflow error
diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
index 262d69bb3e..26e937cea0 100644
--- a/lib/eal/common/malloc_elem.h
+++ b/lib/eal/common/malloc_elem.h
@@ -106,6 +106,8 @@ malloc_elem_cookies_ok(const struct malloc_elem *elem)
 
 #ifdef RTE_ARCH_X86_64
 #define ASAN_SHADOW_OFFSET    0x00007fff8000
+#elif defined(RTE_ARCH_ARM64)
+#define ASAN_SHADOW_OFFSET    0x001000000000
 #endif
 
 #define ASAN_SHADOW_GRAIN_SIZE	8
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-11-12 13:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-08 13:45 [dpdk-dev] [PATCH] build: enable ASan for arm64 Volodymyr Fialko
2021-11-08 15:01 ` David Marchand
2021-11-08 16:37 ` Jerin Jacob
2021-11-08 22:45 ` [dpdk-dev] [PATCH v2] eal/arm64: support ASan Volodymyr Fialko
2021-11-09  5:39   ` Ruifeng Wang
2021-11-09  9:59 ` [dpdk-dev] [PATCH v3] " Volodymyr Fialko
2021-11-12 13:34   ` David Marchand
2021-11-08 22:34 [dpdk-dev] [PATCH v2] " Volodymyr Fialko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).