From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9098CA0C4B;
	Tue,  9 Nov 2021 03:07:36 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 58B2C4068B;
	Tue,  9 Nov 2021 03:07:36 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 858E840151
 for <dev@dpdk.org>; Tue,  9 Nov 2021 03:07:35 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id D423520ABAF3; Mon,  8 Nov 2021 18:07:34 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D423520ABAF3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1636423654;
 bh=DGP1wb5iaMDel7vBA9JaqHmqFYv5QDK39t0lo+xzPx4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=sMkDP83cXwaS21mV87y1yzXrDEyMiQ0Wpb5o85AY7fCGdq1CZ35555dOqpNttbgUf
 oatEUQP+RrgRO0GN7eiGWL6Ca4xxEz15TsM0v7jUs3FQl7S9ITS+rbQ8g2REdbJItb
 tp+B16M2QWArNV1Ts4ZJEqEDVN5HNZv9F5EQfRlQ=
Date: Mon, 8 Nov 2021 18:07:34 -0800
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, khot@microsoft.com,
 dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com,
 ocardona@microsoft.com, bruce.richardson@intel.com,
 david.marchand@redhat.com, pallavi.kadam@intel.com
Message-ID: <20211109020734.GE12569@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1633732841-17873-1-git-send-email-navasile@linux.microsoft.com>
 <1633765318-28356-1-git-send-email-navasile@linux.microsoft.com>
 <1633765318-28356-9-git-send-email-navasile@linux.microsoft.com>
 <27236504.5ELz80oB1M@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <27236504.5ELz80oB1M@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v16 8/9] eal: implement functions for thread
 barrier management
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Oct 12, 2021 at 06:32:09PM +0200, Thomas Monjalon wrote:
> 09/10/2021 09:41, Narcisa Ana Maria Vasile:
> > From: Narcisa Vasile <navasile@microsoft.com>
> > 
> > Add functions for barrier init, destroy, wait.
> > 
> > A portable type is used to represent a barrier identifier.
> > The rte_thread_barrier_wait() function returns the same value
> > on all platforms.
> > 
> > Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> > ---
> >  lib/eal/common/rte_thread.c  | 61 ++++++++++++++++++++++++++++++++++++
> >  lib/eal/include/rte_thread.h | 58 ++++++++++++++++++++++++++++++++++
> >  lib/eal/version.map          |  3 ++
> >  lib/eal/windows/rte_thread.c | 56 +++++++++++++++++++++++++++++++++
> >  4 files changed, 178 insertions(+)
> 
> It doesn't need to be part of the API.
> The pthread barrier is used only as part of the control thread implementation.
> The need disappear if you implement control thread on Windows.
> 
Actually I think I have the implementation already. I've worked at this some time ago,
I have this patch:
[v4,2/6] eal: add function for control thread creation

The issue is I will break ABI so I cannot merge it as part of this patchset.
I'll see if I can remove this barrier patch though.